Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improving using-devcontainers.mdx in v0.28.0 #4950

Closed
wants to merge 2 commits into from

Conversation

ziyinlox-purple
Copy link

Description

Problem*

Resolves #4680

Summary*

Previous:#4844
This pr is for the latest version 0.28.0

Additional Context

Update:
1.https://github.com/noir-lang/noir/blob/master/docs/docs/how_to/using-devcontainers.mdx
2. https://github.com/noir-lang/noir/blob/master/docs/versioned_docs/version-v0.28.0/how_to/using-devcontainers.mdx

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Contributor

github-actions bot commented May 1, 2024

Thank you for your contribution to the Noir language.

Please do not force push to this branch after the Noir team have started review of this PR. Doing so will only delay us merging your PR as we will need to start the review process from scratch.

Thanks for your understanding.

@TomAFrench
Copy link
Member

TomAFrench commented May 1, 2024

Can you make this change in the existing PR? It doesn't really make sense to split them up like this.

@ziyinlox-purple
Copy link
Author

ziyinlox-purple commented May 1, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: One step is missing in docs
2 participants