-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update using-devcontainers.mdx #4844
Conversation
This improvement was already discussed in noir-lang#4680
Thank you for your contribution to the Noir language. Please do not force push to this branch after the Noir team have started review of this PR. Doing so will only delay us merging your PR as we will need to start the review process from scratch. Thanks for your understanding. |
Hey @ziyinlox-purple thanks for your contrib and bugfix. Can I ask if you could put these commands inside the Dockerfile itself or in the "onCreateCommand" property of Totally fine if you don't feel like it, just let me know and I can do it. We could then merge this one :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Asking stuff
ok,I will put it into the |
1. add commit and push command in `devcontainer.json` 2. change the previous operation descriptions
Have done, check it please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this only relevant for v0.26? You are only updating this version.
No, this is not limited to version v0.26. A step was missing in the
original documentation, which may have confused developers who haven't used
devcontainer before, or they may need to refer back to the video for
guidance. The modified code can now assist them directly in reducing steps
during Codespace creation without affecting the security of subsequent
operations. I'm happy to provide any further explanations or modifications
if needed.🫡
josh crites ***@***.***> 于2024年4月25日周四 03:25写道:
… ***@***.**** commented on this pull request.
Is this only relevant for v0.26? You are only updating this version.
—
Reply to this email directly, view it on GitHub
<#4844 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A43QUXIPJO5L2J4MU45N62LY7ABJTAVCNFSM6AAAAABGOXYKYOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMRQG42DANRZGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@ziyinlox-purple the noir docs are versioned. if you want to update the recent version, you need to update this file (and optionally this one) |
Already Updated! 🌞
Cat McGee ***@***.***> 于2024年4月30日周二 22:39写道:
… @ziyinlox-purple <https://github.com/ziyinlox-purple> the noir docs are
versioned. if you want to update the recent version, you need to update this
file
<https://github.com/noir-lang/noir/blob/master/docs/docs/how_to/using-devcontainers.mdx>
(and optionally this one
<https://github.com/noir-lang/noir/blob/master/docs/versioned_docs/version-v0.28.0/how_to/using-devcontainers.mdx>
)
—
Reply to this email directly, view it on GitHub
<#4844 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A43QUXIZNAVBYM424BNNRKLY76UIRAVCNFSM6AAAAABGOXYKYOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBVGUZDONZVGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
update in v0.28.0
moving the changes to v0.28.0 and recover the changes of v0.26.0
@signorecello what's the status of this PR? |
Description
Problem*
Resolves #4680
Summary*
Supplementing the missing creation step 7
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmt
on default settings.