Merge branch 'master' into checked-prove

* master: (28 commits)
  chore(ci): Add release token to enable runs against release PR (#840)
  feat(ssa): array sort (#754)
  chore: update readme (#811)
  chore: fix clippy (#825)
  chore: remove stale comment on HirFunction.unchecked_from_expr (#827)
  chore: Getter naming refactor (#803)
  chore: updated "HirFunction::unsafe_from_expr" to "HirFunction::unchecked_from_expr" (#823)
  chore: Forbid unsafe code (#824)
  chore: Follow rust naming convention (#801)
  feat(ci): Add concurrency group for rust workflow (#806)
  chore(ssa): rename impl method to follow Rust guideline (#782)
  fix(nargo): `nargo test` now only runs test functions defined in the current module (#805)
  chore(nargo): Remove outdated error message when Prover/Verifier.toml is missing (#807)
  chore(ssa): rename codegen to ssa_gen + reorg of `Value` struct (#797)
  chore(nargo): abstract paths from nargo's working directory (#761)
  chore(ci): Rename workflows (#804)
  feat: Impls with generics (#798)
  chore(ssa): Add doc comments on `Opcode` struct (#778)
  fix: operators issuing type errors when used with matching integer types arising from generic code (#789)
  chore(nargo)!: bump MSRV to 1.66.0 (#799)
  ...

.github/workflows/pull-request.yml

@@ -1,6 +1,11 @@
 name: Pull Request
 
 on:
+  # merge_group:
+  # The `merge_group` event is currently broken (Feb 9th) so we use `push` and scope the branches
+  push:
+    branches:
+      - gh-readonly-queue/master/*
   pull_request_target:
     types:
       - opened
@@ -17,6 +22,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Check title
+        if: github.event_name == 'pull_request_target'
         uses: amannn/action-semantic-pull-request@v5
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/release.yml

@@ -17,6 +17,7 @@ jobs:
         id: release
         uses: google-github-actions/release-please-action@v3
         with:
+          token: ${{ secrets.NOIR_RELEASES_TOKEN }}
           release-type: simple
           package-name: noir
           bump-minor-pre-major: true

.github/workflows/rust.yml

@@ -2,26 +2,24 @@ name: Rust
 
 on: [push, pull_request]
 
+# This will cancel previous runs when a branch or PR is updated
+concurrency:
+  group: ${{ github.workflow }}-${{ github.head_ref || github.ref || github.run_id }}
+  cancel-in-progress: true
+
 jobs:
-  check_n_test:
-    name: cargo check & test
+  test:
+    name: Cargo test
     uses: noir-lang/.github/.github/workflows/rust-test.yml@main
 
   clippy:
-    name: cargo clippy
+    name: Cargo clippy
     uses: noir-lang/.github/.github/workflows/rust-clippy.yml@main
 
   format:
-    name: cargo fmt
+    name: Cargo fmt
     uses: noir-lang/.github/.github/workflows/rust-format.yml@main
 
   spellcheck:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v3
-      - uses: streetsidesoftware/cspell-action@v2
-        with:
-          files: |
-            **/*.{md,rs}
-          incremental_files_only: true # Run this action on files which have changed in PR
-          strict: false # Do not fail, if a spelling mistake is found (This can be annoying for contributors)
+    name: Spellcheck
+    uses: noir-lang/.github/.github/workflows/spellcheck.yml@main