-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to override test suite name #25
Conversation
* isort: —rc is now deprecated * Add blank line to placate isort (lifted from #25) * Make isort a mandatory test * isort --verbose to document files skipped * isort --verbose is too verbose
For information, please do not merge this one already (first I'll rebase and second I search how to improve xml formatting). To compare I have an xml produced by pytest framework (pytest_xml.txt which gives this structure in jenkins: I have also an xml (sfxlib_xml.txt produced by tap2junit from the following tap file (sfxlib_tap.txt which gives this output: I don't understand the presences of testsuites at top of the file generated by tap2junit (while the one with pytest don't have it) and also I think the use of classname attribute may help the output (because like you can see in the screenshot, I have this ugly "(root)" at first) |
Because the default might not be suitable for all usage (full input file path without extenstion) Signed-off-by: Frederic Martinsons <frederic.martinsons@sigfox.com>
I don't see that to be a implicit vs explicit problem but to let the user choose if he wants to (because there is no special reason for using the filename currently being parsed for the testsuite name, they can be totally unrelated to what the testuiste name is). |
Signed-off-by: Frederic Martinsons <frederic.martinsons@sigfox.com>
…Case In order to allow a better formatting of the junit XML result and not hardcode None into classname attribute if we can avoid it. Add also a test with test description contains '.' Signed-off-by: Frederic Martinsons <frederic.martinsons@sigfox.com>
Signed-off-by: Frederic Martinsons <frederic.martinsons@sigfox.com>
Hello @cclauss , any chance to land this merge request ? Is my suggestion of changing the default value of test suite name and let the option to the user suits you ? |
Any news here ? |
Because the default might not be suitable for all usage
(full input file path without extenstion)
Signed-off-by: Frederic Martinsons frederic.martinsons@sigfox.com