Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isort: —rc is now deprecated #24

Merged
merged 5 commits into from
May 9, 2021
Merged

Conversation

cclauss
Copy link
Collaborator

@cclauss cclauss commented May 9, 2021

No description provided.

@fmartinsons
Copy link
Contributor

Oups, sorry for reintroduced this deprecated option. I just check and my distro had an oudated isort (4.3.4 on ubuntu 20.04), I reinstall it via pip and now it is 5.8.0 and have no more rc opts ;)

@cclauss
Copy link
Collaborator Author

cclauss commented May 9, 2021

I would like to remove the || true from the end of the isort line but I can not figure out why that test is failing with:

ERROR: /home/runner/work/tap2junit/tap2junit/tap2junit/__main__.py Imports are incorrectly sorted and/or formatted.

@fmartinsons
Copy link
Contributor

I would like to remove the || true from the end of the isort line but I can not figure out why that test is failing with:

ERROR: /home/runner/work/tap2junit/tap2junit/tap2junit/__main__.py Imports are incorrectly sorted and/or formatted.

Just a missing newline (i found it after upgrading isort and test without the --check-only switch), see #25 (which I'll rebase after this merge)

@cclauss cclauss merged commit adf657e into master May 9, 2021
@cclauss cclauss deleted the isort-—rc-is-now-deprecated branch May 9, 2021 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants