Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tap13 from upstream, reapply py3 compat again #19

Merged
merged 4 commits into from
Nov 1, 2019

Conversation

cclauss
Copy link
Collaborator

@cclauss cclauss commented Oct 27, 2019

Fixes: #18, nodejs/admin#413

Update tap13.py to latest (Apache licensed)

Pulled latest from upstream:

$ curl -o tap2junit/tap13.py \
                https://bitbucket.org/fedoraqa/pytap13/raw/master/pytap13.py

Note that upstream version is now under the Apache License 2.0.

@rvagg
Copy link
Member

rvagg commented Oct 27, 2019

@nodejs/python could we get some python people reviews please? Also if you could watch this repo and help out on reviewing PRs and with discussions that would be great. I promise it'll be extremely infrequent, it's just getting up to speed having just moved into the org.

@cclauss cclauss requested review from cjihrig, targos and Trott October 28, 2019 16:47
Copy link

@sam-github sam-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Licensing looks good, no comment on the python code.

Copy link
Member

@jbergstroem jbergstroem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cclauss cclauss merged commit dab991d into nodejs:master Nov 1, 2019
@cclauss cclauss deleted the update-tap13-again branch July 18, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants