Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tap13 from upstream, reapply py3 compatibility PR #18

Closed
wants to merge 3 commits into from

Conversation

sam-github
Copy link

@sam-github sam-github commented Oct 4, 2019

    Python 3 support

    Floating patch for Python 3 support.
    PR-URL: https://github.com/nodejs/tap2junit/pull/5

and

    Update tap13.py to latest (Apache licensed)

    Pulled lastest from upstream:

            $ curl -o tap2junit/tap13.py \
                https://bitbucket.org/fedoraqa/pytap13/raw/master/pytap13.py

    Note that the upstream version is now under the Apache License.

    Fixes https://github.com/nodejs/admin/issues/413

Fixes nodejs/admin#413

@sam-github
Copy link
Author

@rajcze @jbergstroem PTAL I had to reapply py3 compat, and the builtin tests are failing:

% python3 tap2junit/tap13.py
ok 1 - Input file opened # None None
None
None
not ok 2 - First line of the input valid # None None
['---',
 "        message: 'First line invalid'",
 '        severity: fail',
 '        data:',
 "          got: 'Flirble'",
 "          expect: 'Fnible'",
 '...']
{'data': {'expect': 'Fnible', 'got': 'Flirble'},
 'message': 'First line invalid',
 'severity': 'fail'}
ok 3 - Read the rest of the file # None None
None
None
not ok 4 None # None DIAG: Test 4 not present
None
None
not ok 5 - Summarized correctly  # TODO Not written yet
['---',
 '        message: "Can\'t make summary yet"',
 '        severity: todo',
 '...']
{'message': "Can't make summary yet", 'severity': 'todo'}
ok 6 Description # None None
['---',
 "        message: 'Failure message'",
 '        severity: fail',
 '        data:',
 '        got:',
 '            - 1',
 '            - 3',
 '            - 2',
 '        expect:',
 '            - 1',
 '            - 2',
 '            - 3',
 '...']
{'data': None,
 'expect': [1, 2, 3],
 'got': [1, 3, 2],
 'message': 'Failure message',
 'severity': 'fail'}
% echo $?
0

Its odd that exit code is 0 on success.

sam-github and others added 2 commits October 4, 2019 09:19
Pulled lastest from upstream:

        $ curl -o tap2junit/tap13.py \
            https://bitbucket.org/fedoraqa/pytap13/raw/master/pytap13.py

Note that the upstream version is now under the Apache License.

Fixes nodejs/admin#413
Floating patch for Python 3 support.

PR-URL: #5
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matt (IPv4) Cowley <me@mattcowley.co.uk>
@sam-github
Copy link
Author

@jbergstroem any thoughts? the new version has a license that doesn't cause any IP issues, do you think its functional?

@jbergstroem
Copy link
Member

@jbergstroem any thoughts? the new version has a license that doesn't cause any IP issues, do you think its functional?

Happy to merge it. I haven't had the time to look at the failing tests though..

@sam-github
Copy link
Author

@cclauss do you have any interest in figuring out how to make the updated tap13 work/pass tests?

@sam-github
Copy link
Author

Replaced by #19

@sam-github sam-github closed this Oct 28, 2019
@cclauss cclauss deleted the update-tap13 branch October 28, 2019 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transfer jenkins CI tool tap2junit into Node.js org
3 participants