Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: select arm64 by default #6439

Merged
merged 7 commits into from
Mar 6, 2024
Merged

fix: select arm64 by default #6439

merged 7 commits into from
Mar 6, 2024

Conversation

rhlshah
Copy link
Contributor

@rhlshah rhlshah commented Mar 4, 2024

Description

Selected ARM64 by default in the dropdown if user is visiting from M1

  1. Added "getArchitecture" utility and embed it on our util that detects the UserOS.
  2. Checked if architecture is ARM if visiting from M1

Validation

nodejs

Related Issues

Fixes #6364

@rhlshah rhlshah requested a review from a team as a code owner March 4, 2024 20:27
@vercel Vercel
Copy link

vercel bot commented Mar 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Mar 6, 2024 11:14am

@rhlshah rhlshah changed the title Fixed Issue #6364 Fixed Issue Select ARM 64 by Default Mar 4, 2024
@rhlshah
Copy link
Contributor Author

rhlshah commented Mar 4, 2024

@trivikr Could you please review my PR?

@trivikr
Copy link
Member

trivikr commented Mar 4, 2024

Could you please review my PR?

I'm not a maintainer of Node.js website, and had created issue while playing with the new redesign.
The PR has notified @nodejs/nodejs-website, they'll be reviewing your code.

@rhlshah rhlshah changed the title Fixed Issue Select ARM 64 by Default fix: select arm64 by default Mar 5, 2024
@rhlshah
Copy link
Contributor Author

rhlshah commented Mar 6, 2024

I have made the changes and have also added the tests. Pleas have a look.

bmuenzenmeyer
bmuenzenmeyer reviewed Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small comments

util/__tests__/getUserBitnessByArchitecture.test.mjs Outdated Show resolved Hide resolved
util/getUserBitnessByArchitecture.ts Outdated Show resolved Hide resolved
rhlshah and others added 2 commits March 5, 2024 21:36
@rhlshah @bmuenzenmeyer
Update util/__tests__/getUserBitnessByArchitecture.test.mjs
27dd8ad 
Co-authored-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>
Signed-off-by: Rahil Shah <45811662+rhlshah@users.noreply.github.com>
@rhlshah @bmuenzenmeyer
Update util/getUserBitnessByArchitecture.ts
e20b89c 
Co-authored-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>
Signed-off-by: Rahil Shah <45811662+rhlshah@users.noreply.github.com>
@ovflowd
Update getUserBitnessByArchitecture.ts
494d8ba 
Signed-off-by: Claudio W <cwunder@gnome.org>
ovflowd
ovflowd approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Awesome first contribution! TYSM!

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Mar 6, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Mar 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2024 •
edited
Loading

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 96 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 96 🟢 100 🟢 92 🔗
/en/about/previous-releases 🟢 100 🟢 95 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 95 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 96 🟢 100 🟢 92 🔗

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2024 •
edited
Loading

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 85%
 80.54% (447/555) 79.55% (144/181) 73.14% (79/108)

Unit Test Report

Tests Skipped Failures Errors Time
90 0 💤 0 ❌ 0 🔥 4.429s ⏱️

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Mar 6, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Mar 6, 2024
@ovflowd ovflowd added this pull request to the merge queue Mar 6, 2024
Merged via the queue into nodejs:main with commit 503d265 Mar 6, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmuenzenmeyer bmuenzenmeyer bmuenzenmeyer left review comments

@AugustinMauroy AugustinMauroy AugustinMauroy left review comments

@ovflowd ovflowd ovflowd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[nit] Select ARM64 by default in the dropdown if user is visiting from M1
5 participants
@rhlshah @trivikr @bmuenzenmeyer @ovflowd @AugustinMauroy