-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nit] Select ARM64 by default in the dropdown if user is visiting from M1 #6364
Comments
The architecture might not matter in the dropdown for macOS, as both binaries link to the same |
Feel free to create a PR or patch to use the right bitness. We use the Because the architecture is ARM and the bitness is 64. So, technically, the result is correct. |
Pretty much an idea for a PR is to introduce the "getArchitecture" utility and embed it on our util that detects the UserOS (https://github.com/nodejs/nodejs.org/blob/main/hooks/react-client/useDetectOS.ts) So you could add an extra field "architecture" that would then be used on our BitnessDropdown (
(Which is actually an architecture + bitness dropdown...) |
I added |
I can take it |
I have fixed the issue and have also created a PR. Please have a look |
* Fixed Issue #6364 * Fix arm64 select by default v2 * Fix arm64 select by default v2 * Update util/__tests__/getUserBitnessByArchitecture.test.mjs Co-authored-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com> Signed-off-by: Rahil Shah <45811662+rhlshah@users.noreply.github.com> * Update util/getUserBitnessByArchitecture.ts Co-authored-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com> Signed-off-by: Rahil Shah <45811662+rhlshah@users.noreply.github.com> * Update getUserBitnessByArchitecture.ts Signed-off-by: Claudio W <cwunder@gnome.org> * chore: fixed lint --------- Signed-off-by: Rahil Shah <45811662+rhlshah@users.noreply.github.com> Signed-off-by: Claudio W <cwunder@gnome.org> Co-authored-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com> Co-authored-by: Claudio W <cwunder@gnome.org>
Enter your suggestions in details:
Is your feature request related to a problem? Please describe.
Not a big issue, but I was browsing new redesigned website from M1 (on ARM architecture) and noticed that X64 was selected in the dropdown by default for prebuilt installer and binaries
https://nodejs-org-git-meta-remove-legacy-website-code-openjs.vercel.app/en/download
Prebuilt Installer
Prebuilt Binaries
Describe the solution you'd like
Select the architecture of visitors machine, if it's detectable from JavaScript.
For example, it's detectable from experimental await navigator.userAgentData.getHighEntropyValues(['architecture']) API call.
The website uses the experimental API to get
bitness
nodejs.org/util/getBitness.ts
Lines 8 to 10 in 04fd007
Describe alternatives you've considered
N/A, as the user can explicitly select
ARM
option from the dropdown even ifX64
is selected by default.The text was updated successfully, but these errors were encountered: