Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PT-BR] openssl-and-low-severity-fixes-sep-2019 #2732

Merged
merged 7 commits into from
Nov 8, 2019
Merged

[PT-BR] openssl-and-low-severity-fixes-sep-2019 #2732

merged 7 commits into from
Nov 8, 2019

Conversation

WeslleyNasRocha
Copy link
Contributor

@WeslleyNasRocha WeslleyNasRocha commented Oct 29, 2019

@nodejs/nodejs-pt por favor façam a revisão aqui

nodejs/nodejs-pt#80

@nschonni
Copy link
Member

Ping @nodejs/nodejs-pt

Copy link
Contributor

@maugravena maugravena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some suggestions for improvements, thanks for your translation! @WeslleyNasRocha

---
date: 2019-09-05T15:34:35.000Z
category: vulnerability
title: Lançamento de segurança OpenSSL talvez necessite um lançamento de segurança do Node.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: Lançamento de segurança OpenSSL talvez necessite um lançamento de segurança do Node.js
title: Atualizações de segurança do OpenSSL talvez necessite uma atualização de segurança do Node.js

Tentando encontrar uma tradução melhor para "releases", caso você ache a sugestão interessante.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think releases should be kept as is. No translation needed, it is a tech word

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Atualizações de segurança" sounds way better than "Releases de segurança" and "Lançamento de segurança".

As is now, it doesn't sound natural: "Release de segurança OpenSSL talvez necessite um lançamento de segurança do Node.js"

I'd rather say something like: "Atualizações de segurança do OpenSSL podem necessitar de atualizações de segurança do Node.js também"

By the way, original in English is: "OpenSSL security releases may require Node.js security releases".

Copy link
Member

@khaosdoctor khaosdoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @maugravena in the changes as well

Co-Authored-By: Mauricio Gravena <maugravena@gmail.com>
Copy link
Member

@khaosdoctor khaosdoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change release to make it as is

@WeslleyNasRocha
Copy link
Contributor Author

Applied the requested changes

Copy link
Member

@khaosdoctor khaosdoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @Trott @nschonni @MaledongGit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants