v6.2.2 proposal #7323
v6.2.2 proposal #7323
Conversation
evanlucas
added
the
meta
|
changelog LGTM if ci + citgm are green |
Perhaps a touch too long and dramatic. I'd shorten it to e.g. "req.read(0) could stall incoming connections under certain conditions." Or maybe "req.read(0) could cause incoming connections to stall and time out under certain conditions", to stress that it's a bug but not really a denial-of-service. |
|
thanks @bnoordhuis I'll update it. Does the other |
evanlucas
force-pushed
the
v6.2.2-proposal
branch
from
2c50f3f
to
54a3ac2
Compare
|
The other one is not too bad. It could be shorter but it's acceptable as-is, IMO. |
evanlucas
force-pushed
the
v6.2.2-proposal
branch
from
54a3ac2
to
2701c62
Compare
|
Could you use code ticks for |
evanlucas
force-pushed
the
v6.2.2-proposal
branch
from
2701c62
to
8c43437
Compare
Notable changes:
* **http**:
- req.read(0) could cause incoming connections to stall and time out
under certain conditions. (Fedor Indutny) [#7211](#7211)
- When freeing the socket to be reused in keep-alive Agent wait for
both prefinish and end events. Otherwise the next request may be
written before the previous one has finished sending the body, leading
to a parser errors. (Fedor Indutny) [#7149](#7149)
* **npm**: upgrade npm to 3.9.5 (Kat Marchán) [#7139](#7139)
#7323
|
@evanlucas Hold up, you need to include #7284 or we'll be making a breaking change |
|
@Fishrock123 that depends on #7111 right? If so, it shouldn't be necessary to include because that pr was semver-minor |
|
I've changed #7111 to semver-major, see #7111 (comment). |
|
Ok, sounds good. |
Notable changes:
* **http**:
- req.read(0) could cause incoming connections to stall and time out
under certain conditions. (Fedor Indutny) [#7211](#7211)
- When freeing the socket to be reused in keep-alive Agent wait for
both prefinish and end events. Otherwise the next request may be
written before the previous one has finished sending the body, leading
to a parser errors. (Fedor Indutny) [#7149](#7149)
* **npm**: upgrade npm to 3.9.5 (Kat Marchán) [#7139](#7139)
#7323
evanlucas
force-pushed
the
v6.2.2-proposal
branch
from
8c43437
to
091abb3
Compare
PR-URL: #7323
Notable changes:
* **http**:
- req.read(0) could cause incoming connections to stall and time out
under certain conditions. (Fedor Indutny) [#7211](#7211)
- When freeing the socket to be reused in keep-alive Agent wait for
both prefinish and end events. Otherwise the next request may be
written before the previous one has finished sending the body, leading
to a parser errors. (Fedor Indutny) [#7149](#7149)
* **npm**: upgrade npm to 3.9.5 (Kat Marchán) [#7139](#7139)
PR-URL: #7323
Notable changes:
req.read(0)could cause incoming connections to stall and time out under certain conditions. (Fedor Indutny) #7211both prefinish and end events. Otherwise the next request may be
written before the previous one has finished sending the body, leading
to a parser errors. (Fedor Indutny) #7149
Commits
d71ede8113] - benchmark: don't convert arguments to numbers (Brian White) #657032f76983e2] - benchmark: increase http token check iterations (Brian White) #657023a495a9a9] - benchmark: add benchmark for url.format() (Rich Trott) #725027ed7fc56c] - benchmark: fix child-process-exec-stdout on win (Bartosz Sosnowski) #71785e5af8b4bb] - benchmark: fix child-process-read on Windows (Bartosz Sosnowski) #6971d24e4095bf] - benchmark: add benchmark for Buffer.concat (Anna Henningsen) #7054666b6f9302] - build: add REPLACEME tag for version info in docs (Ben Noordhuis) #68646d3d2d1ae4] - cluster: don't send messages if no IPC channel (Santiago Gimeno) #7132068718c91c] - debugger: remove obsolete setTimeout (Rich Trott) #71542961f06f6f] - debugger: fix --debug-brk interaction with -e (Rich Trott) #7089701e699d4f] - deps: upgrade npm to 3.9.5 (Kat Marchán) #71391095ae1ac5] - doc: Add CII Best Practices badge to README.md (David A. Wheeler) #68190198987b0d] - doc: add internal link in GOVERNANCE.md (Rich Trott) #72798e14f761bb] - doc: useBuffer.byteLengthfor Content-Length (kimown) #72745d03bdd94f] - doc: add information for IncomingMessage.destroy() (Rich Trott) #7237a113734099] - doc: general improvements to path.md copy (James M Snell) #7122b5e44df9a3] - doc: make pull request template more concise (Rich Trott) #723940a5974a0e] - doc:url.format()parameter may be a string (Rich Trott) #7235a7d813915e] - doc: clarify use of0port value (Rich Trott) #72060fc8012b65] - doc: remove cluster.setupMaster() myth (cjihrig) #717970167fd1d4] - doc: fix IRC link (Ilkka Myller) #72104f2215fd98] - doc: fix minor nit introduced in readline.md (James M Snell) #7198d31f728e09] - doc: clarify rl.question callback args (James M Snell) #702270f2f357be] - doc: general improvements to readline.md copy (James M Snell) #7022c2aba5ba27] - doc: consolidate test/lint text in GH PR template (Rich Trott) #7155712120112f] - doc: use consistent typography in streams.md (Rich Trott) #6986e2f6f8061b] - doc: general improvements to process.md copy (James M Snell) #702984ea6fc57c] - doc: general improvements to repl.md copy (James M Snell) #7002bfb7e3cc6e] - doc: addadded:information for readline (Julian Duque) #6996632b411cd0] - doc: improved syntax consistency in console.md (Jonathan Montane) #7062826bd99486] - doc: specify how to link issues in commit log (Luigi Pinca) #7161865644a604] - doc: general improvements to querystring.md copy (James M Snell) #7023dd4c607267] - doc: fix header depth of util.isSymbol (James M Snell) #71385086e5f3ee] - doc: general improvements to stream.md copy (James M Snell) #694775d6875034] - doc: update licenses (Myles Borins) #7121dc8cb93c4f] - doc: addadded:information for dns (Julian Duque) #7021a7c85e6fd5] - doc: addadded:information for path (Julian Duque) #6985026bf17378] - doc: addaddedinformation for net (Italo A. Casas) #7038d4a2c82f5f] - doc: general improvements to punycode.md copy (James M Snell) #702551d295efe6] - doc: add links to platform specific mechanisms (Michael Dawson) #70711600966f59] - fs: execute mkdtemp's callback with no context (Sakthipriyan Vairamani) #7068ad1045c829] - http: fix no dumping aftermaybeReadMore(Fedor Indutny) #72112a462ba1e2] - http: optimize checkInvalidHeaderChar() (Brian White) #65704a63be031f] - http: optimize checkIsHttpToken() (Brian White) #657040e49dee82] - http: wait for both prefinish/end to keepalive (Fedor Indutny) #7149e8c91e7557] - repl: refine handling of illegal tokens (Rich Trott) #7104cf0928ccb7] - src: clean up string_search (Brian White) #7174b0225e5926] - stream: ensure awaitDrain is increased once (David Halls) #72929c6b69ec1b] - stream: reset awaitDrain after manual .resume() (Anna Henningsen) #7160caa6718a01] - test: fix test-net-* error code check for getaddrinfo(3) (Natanael Copa) #5099535c8dd554] - test: add more http token/value checking tests (Brian White) #6570257f4e6202] - test: add note about duration_ms in TAP reporter (Rod Vagg) #7216798a737f45] - _Revert_ "test: change duration_ms to duration" (Rod Vagg) #721672e4e43b91] - test: rebuild add-ons when their sources change (Ben Noordhuis) #7262eded11705b] - test: use random ports where possible (Brian White) #7045d54c7c19a6] - test: fix spawn on windows (Brian White) #7049e873063a3c] - test: enable test-debug-brk-no-arg (Rich Trott) #7143d6091c8194] - test: use common.fixturesDir almost everywhere (Bryan English) #6997e8b1456d8b] - test: change duration_ms to duration (Gibson Fahnestock) #71336ce26c8c8b] - test: add test for uid/gid setting in spawn (Rich Trott) #708440604b54d4] - test: remove disabled eio race test (Rich Trott) #70839545c41cba] - tools: fix license builder to work with icu-small (Myles Borins) #71196562c9fc75] - tools,doc: add example usage for REPLACEME tag (Anna Henningsen) #6864