Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add links to platform specific mechanisms #7071

Closed
wants to merge 2 commits into from

Conversation

mhdawson
Copy link
Member

@mhdawson mhdawson commented May 30, 2016

Checklist
  • tests and code linting passes
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

fs

Description of change

As requested in earlier PR adding detail for Aix, add link
for each of the platform specific technologies used for
file system watching.

Note I did not find a good link for "event ports" on Solaris. Hoping @davepacheco might be able to suggest one.

As requested in earlier PR adding detail for Aix, add link
for each of the platform specific technologies used for
file system watching.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 30, 2016
@mhdawson
Copy link
Member Author

@jasnell as requested in previous PR.

@mhdawson mhdawson self-assigned this May 30, 2016
@eljefedelrodeodeljefe
Copy link
Contributor

Can you add the links in the footer instead? An example would be https://github.com/nodejs/node/pull/7071/files#diff-acabf706a8aa070a8796e3573f7e4678R1561

Otherwise LGTM

@rvagg
Copy link
Member

rvagg commented May 31, 2016

nice work, lgtm, that apple url tho ..

@mscdex
Copy link
Contributor

mscdex commented May 31, 2016

@rvagg Too short?

@mscdex mscdex added the fs Issues and PRs related to the fs subsystem / file system. label May 31, 2016
@rvagg
Copy link
Member

rvagg commented May 31, 2016

@mscdex yeah, that, obviously, I was also wondering how stable the named anchors are #//apple_ref/doc/uid/TP40005289-CH1-SW1, perhaps Apple are good with this stuff or perhaps we'll be accepting pull requests soon when they mess with stuff.

@davepacheco
Copy link
Contributor

I'd suggest using http://illumos.org/man/port_create as the link for event ports.

@yorkie
Copy link
Contributor

yorkie commented May 31, 2016

How about moving these links to the bottom of this documentation to define, that might be readable to maintainers or source reader :-)

@mhdawson
Copy link
Member Author

@eljefedelrodeodeljefe did you get the wrong link for the example ?

@mhdawson
Copy link
Member Author

Figured it out. Good to learn how to put links at the bottom. Pushed update.

@yorkie
Copy link
Contributor

yorkie commented May 31, 2016

lgtm :-)

@eljefedelrodeodeljefe
Copy link
Contributor

👍

mhdawson added a commit that referenced this pull request Jun 2, 2016
As requested in earlier PR adding detail for Aix, add link
for each of the platform specific technologies used for
file system watching.

PR-URL: #7071
Reviewed-By: Robert Jefe Lindstädt <robert.lindstaedt@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
@mhdawson
Copy link
Member Author

mhdawson commented Jun 2, 2016

landed as 138c7af

@mhdawson mhdawson closed this Jun 2, 2016
evanlucas pushed a commit that referenced this pull request Jun 15, 2016
As requested in earlier PR adding detail for Aix, add link
for each of the platform specific technologies used for
file system watching.

PR-URL: #7071
Reviewed-By: Robert Jefe Lindstädt <robert.lindstaedt@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
@evanlucas evanlucas mentioned this pull request Jun 16, 2016
@mhdawson mhdawson deleted the fsdoc2 branch March 15, 2017 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants