test: update test to support OpenSSL32

[mhdawson]

Refs: #53382

This test fails on OpenSSL32 because it complains the key being
used is too short.

It seems to have been missed when the test suite was udpated to have
a Makefile to generate key material as the keys are hard coded in the
test as opposed to being read in from the fixtures/key directory.

Update the test to use keys/certs from the fixtures directory and
to remove newlines at the end of the key and cert to retain the
inteded test.

Signed-off-by: Michael Dawson midawson@redhat.com

[lpinca]

Both test/fixtures/keys/rsa_private.pem and test/fixtures/keys/rsa_cert.crt have trailing newlines.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.06%. Comparing base (c1afd2c) to head (a2373be).
Report is 32 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #54968      +/-   ##
==========================================
- Coverage   88.06%   88.06%   -0.01%     
==========================================
  Files         652      652              
  Lines      183545   183545              
  Branches    35866    35865       -1     
==========================================
- Hits       161639   161637       -2     
- Misses      15150    15156       +6     
+ Partials     6756     6752       -4     

see 27 files with indirect coverage changes

[mhdawson]

@lpinca how do you see that? I'm looking at the files on disk (linux) and I don't see any newlines. I also don't see anything that would indicate that there are newlines in the UI either -> https://github.com/nodejs/node/blob/main/test/fixtures/keys/rsa_private.pem, but maybe I have a setting that would hide that?

[richardlau]

$ od -h test/fixtures/keys/rsa_private.pem
0000000 2d2d 2d2d 422d 4745 4e49 5220 4153 5020
...
0003200 5649 5441 2045 454b 2d59 2d2d 2d2d 000a
0003217
$

[mhdawson]

ok. my bad I may have been looking for the carriage return instea of the new line. Anyway I'll update to keep the test with larger keys.

[mhdawson]

@lpinca , @richardlau fixed. Thanks for catching my mistake :)

[mhdawson]

Run on OpenSSL32 - https://ci.nodejs.org/job/richardlau-node-test-commit-linux-containered/52/ (PASSED)

[lpinca]

let i = 0;
while (key[key.length - 1 - i] === 0x0a) i++;
if (i !== 0) key = key.slice(0, key.length - i);

There might be multiple trailing newlines.

[mhdawson]

@lpinca added that for both key and cert.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/62499/

[richardlau]

Non-blocking suggestion:
Perhaps assert that there is no newline at the end of the array in case someone modifies the test later?

[mhdawson]

@richardlau since I have a green CI I'd like to go ahead and land, but will add that in a follow on PR.

[nodejs-github-bot]

Landed in f8b7a17