-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: update test-assert to use node:test #54585
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Commit Queue failed- Loading data for nodejs/node/pull/54585 ✔ Done loading data for nodejs/node/pull/54585 ----------------------------------- PR info ------------------------------------ Title test: update test-assert to use node:test (#54585) Author James M Snell <jasnell@gmail.com> (@jasnell) Branch jasnell:use-test-for-test-assert -> nodejs:main Labels test, author ready, needs-ci Commits 3 - test: update test-assert to use node:test - test: update test-assert-typedarray-deepequal to use node:test - test: update multiple assert tests to use node:test Committers 1 - James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/54585 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54585 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 27 Aug 2024 05:10:26 GMT ✔ Approvals: 2 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/54585#pullrequestreview-2263248081 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/54585#pullrequestreview-2266164379 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-08-29T05:55:07Z: https://ci.nodejs.org/job/node-test-pull-request/61636/ - Querying data for job/node-test-pull-request/61636/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 54585 From https://github.com/nodejs/node * branch refs/pull/54585/merge -> FETCH_HEAD ✔ Fetched commits as beabcec41ca4..23adad3410af -------------------------------------------------------------------------------- [main 4aeb86ca38] test: update test-assert to use node:test Author: James M Snell <jasnell@gmail.com> Date: Mon Aug 26 21:05:07 2024 -0700 2 files changed, 912 insertions(+), 930 deletions(-) delete mode 100644 test/parallel/test-assert-strict-exists.js [main cd0b7c648d] test: update test-assert-typedarray-deepequal to use node:test Author: James M Snell <jasnell@gmail.com> Date: Mon Aug 26 21:15:20 2024 -0700 1 file changed, 87 insertions(+), 74 deletions(-) [main 6b4ce531e1] test: update multiple assert tests to use node:test Author: James M Snell <jasnell@gmail.com> Date: Mon Aug 26 22:08:07 2024 -0700 6 files changed, 1000 insertions(+), 973 deletions(-) ✔ Patches applied There are 3 commits in the PR. Attempting autorebase. Rebasing (2/6)https://github.com/nodejs/node/actions/runs/10619066403 |
PR-URL: #54585 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #54585 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #54585 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Landed in fc02b88...9cbef48 |
PR-URL: #54585 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #54585 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #54585 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #54585 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #54585 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #54585 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #54585 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #54585 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #54585 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: nodejs#54585 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: nodejs#54585 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: nodejs#54585 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Unfortunately, this commit didn't land cleanly on v22.x-staging. I tried to fix the conflicts but tests started to fail. Can you create a manual backport? |
No description provided.