Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix embedding test for Windows #53659

Merged
merged 3 commits into from
Aug 27, 2024
Merged

test: fix embedding test for Windows #53659

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a6f88be
test: fix embedding test for Windows
vmoroz Jun 30, 2024
475e870
normalize the check string EOL in checkOutput
vmoroz Aug 10, 2024
d8314e9
rollback changes to test/common/child_process.js
vmoroz Aug 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions test/embedding/test-embedding.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ const {
} = require('../common/child_process');
const path = require('path');
const fs = require('fs');
const os = require('os');

tmpdir.refresh();
common.allowGlobals(global.require);
Expand Down Expand Up @@ -152,12 +153,6 @@ for (const extraSnapshotArgs of [
{ cwd: tmpdir.path });
}

// Skipping rest of the test on Windows because it fails in the CI
// TODO(StefanStojanovic): Reenable rest of the test after fixing it
if (common.isWindows) {
return;
}

// Guarantee NODE_REPL_EXTERNAL_MODULE won't bypass kDisableNodeOptionsEnv
{
spawnSyncAndExit(
Expand All @@ -172,6 +167,6 @@ if (common.isWindows) {
{
status: 9,
signal: null,
stderr: `${binary}: NODE_REPL_EXTERNAL_MODULE can't be used with kDisableNodeOptionsEnv\n`,
stderr: `${binary}: NODE_REPL_EXTERNAL_MODULE can't be used with kDisableNodeOptionsEnv${os.EOL}`,
});
}
Loading