-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix embedding test for Windows #53659
test: fix embedding test for Windows #53659
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM although I think it's fine to simply use a looser regexp in test-embedding.js and just match
stderr: /NODE_REPL_EXTERNAL_MODULE can't be used with kDisableNodeOptionsEnv/
Thanks! I had considered it initially, but decided on the |
8632afa
to
e747896
Compare
Consistent failure on Windows:
|
@aduh95 , yes, the CI failure is caused by this PR. The PR normalizes the output to use only the |
e747896
to
475e870
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #53659 +/- ##
=======================================
Coverage 87.09% 87.09%
=======================================
Files 647 647
Lines 181817 181843 +26
Branches 34883 34887 +4
=======================================
+ Hits 158348 158382 +34
+ Misses 16764 16763 -1
+ Partials 6705 6698 -7 |
None of the failures seems to be related to this PR. |
@vmoroz I noticed that you may pushed "rebuild" button on jenkins. An alternative to "rebuild" is "resume" which does not re-run successful sub-tasks. This can greatly help with the churn of flakiness that are unrelated to this PR. |
Landed in 0b3ae01 |
PR-URL: #53659 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #53659 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR #52905 had added a new test case for embedding test which was failing for Windows.
The reason was that the expected error message has the Posix-specific line ending
\n
while on Windows the output string contains\r\n
:PR #52905 temporary disabled this new test case for Windows.
This PR removes the temporary test disablement for Windows and implements the fix by replacing
\n
in the test withos.EOL
. After this change the embedding test is passing for Windows.