meta: add ethan.arrowood@vercel.com to mailmap #50491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
meta
H4ad
approved these changes
Oct 31, 2023
|
Fast-track has been requested by @H4ad. Please 👍 to approve. |
tniessen
approved these changes
Oct 31, 2023
|
Even for something like this I should wait for a completely green CI, right? |
lpinca
approved these changes
Oct 31, 2023
lpinca
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/50491 ✔ Done loading data for nodejs/node/pull/50491 ----------------------------------- PR info ------------------------------------ Title meta: add ethan.arrowood@vercel.com to mailmap (#50491) Author Ethan Arrowood (@Ethan-Arrowood) Branch Ethan-Arrowood:fix-ethan-arrowood-mailmap -> nodejs:main Labels meta, fast-track Commits 1 - meta: add ethan.arrowood@vercel.com to mailmap Committers 1 - Ethan Arrowood PR-URL: https://github.com/nodejs/node/pull/50491 Fixes: https://github.com/nodejs/node/pull/50470 Reviewed-By: Vinícius Lourenço Claro Cardoso Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50491 Fixes: https://github.com/nodejs/node/pull/50470 Reviewed-By: Vinícius Lourenço Claro Cardoso Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 31 Oct 2023 15:31:25 GMT ✔ Approvals: 3 ✔ - Vinícius Lourenço Claro Cardoso (@H4ad): https://github.com/nodejs/node/pull/50491#pullrequestreview-1706851198 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/50491#pullrequestreview-1706893547 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/50491#pullrequestreview-1707078417 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 50491 From https://github.com/nodejs/node * branch refs/pull/50491/merge -> FETCH_HEAD ✔ Fetched commits as 0899bee48c64..bae01607c2fe -------------------------------------------------------------------------------- [main 364b054940] meta: add ethan.arrowood@vercel.com to mailmap Author: Ethan Arrowood Date: Tue Oct 31 09:30:45 2023 -0600 1 file changed, 3 insertions(+), 2 deletions(-) ✔ Patches applied -------------------------------------------------------------------------------- --------------------------------- New Message ---------------------------------- meta: add ethan.arrowood@vercel.com to mailmaphttps://github.com/nodejs/node/actions/runs/6711475875 |
richardlau
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 2a49973 |
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#50491 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
anonrig
pushed a commit
to anonrig/node
that referenced
this pull request
Nov 9, 2023
PR-URL: nodejs#50491 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
PR-URL: #50491 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 14, 2023
PR-URL: #50491 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 11, 2023
PR-URL: #50491 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #50470 (comment)