Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: move one or more collaborators to emeritus #50470

Closed
wants to merge 1 commit into from

Conversation

nodejs-github-bot
Copy link
Collaborator

This PR was generated by tools/find-inactive-collaborators.yml.

@nodejs/tsc Please follow up with the offboarding tasks.

@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. doc Issues and PRs related to the documentations. labels Oct 30, 2023
Comment on lines +536 to +537
* [Ethan-Arrowood](https://github.com/Ethan-Arrowood) -
**Ethan Arrowood** <<ethan@arrowood.dev>> (he/him)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well there’s clearly a bug in this script. It needs to check that someone has been a collaborator for at least the length of time that it checks for inactivity.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that this email address hasn't been used recently. It should be fixed by an update to https://github.com/nodejs/node/blob/main/.mailmap

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ethan-Arrowood can you please open a PR to map the different email addresses you use to commit to the one you use in the collaborator list please?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw I know Ethan is on vacation right now and might not be paying attention to GitHub pings 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack! Online tomorrow and will get this fixed up asap. Will also make sure to stick to my personal email for all future commits

@aduh95 aduh95 deleted the actions/inactive-collaborators branch October 31, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants