-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: remove Python pip --no-user option (#47338) #47372
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
Issues and PRs related to build files or the CI.
needs-ci
PRs that need a full CI run.
labels
Apr 2, 2023
Trott
added
fast-track
PRs that do not need to wait for 48 hours to land.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Apr 2, 2023
Fast-track has been requested by @Trott. Please 👍 to approve. |
This is a re-landing for #47338. |
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Apr 2, 2023
debadree25
approved these changes
Apr 2, 2023
would the commit title need to be renamed? it still has the PR url |
Oh, yeah, I should remove that. I'll force push and restart CI. Thanks. |
MoLow
approved these changes
Apr 2, 2023
cjihrig
approved these changes
Apr 2, 2023
richardlau
approved these changes
Apr 2, 2023
Python pip no longer has a `--no-user` option. Refs: nodejs/build#3273 Refs: https://github.com/pypa/pip/pull/5116/files PR-URL: nodejs#47372 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Landed in cce5a8c |
This was referenced Apr 3, 2023
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 5, 2023
Python pip no longer has a `--no-user` option. Refs: nodejs/build#3273 Refs: https://github.com/pypa/pip/pull/5116/files PR-URL: #47372 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 5, 2023
Python pip no longer has a `--no-user` option. Refs: nodejs/build#3273 Refs: https://github.com/pypa/pip/pull/5116/files PR-URL: #47372 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 6, 2023
Python pip no longer has a `--no-user` option. Refs: nodejs/build#3273 Refs: https://github.com/pypa/pip/pull/5116/files PR-URL: #47372 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 7, 2023
Python pip no longer has a `--no-user` option. Refs: nodejs/build#3273 Refs: https://github.com/pypa/pip/pull/5116/files PR-URL: #47372 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 8, 2023
Python pip no longer has a `--no-user` option. Refs: nodejs/build#3273 Refs: https://github.com/pypa/pip/pull/5116/files PR-URL: #47372 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
Python pip no longer has a `--no-user` option. Refs: nodejs/build#3273 Refs: https://github.com/pypa/pip/pull/5116/files PR-URL: #47372 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
Python pip no longer has a `--no-user` option. Refs: nodejs/build#3273 Refs: https://github.com/pypa/pip/pull/5116/files PR-URL: nodejs#47372 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
build
Issues and PRs related to build files or the CI.
fast-track
PRs that do not need to wait for 48 hours to land.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python pip no longer has a --no-user option.
Refs: nodejs/build#3273
Refs: https://github.com/pypa/pip/pull/5116/files