-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Python pip no longer has a --no-user option #47338
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Python pip no longer has a --no-user option. Refs: nodejs/build#3273 Refs: https://github.com/pypa/pip/pull/5116/files
2948567
to
d4653e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Are we OK with the four failing tests?
|
I'm guessing those are probably flakes. They don't look related. |
A commit referencing this Pull Request was pushed to by @cclauss without the expected commit metadata added to its message. |
This landed without the correct metadata, without the required wait time (at the time of writing, this PR needs to wait 5 more hours to land), and without a passing CI (although I'm unsure Jenkins CI is a requirement for this change). I've force-pushed to remove the commit, please open a new PR and use the
commit-queue
|
Python pip no longer has a --no-user option. Refs: nodejs/build#3273 Refs: https://github.com/pypa/pip/pull/5116/files
I re-opened this as #47372 (maintaining commit authorship--I think the commit-queue bot sometimes does funny things with it, though, so I might recommend landing manually). I will start CI there and request fast-tracking. |
I sense that the commit message linter did not like that I capitalized the word Python. In the Python community, we say that |
@cclauss The commit message check that was triggered when you pushed d8e3fca did not fail because of the commit message title. It failed (and sent a warning to the
This PR was also merged in violation of other rules as @aduh95 described above. You can find the collaborator guide here. |
As discussed in nodejs/build#3273
A
--no-user
option was added topip
5 years ago but was later removed.