Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Python pip no longer has a --no-user option #47338

Merged
merged 1 commit into from
Apr 2, 2023

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Mar 31, 2023

As discussed in nodejs/build#3273

A --no-user option was added to pip 5 years ago but was later removed.

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Mar 31, 2023
@cclauss cclauss added python PRs and issues that require attention from people who are familiar with Python. and removed needs-ci PRs that need a full CI run. labels Mar 31, 2023
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 31, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 31, 2023
@nodejs-github-bot

This comment was marked as outdated.

@Trott Trott force-pushed the remove_pip_--no-user branch from 2948567 to d4653e5 Compare March 31, 2023 13:54
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cclauss
Copy link
Contributor Author

cclauss commented Mar 31, 2023

Are we OK with the four failing tests?

  • node-test-commit
  • node-test-commit-plinux-rhel8-ppc64le
  • node-test-linux-linked-shared
  • node-test-linux-linked-withoutintl

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 31, 2023
@Qard
Copy link
Member

Qard commented Mar 31, 2023

I'm guessing those are probably flakes. They don't look related.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 31, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@cclauss cclauss merged commit d8e3fca into main Apr 2, 2023
@cclauss cclauss deleted the remove_pip_--no-user branch April 2, 2023 05:17
@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2023

A commit referencing this Pull Request was pushed to by @cclauss without the expected commit metadata added to its message.

@aduh95
Copy link
Contributor

aduh95 commented Apr 2, 2023

This landed without the correct metadata, without the required wait time (at the time of writing, this PR needs to wait 5 more hours to land), and without a passing CI (although I'm unsure Jenkins CI is a requirement for this change). I've force-pushed to remove the commit, please open a new PR and use the commit-queue Add this label to land a pull request using GitHub Actions. label instead of the "Squash and merge" button.

Trott pushed a commit to Trott/io.js that referenced this pull request Apr 2, 2023
@Trott
Copy link
Member

Trott commented Apr 2, 2023

I re-opened this as #47372 (maintaining commit authorship--I think the commit-queue bot sometimes does funny things with it, though, so I might recommend landing manually). I will start CI there and request fast-tracking.

@cclauss
Copy link
Contributor Author

cclauss commented Apr 2, 2023

I sense that the commit message linter did not like that I capitalized the word Python.

In the Python community, we say that python is a snake and Python is a programming language.

@tniessen
Copy link
Member

tniessen commented Apr 2, 2023

I sense that the commit message linter did not like that I capitalized the word Python.

@cclauss The commit message check that was triggered when you pushed d8e3fca did not fail because of the commit message title. It failed (and sent a warning to the #nodejs-core Slack channel) because you pushed a commit to the main branch that was missing mandatory metadata.

✖  d8e3fca4a521d4ed6def274df75869284785b713
   ✔  0:0      no Co-authored-by metadata                co-authored-by-is-trailer
   ✔  0:0      skipping fixes-url                        fixes-url
   ✔  0:0      blank line after title                    line-after-title
   ✔  0:0      line-lengths are valid                    line-length
   ✔  0:0      metadata is at end of message             metadata-end
   ✖  0:0      Commit must have a PR-URL.                pr-url
   ✖  0:0      Commit must have at least 1 reviewer.     reviewers
   ✔  0:0      valid subsystems                          subsystem
   ✔  0:0      Title is formatted correctly.             title-format
   ✔  0:0      Title is <= 50 columns.                   title-length

This PR was also merged in violation of other rules as @aduh95 described above. You can find the collaborator guide here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. python PRs and issues that require attention from people who are familiar with Python.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants