deps: update V8 to 10.1 #42657

targos · 2022-04-08T15:19:34Z

If Windows 32 bits CI still fails, I will open another PR to temporarily make that platform experimental, as discussed in this week's TSC meeting.
Edit: failure confirmed: https://ci.nodejs.org/job/node-compile-windows/44578/nodes=win-vs2019-x86/console

nodejs-github-bot · 2022-04-08T15:19:40Z

Review requested:

@nodejs/gyp
@nodejs/v8-update

nodejs-github-bot · 2022-04-08T15:20:42Z

CI: https://ci.nodejs.org/job/node-test-pull-request/43398/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4619/

targos · 2022-04-08T15:21:10Z

@nodejs/tsc

aduh95 · 2022-04-08T15:39:41Z

It looks like the 32-bit Windows build has failed: https://ci.nodejs.org/job/node-compile-windows/44578/nodes=win-vs2019-x86/console

targos · 2022-04-09T08:12:55Z

~~Now I don't understand why test-repl-mode fails everywhere with 10.1. It didn't last week...~~
I'm wrong. It failed with 10.1 too: https://ci.nodejs.org/job/node-test-pull-request/43341/

targos · 2022-04-09T09:07:25Z

If we look at canary, it failed once on March 25 and was fixed on March 26. Checking the commits that landed on V8 in between...

targos · 2022-04-09T09:11:19Z

Added a cherry-pick of v8/v8@a2cae21

nodejs-github-bot · 2022-04-09T09:12:21Z

CI: https://ci.nodejs.org/job/node-test-pull-request/43404/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4620/

targos · 2022-04-09T13:05:33Z

@nodejs/build assuming #42666 lands, how do we handle x86 Windows in CI?

richardlau · 2022-04-10T23:24:12Z

@nodejs/build assuming #42666 lands, how do we handle x86 Windows in CI?

Opened nodejs/build#2921 to not run the Windows x86 builds for Node.js 18 for now.

joyeecheung · 2022-04-12T09:04:21Z

FYI https://chromium-review.googlesource.com/c/v8/v8/+/3575468 has landed and it should fix the near heap limit callback issue without a fix in Node.js (I ran a CI with it before and the test passed https://ci.nodejs.org/job/node-test-commit/52817/)

Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 10.1. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md

Original commit message: [testrunner] delete ancient junit compatible format support Testrunner has ancient support for JUnit compatible XML output. This CL removes this old feature. R=mstarzinger@chromium.org,jgruber@chromium.org,jkummerow@chromium.org CC=machenbach@chromium.org Bug: v8:8728 Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0 Reviewed-on: https://chromium-review.googlesource.com/c/1430065 Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#59045} Refs: v8/v8@bd019bd PR-URL: nodejs#32116 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

This should be semver-patch since actual invocation is version conditional. PR-URL: nodejs#32116 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: nodejs#35415 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> deps: patch for v8 on windows PR-URL: nodejs#40010 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> deps: patch v8 for vs2019 in std17 PR-URL: nodejs#40060 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> deps: workaround debug link error on Windows PR-URL: nodejs#38807 Refs: nodejs#38788 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ash Cripps <acripps@redhat.com>

`handler-outside-simulator.cc` uses inline assembly, which is not supported by MSVC. PR-URL: nodejs#40488 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

We are not ready to migrate yet. Refs: nodejs/node-v8#214 PR-URL: nodejs#40907 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: #42375 PR-URL: #42657 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs/node#42375 PR-URL: nodejs/node#42657 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

* chore: update to Node.js v18 * child_process: improve argument validation nodejs/node#41305 * bootstrap: support configure-time user-land snapshot nodejs/node#42466 * chore: update GN patch * src: disambiguate terms used to refer to builtins and addons nodejs/node#44135 * src: use a typed array internally for process._exiting nodejs/node#43883 * chore: lib/internal/bootstrap -> lib/internal/process * src: disambiguate terms used to refer to builtins and addons nodejs/node#44135 * chore: remove redudant browserGlobals patch * chore: update BoringSSL patch * src: allow embedder-provided PageAllocator in NodePlatform nodejs/node#38362 * chore: fixup Node.js crypto tests - nodejs/node#44171 - nodejs/node#41600 * lib: add Promise methods to avoid-prototype-pollution lint rule nodejs/node#43849 * deps: update V8 to 10.1 nodejs/node#42657 * src: add kNoBrowserGlobals flag for Environment nodejs/node#40532 * chore: consolidate asar initialization patches * deps: update V8 to 10.1 nodejs/node#42657 * deps: update V8 to 9.8 nodejs/node#41610 * src,crypto: remove AllocatedBuffers from crypto_spkac nodejs/node#40752 * build: enable V8's shared read-only heap nodejs/node#42809 * src: fix ssize_t error from nghttp2.h nodejs/node#44393 * chore: fixup ESM patch * chore: fixup patch indices * src: merge NativeModuleEnv into NativeModuleLoader nodejs/node#43824 * [API] Pass OOMDetails to OOMErrorCallback https://chromium-review.googlesource.com/c/v8/v8/+/3647827 * src: iwyu in cleanup_queue.cc * src: return Maybe from a couple of functions nodejs/node#39603 * src: clean up embedder API nodejs/node#35897 * src: refactor DH groups to delete crypto_groups.h nodejs/node#43896 * deps,src: use SIMD for normal base64 encoding nodejs/node#39775 * chore: remove deleted source file * chore: update patches * chore: remove deleted source file * lib: add fetch nodejs/node#41749 * chore: remove nonexistent node specs * test: split report OOM tests nodejs/node#44389 * src: trace fs async api nodejs/node#44057 * http: trace http request / response nodejs/node#44102 * test: split test-crypto-dh.js nodejs/node#40451 * crypto: introduce X509Certificate API nodejs/node#36804 * src: split property helpers from node::Environment nodejs/node#44056 * nodejs/node#38905 bootstrap: implement run-time user-land snapshots via --build-snapshot and --snapshot-blob * lib,src: implement WebAssembly Web API nodejs/node#42701 * fixup! deps,src: use SIMD for normal base64 encoding * fixup! src: refactor DH groups to delete crypto_groups.h * chore: fixup base64 GN file * fix: check that node::InitializeContext() returns true * chore: delete _noBrowserGlobals usage * chore: disable fetch in renderer procceses * dns: default to verbatim=true in dns.lookup() nodejs/node#39987 Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>

targos added the semver-major PRs that contain breaking changes and should be released in the next major version. label Apr 8, 2022

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Apr 8, 2022

github-actions bot mentioned this pull request Apr 9, 2022

CI Reliability 2022-04-09 nodejs/reliability#246

Open

24 tasks

targos force-pushed the v8-101 branch from 98e4a61 to cab95c7 Compare April 9, 2022 09:11

targos mentioned this pull request Apr 9, 2022

Should we drop support for 32 bit Windows? #42543

Closed

github-actions bot mentioned this pull request Apr 10, 2022

CI Reliability 2022-04-10 nodejs/reliability#247

Open

26 tasks

richardlau mentioned this pull request Apr 10, 2022

jenkins: temporarily exclude win32 for Node.js 18 nodejs/build#2921

Merged

This was referenced Apr 11, 2022

CI Reliability 2022-04-11 nodejs/reliability#248

Open

CI Reliability 2022-04-12 nodejs/reliability#249

Open

targos and others added 8 commits April 12, 2022 11:10

deps: update V8 to 10.1.124.6

a5cecb3

build: reset embedder string to "-node.0"

f4df3c5

src: update NODE_MODULE_VERSION to 108

9be688c

Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 10.1. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md

deps: disable trap handler for Windows cross-compiler

f5e32e9

`handler-outside-simulator.cc` uses inline assembly, which is not supported by MSVC. PR-URL: nodejs#40488 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

deps: silence V8's warning on CompileFunction

b253a3a

We are not ready to migrate yet. Refs: nodejs/node-v8#214 PR-URL: nodejs#40907 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps: update V8 to 10.1 #42657

deps: update V8 to 10.1 #42657

targos commented Apr 8, 2022 •

edited

Loading

nodejs-github-bot commented Apr 8, 2022

nodejs-github-bot commented Apr 8, 2022 •

edited by targos

Loading

targos commented Apr 8, 2022

aduh95 commented Apr 8, 2022

targos commented Apr 9, 2022 •

edited

Loading

targos commented Apr 9, 2022

targos commented Apr 9, 2022

nodejs-github-bot commented Apr 9, 2022 •

edited by targos

Loading

targos commented Apr 9, 2022

richardlau commented Apr 10, 2022

joyeecheung commented Apr 12, 2022

deps: update V8 to 10.1 #42657

deps: update V8 to 10.1 #42657

Conversation

targos commented Apr 8, 2022 • edited Loading

nodejs-github-bot commented Apr 8, 2022

nodejs-github-bot commented Apr 8, 2022 • edited by targos Loading

targos commented Apr 8, 2022

aduh95 commented Apr 8, 2022

targos commented Apr 9, 2022 • edited Loading

targos commented Apr 9, 2022

targos commented Apr 9, 2022

nodejs-github-bot commented Apr 9, 2022 • edited by targos Loading

targos commented Apr 9, 2022

richardlau commented Apr 10, 2022

joyeecheung commented Apr 12, 2022

targos commented Apr 8, 2022 •

edited

Loading

nodejs-github-bot commented Apr 8, 2022 •

edited by targos

Loading

targos commented Apr 9, 2022 •

edited

Loading

nodejs-github-bot commented Apr 9, 2022 •

edited by targos

Loading