Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update V8 to 9.7 #40907

Closed
wants to merge 17 commits into from
Closed

deps: update V8 to 9.7 #40907

wants to merge 17 commits into from

Conversation

targos
Copy link
Member

@targos targos commented Nov 21, 2021

ETA: Tue, Jan 4, 2022

Blog post: https://v8.dev/blog/v8-release-97

@targos targos added semver-major PRs that contain breaking changes and should be released in the next major version. v8 engine Issues and PRs related to the V8 dependency. labels Nov 21, 2021
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Nov 21, 2021
@targos
Copy link
Member Author

targos commented Nov 22, 2021

@nodejs-github-bot

This comment has been minimized.

@richardlau
Copy link
Member

@nodejs/platform-ppc PTAL: https://ci.nodejs.org/job/node-test-commit-v8-linux/4394/nodes=centos7-ppcle,v8test=v8test/

@targos maybe try rolling to 9.7.106.8 to pick up https://chromium.googlesource.com/v8/v8.git/+/5f980ae0c9c6539522383d6298f8363a34d7f52f?

@targos
Copy link
Member Author

targos commented Nov 22, 2021

Done.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 22, 2021

@targos
Copy link
Member Author

targos commented Nov 22, 2021

It looks like this update breaks JS code that was working before ?!?!

13:56:31 npm ERR! Cannot assign to read only property 'name' of function 'class CI extends ArboristWorkspaceCmd {
13:56:31 npm ERR!   static description = 'Install a project with a clean slate'
13:56:31 npm ERR!   static ...<omitted>...
13:56:31 npm ERR! }'

@targos
Copy link
Member Author

targos commented Nov 22, 2021

I cannot reproduce this error on my machine.

Edit: rebasing to test with the latest npm.

@miladfarca
Copy link
Contributor

miladfarca commented Nov 22, 2021

@targos The V8 patch is PPC specific, but this error seems to be present on other platforms as well?
Built this PR on a PPC machine and couldn't reproduce this error either. Could you retry building in the CI?

@targos
Copy link
Member Author

targos commented Nov 22, 2021

@miladfarca the PPC issue was fixed by 943c829

@targos
Copy link
Member Author

targos commented Nov 22, 2021

The code that fails now is:

class X {
 static name = "name"
}

I can reproduce in Chrome canary:
image

@ljharb maybe you know if it's an expected spec change?

@targos
Copy link
Member Author

targos commented Nov 22, 2021

I opened https://bugs.chromium.org/p/v8/issues/detail?id=12421

@ljharb
Copy link
Member

ljharb commented Nov 22, 2021

No, class fields use Define, not Set, so the writability of Function names shouldn’t matter. Seems like a v8 bug.

@nassau-t
Copy link

The code that fails now is:

class X {
 static name = "name"
}

Only to comment, this works on Firefox.

@bricss
Copy link

bricss commented Jan 18, 2022

I opened https://bugs.chromium.org/p/v8/issues/detail?id=12421

Looks like patch 🩹 is ready 👾

targos and others added 4 commits January 18, 2022 11:07
Major V8 updates are usually API/ABI incompatible with previous
versions. This commit adapts NODE_MODULE_VERSION for V8 9.7.

Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
Original commit message:

    [testrunner] delete ancient junit compatible format support

    Testrunner has ancient support for JUnit compatible XML output.

    This CL removes this old feature.

    R=mstarzinger@chromium.org,jgruber@chromium.org,jkummerow@chromium.org
    CC=​machenbach@chromium.org

    Bug: v8:8728
    Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0
    Reviewed-on: https://chromium-review.googlesource.com/c/1430065
    Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
    Commit-Queue: Tamer Tas <tmrts@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#59045}

Refs: v8/v8@bd019bd

PR-URL: nodejs#32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 22, 2022
We are not ready to migrate yet.

Refs: #214

PR-URL: nodejs/node#40907
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 23, 2022
We are not ready to migrate yet.

Refs: #214

PR-URL: nodejs/node#40907
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 24, 2022
We are not ready to migrate yet.

Refs: #214

PR-URL: nodejs/node#40907
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 25, 2022
We are not ready to migrate yet.

Refs: #214

PR-URL: nodejs/node#40907
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit that referenced this pull request Jul 25, 2022
We are not ready to migrate yet.

Refs: nodejs/node-v8#214

PR-URL: #40907
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 26, 2022
We are not ready to migrate yet.

Refs: #214

PR-URL: nodejs/node#40907
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 27, 2022
We are not ready to migrate yet.

Refs: #214

PR-URL: nodejs/node#40907
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 28, 2022
We are not ready to migrate yet.

Refs: #214

PR-URL: nodejs/node#40907
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit that referenced this pull request Jul 29, 2022
We are not ready to migrate yet.

Refs: nodejs/node-v8#214

PR-URL: #40907
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit that referenced this pull request Jul 30, 2022
We are not ready to migrate yet.

Refs: nodejs/node-v8#214

PR-URL: #40907
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 30, 2022
We are not ready to migrate yet.

Refs: #214

PR-URL: nodejs/node#40907
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Jul 31, 2022
We are not ready to migrate yet.

Refs: #214

PR-URL: nodejs/node#40907
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Aug 1, 2022
We are not ready to migrate yet.

Refs: #214

PR-URL: nodejs/node#40907
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Aug 2, 2022
We are not ready to migrate yet.

Refs: #214

PR-URL: nodejs/node#40907
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Aug 3, 2022
We are not ready to migrate yet.

Refs: #214

PR-URL: nodejs/node#40907
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Aug 4, 2022
We are not ready to migrate yet.

Refs: #214

PR-URL: nodejs/node#40907
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Aug 5, 2022
We are not ready to migrate yet.

Refs: #214

PR-URL: nodejs/node#40907
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Aug 6, 2022
We are not ready to migrate yet.

Refs: #214

PR-URL: nodejs/node#40907
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Aug 7, 2022
We are not ready to migrate yet.

Refs: #214

PR-URL: nodejs/node#40907
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Aug 8, 2022
We are not ready to migrate yet.

Refs: #214

PR-URL: nodejs/node#40907
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Aug 9, 2022
We are not ready to migrate yet.

Refs: #214

PR-URL: nodejs/node#40907
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Aug 10, 2022
We are not ready to migrate yet.

Refs: #214

PR-URL: nodejs/node#40907
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Aug 11, 2022
We are not ready to migrate yet.

Refs: #214

PR-URL: nodejs/node#40907
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Aug 12, 2022
We are not ready to migrate yet.

Refs: #214

PR-URL: nodejs/node#40907
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Aug 13, 2022
We are not ready to migrate yet.

Refs: #214

PR-URL: nodejs/node#40907
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Aug 14, 2022
We are not ready to migrate yet.

Refs: #214

PR-URL: nodejs/node#40907
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Aug 15, 2022
We are not ready to migrate yet.

Refs: #214

PR-URL: nodejs/node#40907
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Aug 16, 2022
We are not ready to migrate yet.

Refs: #214

PR-URL: nodejs/node#40907
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-github-bot pushed a commit to nodejs/node-v8 that referenced this pull request Aug 17, 2022
We are not ready to migrate yet.

Refs: #214

PR-URL: nodejs/node#40907
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.