Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V17.8.1 proposal #42612

Closed
wants to merge 93 commits into from
Closed

V17.8.1 proposal #42612

wants to merge 93 commits into from

Conversation

juanarbol
Copy link
Member

2022-04-04, Version 17.8.1 (Current), @BethGriggs prepared by @juanarbol

Notable Changes

Commits

  • [e73bf4355d] - async_hooks: remove destroyed symbol on Promises (Gerhard Stöbich) #42402
  • [94e8da8f9e] - bootstrap: reset process._exit and process.exitCode in pre-execution (Joyee Cheung) #42466
  • [cbdc0ab9c7] - bootstrap: run inspector and event loop in snapshot builder (Joyee Cheung) #42466
  • [fa28439583] - bootstrap: make I/O streams work with user-land snapshot (Joyee Cheung) #42466
  • [a113d4379a] - bootstrap: use SnapshotData to pass snapshot data around (Joyee Cheung) #42360
  • [3fbfd6550d] - buffer: improve Blob constructor error message when passing a string (Xuguang Mei) #42338
  • [b250b8ec95] - buffer: fix atob input validation (Antoine du Hamel) #42539
  • [ebefd25141] - build: consolidate JS and md linting GitHub Actions (Rich Trott) #42572
  • [fe62d4b506] - build: set stale action back to running nightly (Michael Dawson) #42549
  • [6b14bd8f31] - build: add --node-snapshot-main configure option (Joyee Cheung) #42466
  • [b647336c96] - build: bump actions/checkout (Eliaz Bobadilla) #42460
  • [7105f8b467] - child_process: add env contents types in JSDoc (Rich Trott) #42494
  • [fa7edb7acd] - crypto: do not add undefined hash in webcrypto normalizeAlgorithm (Filip Skokan) #42559
  • [c036258809] - crypto: cleanup webcrypto jwk code (Filip Skokan) #42562
  • [4e7b7465bc] - crypto: fix webcrypto derive key lengths (Filip Skokan) #42542
  • [2ca08c948c] - (SEMVER-MINOR) crypto: make authTagLength optional for CC20P1305 (Tobias Nießen) #42427
  • [9158b91440] - deps: update undici to 4.16.0 (Node.js GitHub Bot) #42414
  • [e158a8db98] - doc: remove faulty justification for 128-bit AES (Tobias Nießen) #42578
  • [73a1d224c0] - doc: fix documentation of FileHandle.prototype.appendFile (Antoine du Hamel) #42588
  • [858af420ef] - doc: change "OCSP Request" to "OCSP request" (Tobias Nießen) #42582
  • [a6c65fc7d2] - doc: aes webcrypto unwrap is not a node-specific extensions (Filip Skokan) #42561
  • [d2f17ace5d] - doc: simplify recommendations in process.md (Rich Trott) #42556
  • [8dd88cc269] - doc: clarify recommendations in stream.md (Rich Trott) #42555
  • [b7748e4d89] - doc: simplify recommendation in webcrypto.md (Rich Trott) #42554
  • [8d5c9d9c24] - doc: update DEP0102 text (Rich Trott) #42553
  • [8e55e59cb4] - doc: remove util.promisify() content in readline.md (Rich Trott) #42552
  • [0c1e6905d5] - doc: add introduction sentence for CJS (Antoine du Hamel) #42491
  • [f3c3479bf0] - doc: add @meixg to collaborators (Xuguang Mei) #42576
  • [53d73047a9] - doc: consolidate CI sections (Rich Trott) #42534
  • [ae9d5fdb39] - doc: document breaking change in http.IncomingMessage 'close' event (Paolo Insogna) #42521
  • [98f1f34cbe] - doc: remove extraneous comma (Rich Trott) #42548
  • [8b7c057ff1] - doc: guide towards x509.fingerprint256 (Tobias Nießen) #42516
  • [d2ebe2b190] - doc: fix internal link in collaborator-guide.md (Daeyeon Jeong) #42551
  • [607a5ca653] - doc: add suggestion for OpenSSL only sec releases (Michael Dawson) #42456
  • [838b143f69] - doc: fix comment text in async_hooks example (Rich Trott) #42499
  • [743b62b4d5] - doc: add stability class to legacy status description (Daniel Roe) #42525
  • [9e14b0efc2] - doc: suggest checkHost in checkServerIdentity docs (Tobias Nießen) #42495
  • [a946977de7] - doc: update security release onboarding (Joe Sepi) #42333
  • [efd30710be] - doc: fix question promise API example (Xuguang Mei) #42465
  • [28a770eec0] - doc: remove comma splice in events.md (Rich Trott) #42484
  • [f9f6c8e001] - doc: clarify napi_finalize behavior (Alba Mendez) #42461
  • [54615fdce1] - doc: expand history for conditional exports changes in v12 (Greg Poole) #42339
  • [3b810caddc] - doc: change comma-splice to two sentences (Rich Trott) #42455
  • [13840ef2af] - doc: add link to section (Rich Trott) #42428
  • [26d5e580b5] - doc: fix typo in async_context.md (Anupama Codippily) #42444
  • [41b353d0c8] - doc: add trace\_gc to diagnostic tooling support document (Tony Gorez) #42346
  • [89da27c11f] - doc: make header smaller and dropdown click-driven when JS is on (Paolo Insogna) #42165
  • [9b0ac65971] - doc: standardize typography for semantic versioning (Rich Trott) #42401
  • [76be5651af] - doc: unify import order in CCM example (Tobias Nießen) #42394
  • [07b38f6695] - doc: update property name (Rich Trott) #42398
  • [5602c08a12] - doc,test: clarify ChaCha20-Poly1305 usage (Tobias Nießen) #42323
  • [eea25dc430] - esm: emit experimental warnings in common place (Jacob Smith) #42314
  • [99f9880a6f] - fs: fix write methods param validation and docs (Livia Medeiros) #41677
  • [5e0ca4c14b] - lib: prepare files for no-var lint rule (Rich Trott) #42573
  • [6258055603] - lib: source maps filter null prefix (Fabian Cook) #42522
  • [3ee5434141] - lib: improve the coverage of the validator (mawaregetsuka) #42443
  • [86a05ca604] - lib: update JSDoc for linting (Rich Trott) #42489
  • [1e3e6895a6] - meta: update .mailmap and AUTHORS (Rich Trott) #42602
  • [dea7f22bdb] - meta: move one or more collaborators to emeritus (Node.js GitHub Bot) #42500
  • [466673735d] - meta: update AUTHORS (Node.js GitHub Bot) #42585
  • [439a87ec36] - meta: update AUTHORS (Node.js GitHub Bot) #42488
  • [7956559fe4] - net,dns: trace tcp connection and dns by perf_hooks (theanarkh) #42390
  • [93c874fdbe] - node-api: format Node-API related code (Vladimir Morozov) #42396
  • [0fcb067991] - os: avoid unnecessary usage of var (Mohammed Keyvanzadeh) #42563
  • [3084af316c] - src: add proper mutexes for accessing FIPS state (Anna Henningsen) #42278
  • [5c9771f8e9] - src: fix typo in InspectorIoDelegate constructor (Kohei Ueno) #42520
  • [987b5d13cd] - src: remove unnecessary static qualifier in crypto_dh.cc (Darshan Sen) #42492
  • [c9c0cc5b9e] - src: address 3 useless call coverity warnings (Michael Dawson) #42426
  • [8e8f129a5e] - src: properly report exceptions from AddressToJS() (Darshan Sen) #42054
  • [c516c84e52] - src: suppress false coverity warning (Michael Dawson) #42284
  • [0a2123d24c] - src: refactor IsSupportedAuthenticatedMode (Tobias Nießen) #42368
  • [899de04a26] - src,crypto: handle empty maybe correctly in crypto_dh.cc (Darshan Sen) #42492
  • [cf1543e71e] - src,crypto: remove uses of AllocatedBuffer from crypto_dh.cc (Darshan Sen) #42492
  • [44ac5e8ab3] - test: improve lib/internal/readline/promises.js coverage (MURAKAMI Masahiko) #42420
  • [dd1ea775ac] - test: remove hack for atob and btoa WPT tests (Antoine du Hamel) #42540
  • [d71df7a156] - test: pass data into napi_create_external (Joyee Cheung) #42532
  • [3734b64f77] - test: improve FileHandle.prototype.write coverage (Antoine du Hamel) #42541
  • [f25ba8c4c7] - test: add test for exception handlings in debugger (Kohei Ueno) #42327
  • [e310a2701d] - test: fix typo in common/wpt.js (Ikko Ashimine) #42567
  • [37ad634bae] - test: fix comments in test files (Daeyeon Jeong) #42536
  • [8bb04f5b0b] - test: fix typos in test/parallel (Daeyeon Jeong) #42502
  • [b756ed8649] - test: add trace-gc flag test (Tony Gorez) #42471
  • [470e911d1c] - test,fs: add fs.rm() tests for .git directories (Darshan Sen) #42410
  • [0a8b362729] - tools: enable no-var ESLint rule for lib (Rich Trott) #42573
  • [4dfc29dbda] - tools: fixed bug causing JSON format to be broken (mawaregetsuka) #41565
  • [16702660a4] - tools: update GHA actions version (Antoine du Hamel) #42498
  • [f4decbd608] - tools: update eslint to 8.12.0 (Node.js GitHub Bot) #42489
  • [136b9f8cdc] - tools: update lint-md-dependencies to vfile-reporter@7.0.4 (Node.js GitHub Bot) #42487
  • [bd688f7513] - tools: refloat 7 Node.js patches to cpplint.py (Rich Trott) #42416
  • [80a22516a6] - tools: bump cpplint to 1.6.0 (Rich Trott) #42416
  • [17770bea06] - tools: fix skip PR if CI is still running (Xuguang Mei) #42377

meixg and others added 30 commits April 4, 2022 18:37
resolve: #40330

PR-URL: #42377
Fixes: #40330
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Property name `min` was updated in 23637e9
to `lowest` but an instance of `min` was missed.

PR-URL: #42398
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Refs: #39043

PR-URL: #42394
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Improve the function's structure and clarify the special handling of
ChaCha20-Poly1305. Remove the IS_OCB_MODE macro.

PR-URL: #42368
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
PR-URL: #42323
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #42396
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
PR-URL: #42401
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Promises are never destroyed manually therefore it's not needed to
attach an object to track if destroy hook was called already.

PR-URL: #42402
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
PR-URL: #42165
Fixes: #42286
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #42284
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #42416
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Cherry-pick 12c8b4d
Original commit message:
    This commit is a suggestion for adding a rule for NULL usages in the
    code base. This will currently report a number of errors which could be
    ignored using // NOLINT (readability/null_usage)

    PR-URL: #17373
    Reviewed-By: Jon Moss <me@jonathanmoss.me>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>

Refs: 12c8b4d

Cherry-pick fc81e80
Original commit message:

    Update cpplint.py to check for inline headers when the corresponding
    header is already included.

    PR-URL: #21521
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>

Refs: fc81e80

Cherry-pick cbc3dd9
Original commit message:

    src, tools: add check for left leaning pointers

    This commit adds a rule to cpplint to check that pointers in the code
    base lean to the left and not right, and also fixes the violations
    reported.

    PR-URL: #21010
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>

Refs: cbc3dd9

Cherry-pick 9029981
Original commit message:

    tools: fix cpplint.py header rules

    THIS COMMIT SHOULD GO WITH THE NEXT. IT WILL FIND NEW LINT.

    PR-URL: #26306
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

Refs: 9029981

Cherry-pick 0a25ace
Original commit message:

    tools: move cpplint configuration to .cpplint

    PR-URL: #27098
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

Refs: 0a25ace

Cherry-pick afa9a72
Original commit message:

    tools: refloat update link to google styleguide for cpplint

    This commit updates two old links to Google's C++ styleguide which
    currently result in a 404 when accessed.

    PR-URL: #30876
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>

Refs: afa9a72

Cherry-pick e23bf8f
Original commit message:

    tools,src: refloat forbid usage of v8::Persistent

    `v8::Persistent` comes with the surprising catch that it requires
    manual cleanup. `v8::Global` doesn’t, making it easier to use,
    and additionally provides move semantics. New code should always
    use `v8::Global`.

    PR-URL: #31018
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>

PR-URL: #35569
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

PR-URL: #35719
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: #35866

PR-URL: #36213
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

PR-URL: #36235
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: #36324
Reviewed-By: Beth Griggs <bgriggs@redhat.com>

PR-URL: #38851
Reviewed-By: Khaidi Chu <i@2333.moe>

PR-URL: #42416
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Instead of passing the snapshot blob, the per-isolate data
indices and the EnvSerializeInfo separately, use the aggregate
type Snapshot to carry these around, and refactor
NodeMainInstance so that it owns the v8::Isolate::CreateParams
when it owns its isolate. This also gets rid of the owns_isolate_
and deserialize_mode_ booleans in NodeMainInstance since
NodeMainInstance can compute these by just checking if it has
pointers to the CreateParams or the SnapshotData.

PR-URL: #42360
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
PR-URL: #42346
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #42444
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Mestery <mestery@protonmail.com>
PR-URL: #42414
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #42428
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
PR-URL: #42455
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #42054
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Fixes: #36162

PR-URL: #42339
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #42427
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
PR-URL: #42488
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
We currently defer finalizer callbacks until the loop is idle.
Warn users that the weak reference returned by napi_wrap()
isn't guaranteed to be valid just because the finalizer hasn't
yet been called.

PR-URL: #42461
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #42487
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Fix issue that will be flagged when we update ESLint and dependencies.

PR-URL: #42489
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #42489
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #42484
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Git for Windows creates read-only files inside the .git directory.
fs.rm() was built in a way, to work around any EPERM error that can
happen while deleting the .git directory by turning the directory
into a writable one. This change adds a regression test for that.

Refs: isaacs/rimraf#21
Refs: #38810 (comment)
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #42410
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
https://github.com/actions/checkout\#checkout-v3

PR-URL: #42460
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #42465
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
nodejs-github-bot and others added 11 commits April 4, 2022 18:53
PR-URL: #42500
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
The `var` keyword is known to be problematic and is not needed here,
so better to use the `let` keyword for variable declarations.

PR-URL: #42563
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Fixes: #42417

PR-URL: #42522
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #42588
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
This sentence implies that AES-128 is preferred over AES-256 because
of a related-key attack from 2009. However, that attack by Alex
Biryukov, Orr Dunkelman, Nathan Keller, Dmitry Khovratovich, and Adi
Shamir, while impressive, is only effective against variants of
AES-256 with a reduced number of rounds and it requires related keys.
This means that the attack is not effective against AES-256 as it is
used within TLS.

(AES-128 is still often preferred over AES-256 simply because it is
believed to be sufficiently secure and because it is faster.)

PR-URL: #42578
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Linting markdown runs the JavaScript linting job, so consolidate them to
conserve time and resources. Run JavaScript separately, but then run
markdown linting so it can use the cached results of the JavaScript
linting.

PR-URL: #42572
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
PR-URL: #42573
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #42573
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
The FS docs wrongfully indicated support for passing object with an own
`toString` function property to `FileHandle.prototype.appendFile`,
`FileHandle.prototype.writeFile`, `FileHandle.prototype.write`,
`fsPromises.writeFile`, and `fs.writeSync`. This commit fixes that, and
adds some test to ensure the actual behavior is aligned with the docs.
It also fixes a bug that makes the process crash if a non-buffer object
was passed to `FileHandle.prototype.write`.

Refs: #34993
PR-URL: #41677
Refs: #41666
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
resolve: #38856

PR-URL: #42338
Fixes: #38856
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Refs: #42599 (comment)

PR-URL: #42602
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. dependencies Pull requests that update a dependency file. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v17.x labels Apr 5, 2022


Notable Changes:

* doc: add @meixg to collaborators (Xuguang Mei) #42576

PR-URL: #42612
@nodejs-github-bot
Copy link
Collaborator

@@ -44,6 +45,108 @@
* [io.js](CHANGELOG_IOJS.md)
* [Archive](CHANGELOG_ARCHIVE.md)

<a id="17.8.1"></a>

## 2022-04-04, Version 17.8.1 (Current), @BethGriggs prepared by @juanarbol
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this includes a semver-minor the version should be 17.9.0.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

juanarbol added a commit that referenced this pull request Apr 5, 2022


Notable Changes:

* doc: add @meixg to collaborators (Xuguang Mei) #42576

PR-URL: #42612
@juanarbol
Copy link
Member Author

Moved to: #42613

@juanarbol juanarbol closed this Apr 5, 2022
@juanarbol juanarbol deleted the v17.8.1-proposal branch April 5, 2022 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. dependencies Pull requests that update a dependency file. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.