-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: history shows wrong version for conditional package export support #36162
Comments
This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open. |
I've created a reproduction here https://github.com/gpoole/node-missing-export-map. While I was doing that I think I realised the problem is actually that the conditional exports do work in 12.16, but only if the 12.16 with It seems that conditional exports are tied to module support. I think this makes sense, but I think the history section doesn't make it clear and to me it says that 12.16 uses conditional exports without any flags, which it doesn't. |
Thanks for the clarification, it's probably worth clarifying the documentation indeed. Do you see the same bahavior for package self-reference in Node.js v12.16.0? |
Yes, I see the same behaviour. After adding cd node_modules/inner
node reference.cjs
# missing map hello
node --experimental-modules reference.cjs
# common hello
# (node:36203) ExperimentalWarning: The ESM module loader is experimental. |
Fixes: nodejs#36162 PR-URL: nodejs#42339 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Fixes: nodejs#36162 PR-URL: nodejs#42339 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Fixes: nodejs/node#36162 PR-URL: nodejs/node#42339 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: James M Snell <jasnell@gmail.com>
📗 API Reference Docs Problem
Location
Modules: Packages
Affected URL(s):
Description
Under the "history" section, the docs say that conditional export support was added and also unflagged in 12.16, which doesn't seem to be the case. 12.17.0 appears to be the first version that supports conditional exports and I can't get either conditional exports or the
--experimental-conditional-exports
flag to work in 12.16.0.submit a pull request.
The text was updated successfully, but these errors were encountered: