Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v14.1.0 proposal #33103

Merged
merged 93 commits into from
Apr 29, 2020
Merged

v14.1.0 proposal #33103

merged 93 commits into from
Apr 29, 2020

Conversation

BethGriggs
Copy link
Member

@BethGriggs BethGriggs commented Apr 27, 2020

2020-04-29, Version 14.1.0 (Current), @BethGriggs

Notable Changes

  • deps: upgrade openssl sources to 1.1.1g (Hassaan Pasha) #32971
  • doc: add juanarbol as collaborator (Juan José Arboleda) #32906
  • http: doc deprecate abort and improve docs (Robert Nagy) #32807
  • module: do not warn when accessing __esModule of unfinished exports (Anna Henningsen) #33048
  • n-api: detect deadlocks in thread-safe function (Gabriel Schulhof) #32860
  • src: deprecate embedder APIs with replacements (Anna Henningsen) #32858
  • stream:
    • don't emit end after close (Robert Nagy) #33076
    • don't wait for close on legacy streams (Robert Nagy) #33058
    • pipeline should only destroy un-finished streams (Robert Nagy) #32968
  • vm: add importModuleDynamically option to compileFunction (Gus Caplan) #32985

Commits

  • [1af08e1c5e] - buffer,n-api: fix double ArrayBuffer::Detach() during cleanup (Anna Henningsen) #33039
  • [91e30e35a1] - build: fix vcbuild error for missing Visual Studio (Thomas) #32658
  • [4035cbe631] - cluster: removed unused addressType argument from constructor (Yash Ladha) #32963
  • [56f50aeff0] - deps: patch V8 to 8.1.307.31 (Michaël Zasso) #33080
  • [fad188fe23] - deps: update archs files for OpenSSL-1.1.1g (Hassaan Pasha) #32971
  • [b12f1630fc] - deps: upgrade openssl sources to 1.1.1g (Hassaan Pasha) #32971
  • [b50333e001] - deps: V8: backport 3f8dc4b2e5ba (Ujjwal Sharma) #32993
  • [bbed1e56cd] - deps: V8: cherry-pick e1eac1b16c96 (Milad Farazmand) #32974
  • [3fed735099] - doc: fix LTS replaceme tags (Anna Henningsen) #33041
  • [343c6ac639] - doc: assign missing deprecation code (Richard Lau) #33109
  • [794b8796dd] - doc: improve WHATWG url constructor code example (Liran Tal) #32782
  • [14e559df87] - doc: make openssl maintenance position independent (Sam Roberts) #32977
  • [8a4de2ef25] - doc: improve release documentation (Michaël Zasso) #33042
  • [401ab610e7] - doc: document major finished changes in v14 (Robert Nagy) #33065
  • [a534d8282c] - doc: add documentation for transferList arg at worker threads (Juan José Arboleda) #32881
  • [f116825d56] - doc: avoid tautology in README (Ishaan Jain) #33005
  • [7e9f88e005] - doc: updated directory entry information (Eileen) #32791
  • [bf331b4e21] - doc: ignore no-literal-urls in README (Nick Schonning) #32676
  • [f92b398c76] - doc: convert bare email addresses to mailto links (Nick Schonning) #32676
  • [2bde11607d] - doc: ignore no-literal-urls in changelogs (Nick Schonning) #32676
  • [71f90234f9] - doc: add angle brackets around implicit links (Nick Schonning) #32676
  • [aec7bc754e] - doc: remove repeated word in modules.md (Prosper Opara) #32931
  • [005c2bab29] - doc: elevate diagnostic report to tier1 (Gireesh Punathil) #32732
  • [4dd3a7ddc9] - doc: set module version 83 to node 14 (Gerhard Stoebich) #32975
  • [b5b3efeb90] - doc: add more info to v14 changelog (Gus Caplan) #32979
  • [f6be140222] - doc: fix typo in security-release-process.md (Edward Elric) #32926
  • [fa710732bf] - doc: corrected ERR_SOCKET_CANNOT_SEND message (William Armiros) #32847
  • [68b7c80a44] - doc: fix usage of folder and directory terms in fs.md (karan singh virdi) #32919
  • [57c170c75c] - doc: fix typo in zlib.md (雨夜带刀) #32901
  • [a8ed8f5d0a] - doc: synch SECURITY.md with website (Rich Trott) #32903
  • [ccf6d3e5ed] - doc: add tsc-agenda to onboarding labels list (Rich Trott) #32832
  • [fc71a85c49] - doc: add N-API version 6 to table (Michael Dawson) #32829
  • [87605f0ed3] - doc: add juanarbol as collaborator (Juan José Arboleda) #32906
  • [4c643c0d42] - fs: update validateOffsetLengthRead in utils.js (daemon1024) #32896
  • [baa8231728] - fs: extract kWriteFileMaxChunkSize constant (rickyes) #32640
  • [03d02d74f3] - fs: remove unnecessary else statement (Jesus Hernandez) #32662
  • [31c797cb11] - http: doc deprecate abort and improve docs (Robert Nagy) #32807
  • [4ef91a640e] - http2: wait for secureConnect before initializing (Benjamin Coe) #32958
  • [6fc4d174b5] - http2: refactor and cleanup http2 (James M Snell) #32884
  • [4b6aa077fe] - inspector: only write coverage in fully bootstrapped Environments (Joyee Cheung) #32960
  • [737bd6205b] - lib: unnecessary const assignment for class (Yash Ladha) #32962
  • [98b30b06ff] - lib: simplify function process.emitWarning (himself65) #32992
  • [b957895ff7] - lib: remove unnecesary else block (David Daza) #32644
  • [cb4d8ce889] - module: refactor condition (Myles Borins) #32989
  • [4abc45a4b9] - module: do not warn when accessing \_\_esModule of unfinished exports (Anna Henningsen) #33048
  • [21d314e7fc] - module: exports not exported for null resolutions (Guy Bedford) #32838
  • [eaf841d585] - module: improve error for invalid package targets (Myles Borins) #32052
  • [8663fd5f88] - module: partial doc removal of --experimental-modules (Myles Borins) #32915
  • [68656cf588] - n-api: fix false assumption on napi_async_context structures (legendecas) #32928
  • [861eb39307] - (SEMVER-MINOR) n-api: detect deadlocks in thread-safe function (Gabriel Schulhof) #32860
  • [a133ac17eb] - perf_hooks: remove unnecessary assignment when name is undefined (rickyes) #32910
  • [59b64adb79] - src: add AsyncWrapObject constructor template factory (Stephen Belanger) #33051
  • [23eda417b6] - src: do not compare against wide characters (Christopher Beeson) #32921
  • [d10c2c6968] - src: fix empty-named env var assertion failure (Christopher Beeson) #32921
  • [44c157e45d] - src: assignment to valid type (Yash Ladha) #32879
  • [d82c3c28de] - src: delete MicroTaskPolicy namespace (Juan José Arboleda) #32853
  • [bc755fc4c2] - src: fix compiler warnings in node_http2.cc (Daniel Bevenius) #33014
  • [30c2b0f798] - (SEMVER-MINOR) src: deprecate embedder APIs with replacements (Anna Henningsen) #32858
  • [95e897edfc] - src: use using NewStringType (rickyes) #32843
  • [4221b1c8c9] - src: fix null deref in AllocatedBuffer::clear (Matt Kulukundis) #32892
  • [f9b8988df6] - src: remove validation of unreachable code (Juan José Arboleda) #32818
  • [307e43da4d] - src: elevate v8 namespaces (Nimit) #32872
  • [ca7e0a226e] - src: remove redundant v8::HeapSnapshot namespace (Juan José Arboleda) #32854
  • [ae157b8ca7] - (SEMVER-MINOR) stream: don't emit end after close (Robert Nagy) #33076
  • [184e80a144] - stream: don't wait for close on legacy streams (Robert Nagy) #33058
  • [e07c4ffc39] - stream: fix sync write perf regression (Robert Nagy) #33032
  • [2bb4ac409b] - stream: avoid drain for sync streams (Robert Nagy) #32887
  • [c21f1f03c5] - stream: removes unnecessary params (Jesus Hernandez) #32936
  • [4c10b5f378] - stream: consistent punctuation (Robert Nagy) #32934
  • [1a2b3eb3a4] - stream: fix broken pipeline test (Robert Nagy) #33030
  • [7abc61f668] - stream: refactor Writable buffering (Robert Nagy) #31046
  • [180b935b58] - stream: pipeline should only destroy un-finished streams (Robert Nagy) #32968
  • [7647860000] - stream: finished should complete with read-only Duplex (Robert Nagy) #32967
  • [36a4f54d69] - stream: close iterator in Readable.from (Vadzim Zieńka) #32844
  • [7f498125e4] - stream: inline unbuffered _write (Robert Nagy) #32886
  • [2ab4ebc8bf] - stream: simplify Writable.end() (Robert Nagy) #32882
  • [11ea13f96c] - test: refactor test-async-hooks-constructor (himself65) #33063
  • [8fad112d93] - test: remove timers-blocking-callback (Jeremiah Senkpiel) #32870
  • [988c2fe287] - test: better error validations for event-capture (Adrian Estrada) #32771
  • [45e188b2e3] - test: refactor events tests for invalid listeners (Adrian Estrada) #32769
  • [b4ef06267d] - test: test-async-wrap-constructor prefer forEach (Daniel Estiven Rico Posada) #32631
  • [c9ae385abf] - test: mark test-child-process-fork-args as flaky on Windows (Andrey Pechkurov) #32950
  • [b12204e27e] - test: changed function to arrow function (Nimit) #32875
  • [323da6f251] - tls: add highWaterMark option for connect (rickyes) #32786
  • [308681307f] - tls: move getAllowUnauthorized to internal/options (James M Snell) #32917
  • [6a8e266a3b] - tools: update ESLint to 7.0.0-rc.0 (himself65) #33062
  • [fa7d969237] - tools: remove unused code in doc generation tool (Rich Trott) #32913
  • [ca5ebcfb67] - tools: fix mkcodecache when run with ASAN (Anna Henningsen) #32850
  • [22ccf2ba1f] - tools: decrease timeout in test.py (Anna Henningsen) #32868
  • [c82c08416f] - util,readline: NFC-normalize strings before getStringWidth (Anna Henningsen) #33052
  • [4143c747fc] - (SEMVER-MINOR) vm: add importModuleDynamically option to compileFunction (Gus Caplan) #32985
  • [c84d802449] - worker: fix process.env var empty key access (Christopher Beeson) #32921

juanarbol and others added 30 commits April 27, 2020 20:40
PR-URL: #32906
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
We missed adding version 6 to the compatibility
table when we defined version 6. Add it along with the
versions that we know will include version 6.

PR-URL: #32829
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
PR-URL: #32854
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This fixes the following crash on Windows for me. I don't know
why this I only started to see this now, but anyway, the new timeout
value is still longer than a week and a half.

    File "tools/test.py", line 1725, in <module>
        sys.exit(Main())
    File "tools/test.py", line 1701, in Main
        if RunTestCases(cases_to_run, options.progress, \
          options.j, options.flaky_tests):
    File "tools/test.py", line 923, in RunTestCases
        return progress.Run(tasks)
    File "tools/test.py", line 145, in Run
        thread.join(timeout=10000000)
    File "C:\Users\anna\AppData\Local\Programs\Python\Python38-32\ \
      lib\threading.py", line 1015, in join
        self._wait_for_tstate_lock(timeout=max(timeout, 0))
    File "C:\Users\anna\AppData\Local\Programs\Python\Python38-32\ \
      lib\threading.py", line 1027, in _wait_for_tstate_lock
        elif lock.acquire(block, timeout):
    OverflowError: timeout value is too large

PR-URL: #32868
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Zeyu Yang <himself65@outlook.com>

Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
elevate v8 namespaces. Leverage `using` semantics
for repeated usage of v8 artifacts.

PR-URL: #32872
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Convert callback functions that are anonymous
to arrow functions for better readability.
Also adjusted the `this` object in places where
that was required.

PR-URL: #32875
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #32832
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Simplifies Writable.end() by inlining and
de-duplicating code.

PR-URL: #32882
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
PR-URL: #32886
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Call iterator.return() if not all of its values are consumed.

Fixes: #32842

PR-URL: #32844
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
The if statement inside the _writeHostObject function
returns an expression which makes the else block unnecessary.

PR-URL: #32644
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #32662
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Based on nodejs/help#2600 (comment)
the condition (amount < 0) won't be possible.

PR-URL: #32818
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
We introduce status `napi_would_deadlock` to be used as a return status
by `napi_call_threadsafe_function` if the call is made with
`napi_tsfn_blocking` on the main thread and the queue is full.

Fixes: #32615
Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
PR-URL: #32860
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Refs: nodejs/nodejs.org#3106 (comment)

PR-URL: #32903
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #32910
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #32640
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
PR-URL: #32901
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
This commit fixes the interchangeably usage of "folder" and "directory"
terms in fs.md

Fixes: #32902

PR-URL: #32919
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: #32950
Refs: #32863
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #32847
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
An empty buffer can have a null environment.  Previously, we were
getting away with with this, but -fsanitize=null in clang caught it.

PR-URL: #32892
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #32926
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
This removes `--experimental-modules` from showing up in `node -h`
and also removes the documentation from the man pages.

It will still work as a no-op, and is still included in cli.md

Refs: nodejs/modules#502

PR-URL: #32915
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
* cleanup constants in http2 binding
  The error constants were just doing some weird things. Cleanup
  and improve maintainability.
* simplify settings to reduce duplicate code
* improve style consistency and correctness
  Use snake_case for getters and setters at c++ level,
  avoid unnecessary use of enums,
  use consistent style for exported vs. internal constants,
  avoid unnecessary memory info reporting,
  use setters/getters for flags_ for improved code readability
* make EmitStatistics function private
* un-nest Http2Settings and Http2Ping
* refactoring and cleanup of Http2Settings and Http2Ping
* avoid ** syntax for readability
  The **session and **stream syntax for getting the underlying
  nghttp2 pointers is not ideal for readability
* use const references for Http2Priority
* remove unnecessary GetStream function
* refactor Http2Scope to use BaseObjectPtr
* move utility function to anonymous namespace
* refactor and simplify Origins
* Use an AllocatedBuffer instead of MaybeStackBuffer
* Use a const reference instead of pointer
* use BaseObjectPtr for Http2Streams map
* move MemoryInfo impl to cc

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #32884
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Make it so that the allow unauthorized warning can be easily reused
by the QUIC impl once that lands.

Extracted from #32379

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #32917
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Fixes: #32835

PR-URL: #32850
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
For targets that are strings that do not start with `./` or `/` the
error will now have additional information about what the programming
error is.

Closes: #32034

PR-URL: #32052
Fixes: #32034
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Signed-off-by: Myles Borins <myles.borins@gmail.com>
PR-URL: #32979
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Clearly state the modules version 83 is official node 14, similar as
it is done for other major node versions.

PR-URL: #32975
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Hakerh400 and others added 8 commits April 28, 2020 23:00
The previous error was wrongly redirecting users
to the ICU installation steps, which is unrelated to
missing Visual Studio.

PR-URL: #32658
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Currently, the URL docs for the WHATWG URL spec support are
somewhat lacking in their code example of how to access the
new URL constructor that lives inside the core url package.

PR-URL: #32782
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: #33109
Refs: #32807
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
napi_async_context should be an opaque type and not be used as same as
node::async_context.

PR-URL: #32928
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #33062
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
When cherry-picking release commits for LTS releases into master,
the `REPLACEME` metadata can be taken over as well, to give users
a more accurate view of what is being released on which release line.

This addresses this problem for all previous LTS releases for which
this has not been done.

Fixes: #33001

PR-URL: #33041
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Refs: v8/v8@8.1.307.30...8.1.307.31

PR-URL: #33080
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Readable stream could emit 'end' after 'close'.

PR-URL: #33076
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
BethGriggs added a commit that referenced this pull request Apr 28, 2020
Notable changes:

- deps: upgrade openssl sources to 1.1.1g (Hassaan Pasha)
  [#32971](#32971)
- doc: add juanarbol as collaborator (Juan José Arboleda)
  [#32906](#32906)
- http: doc deprecate abort and improve docs (Robert Nagy)
  [#32807](#32807)
- module: do not warn when accessing `__esModule` of unfinished exports
  (Anna Henningsen) [#33048](#33048)
- n-api: detect deadlocks in thread-safe function (Gabriel Schulhof)
  [#32860](#32860)
- src: deprecate embedder APIs with replacements (Anna Henningsen)
  [#32858](#32858)
- stream:
  - don't emit end after close (Robert Nagy)
    [#33076](#33076)
  - don't wait for close on legacy streams (Robert Nagy)
    [#33058](#33058)
  - pipeline should only destroy un-finished streams (Robert Nagy)
    [#32968](#32968)
- vm: add importModuleDynamically option to compileFunction (Gus Caplan)
  [#32985](#32985)

PR-URL: #33103
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@BethGriggs
Copy link
Member Author

@ronag, do you know if #33133 is likely to land soon? I've seen that it is fast-tracked, but there have been changes since.

I am looking to start rerunning builds in the next hour or two.

@ronag
Copy link
Member

ronag commented Apr 29, 2020

@ronag, do you know if #33133 is likely to land soon? I've seen that it is fast-tracked, but there have been changes since.

There are not enough votes for fast-track unfortunately. So I cannot say. I believe it's ready otherwise.

Notable changes:

- deps: upgrade openssl sources to 1.1.1g (Hassaan Pasha)
  [#32971](#32971)
- doc: add juanarbol as collaborator (Juan José Arboleda)
  [#32906](#32906)
- http: doc deprecate abort and improve docs (Robert Nagy)
  [#32807](#32807)
- module: do not warn when accessing `__esModule` of unfinished exports
  (Anna Henningsen) [#33048](#33048)
- n-api: detect deadlocks in thread-safe function (Gabriel Schulhof)
  [#32860](#32860)
- src: deprecate embedder APIs with replacements (Anna Henningsen)
  [#32858](#32858)
- stream:
  - don't emit end after close (Robert Nagy)
    [#33076](#33076)
  - don't wait for close on legacy streams (Robert Nagy)
    [#33058](#33058)
  - pipeline should only destroy un-finished streams (Robert Nagy)
    [#32968](#32968)
- vm: add importModuleDynamically option to compileFunction (Gus Caplan)
  [#32985](#32985)

PR-URL: #33103
@BethGriggs BethGriggs merged commit 9ffd8e7 into v14.x Apr 29, 2020
BethGriggs added a commit that referenced this pull request Apr 29, 2020
BethGriggs added a commit that referenced this pull request Apr 29, 2020
Notable changes:

- deps: upgrade openssl sources to 1.1.1g (Hassaan Pasha)
  [#32971](#32971)
- doc: add juanarbol as collaborator (Juan José Arboleda)
  [#32906](#32906)
- http: doc deprecate abort and improve docs (Robert Nagy)
  [#32807](#32807)
- module: do not warn when accessing `__esModule` of unfinished exports
  (Anna Henningsen) [#33048](#33048)
- n-api: detect deadlocks in thread-safe function (Gabriel Schulhof)
  [#32860](#32860)
- src: deprecate embedder APIs with replacements (Anna Henningsen)
  [#32858](#32858)
- stream:
  - don't emit end after close (Robert Nagy)
    [#33076](#33076)
  - don't wait for close on legacy streams (Robert Nagy)
    [#33058](#33058)
  - pipeline should only destroy un-finished streams (Robert Nagy)
    [#32968](#32968)
- vm: add importModuleDynamically option to compileFunction (Gus Caplan)
  [#32985](#32985)

PR-URL: #33103
BethGriggs added a commit to BethGriggs/nodejs.org that referenced this pull request Apr 29, 2020
@BethGriggs BethGriggs deleted the v14.1.0-proposal branch April 29, 2020 18:45
BethGriggs added a commit to nodejs/nodejs.org that referenced this pull request Apr 29, 2020
@targos targos added release Issues and PRs related to Node.js releases. and removed build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. openssl Issues and PRs related to the OpenSSL dependency. labels Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Issues and PRs related to Node.js releases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.