Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async_wrap: AsyncWrapObject constructor template factory #33051

Closed
wants to merge 1 commit into from
Closed

async_wrap: AsyncWrapObject constructor template factory #33051

wants to merge 1 commit into from

Conversation

Qard
Copy link
Member

@Qard Qard commented Apr 25, 2020

Just fixing up a little TODO from @addaleax. I'll see about doing the same for the PromiseWrap constructor in #32891, after this merges.

Checklist

@Qard Qard requested a review from addaleax April 25, 2020 00:06
@Qard Qard self-assigned this Apr 25, 2020
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Apr 25, 2020
addaleax
addaleax approved these changes Apr 25, 2020
View reviewed changes
src/async_wrap.cc Outdated Show resolved Hide resolved
@Qard Qard force-pushed the async-wrap-object-get-constructor-template branch from 2a43a7d to 49d5f4d Compare April 25, 2020 06:42
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31016/

@Qard Qard added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 27, 2020
@addaleax
Copy link
Member

Landed in a8236e0

@addaleax addaleax closed this Apr 27, 2020
addaleax pushed a commit that referenced this pull request Apr 27, 2020
@Qard @addaleax
src: add AsyncWrapObject constructor template factory
a8236e0 
PR-URL: #33051
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@Qard Qard deleted the async-wrap-object-get-constructor-template branch April 27, 2020 22:36
BethGriggs pushed a commit that referenced this pull request Apr 28, 2020
@Qard @BethGriggs
src: add AsyncWrapObject constructor template factory
80de3f6 
PR-URL: #33051
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
@Qard @BridgeAR
src: add AsyncWrapObject constructor template factory
c318a52 
PR-URL: #33051
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
@Qard @BridgeAR
src: add AsyncWrapObject constructor template factory
b953ab6 
PR-URL: #33051
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Apr 28, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Apr 28, 2020
@Qard @BethGriggs
src: add AsyncWrapObject constructor template factory
dbf6acb 
PR-URL: #33051
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Apr 28, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Apr 28, 2020
@Qard @BethGriggs
src: add AsyncWrapObject constructor template factory
59b64ad 
PR-URL: #33051
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
targos pushed a commit that referenced this pull request Apr 30, 2020
@Qard @targos
src: add AsyncWrapObject constructor template factory
1a83a5a 
PR-URL: #33051
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
@targos targos mentioned this pull request May 2, 2020
Merged
targos pushed a commit that referenced this pull request May 13, 2020
@Qard @targos
src: add AsyncWrapObject constructor template factory
62f2953 
PR-URL: #33051
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flarna Flarna Flarna approved these changes

@juanarbol juanarbol juanarbol approved these changes

@devnexen devnexen devnexen approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees

@Qard Qard

Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Qard @nodejs-github-bot @addaleax @jasnell @devnexen @juanarbol @Flarna