doc: clarify when destroy emits events #28970
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
ronag
changed the title
ronag
force-pushed
the
doc-clarify-destroy-events
branch
from
dfe2006 to
ec68dd8
Compare
Trott
reviewed
Aug 8, 2019
Trott
reviewed
Aug 8, 2019
ronag
force-pushed
the
doc-clarify-destroy-events
branch
2 times, most recently
from
2b38e1b to
02fe331
Compare
lpinca
reviewed
Aug 11, 2019
ronag
force-pushed
the
doc-clarify-destroy-events
branch
from
02fe331 to
cb3db82
Compare
ronag
force-pushed
the
doc-clarify-destroy-events
branch
from
cb3db82 to
032753b
Compare
|
@Trott: this is just grammar fixes at this point |
Trott
approved these changes
Sep 21, 2019
Trott
added
the
author ready
|
Landed in 1fceccb |
Trott
pushed a commit
that referenced
this pull request
Sep 22, 2019
PR-URL: #28970 Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 23, 2019
PR-URL: #28970 Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Sep 25, 2019
PR-URL: #28970 Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surprisingly this can be quite relevant when working with destroy.Grammar fix.
Checklist