Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: event contract #29005

Closed
6 tasks
ronag opened this issue Aug 6, 2019 · 3 comments
Closed
6 tasks

stream: event contract #29005

ronag opened this issue Aug 6, 2019 · 3 comments
Labels
meta Issues and PRs related to the general management of the project. stream Issues and PRs related to the stream subsystem.

Comments

@ronag
Copy link
Member

ronag commented Aug 6, 2019

Try to follow the assumed "contract"/"api" in terms of stream events:

events (only close after error, nothing after close, only error or close after destroy)

@addaleax addaleax added the stream Issues and PRs related to the stream subsystem. label Aug 6, 2019
@Fishrock123 Fishrock123 added the meta Issues and PRs related to the general management of the project. label Aug 7, 2019
@Fishrock123
Copy link
Contributor

Are these supposed to be check off?

@ronag
Copy link
Member Author

ronag commented Aug 8, 2019

I checked them when there was a PR. But maybe it makes more sense to check them when it's been merged.

@ronag
Copy link
Member Author

ronag commented Oct 6, 2019

I'm moving this into my own list and will open PR's accordingly when my number of open PR's drop.

@ronag ronag closed this as completed Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Development

No branches or pull requests

3 participants