Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: remove unneeded .gitignore entries #26370

Closed
wants to merge 1 commit into from
Closed

tools: remove unneeded .gitignore entries #26370

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,7 @@ vgcore.*
v8*.log
perf.data
perf.data.old
.waf*
tags
.lock-wscript
*.pyc
doc/api.xml
tmp/
Expand All @@ -34,9 +32,7 @@ iojs_g
node
node_g
*.swp
.benchmark_reports
icu_config.gypi
.eslintcache
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reasoning for removing this one? I wouldn't expect everyone to have this in their own .gitignore.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC they are all covered by
https://github.com/nodejs/node/blob/c45a9da926f8de50ae42be4e9cda52fe485435dc/.gitignore#L2

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC they are all covered by

node/.gitignore

Line 2 in c45a9da
.*

It would be nice if that was included in the commit message for anyone glancing through the commit history.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if that was included in the commit message for anyone glancing through the commit history.

@richardlau I've updated the commit message to say:

Remove entries from `.gitignore` that are already covered by the generic
`.*` entry on line 2 of the .gitignore file.

node_trace.*.log
coverage/
!**/node_modules/**/coverage
Expand Down Expand Up @@ -64,8 +60,6 @@ ipch/
*.opensdf
*.VC.db
*.VC.opendb
.vs/
.vscode/
/*.exe

/config.mk
Expand All @@ -86,7 +80,6 @@ deps/icu*.tgz
deps/icu-tmp
./node_modules
android-toolchain/
.svn/

# generated by gyp on Windows
deps/openssl/openssl.props
Expand Down