Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: remove unneeded .gitignore entries #26370

Closed
wants to merge 1 commit into from
Closed

tools: remove unneeded .gitignore entries #26370

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 1, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2724/pipeline

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Mar 1, 2019
cjihrig
cjihrig approved these changes Mar 1, 2019
View reviewed changes
.gitignore
icu_config.gypi
.eslintcache
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reasoning for removing this one? I wouldn't expect everyone to have this in their own .gitignore.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC they are all covered by
https://github.com/nodejs/node/blob/c45a9da926f8de50ae42be4e9cda52fe485435dc/.gitignore#L2

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC they are all covered by

node/.gitignore

Line 2 in c45a9da
.*

It would be nice if that was included in the commit message for anyone glancing through the commit history.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if that was included in the commit message for anyone glancing through the commit history.

@richardlau I've updated the commit message to say:

Remove entries from `.gitignore` that are already covered by the generic
`.*` entry on line 2 of the .gitignore file.

richardlau
richardlau approved these changes Mar 1, 2019
View reviewed changes
.gitignore
icu_config.gypi
.eslintcache
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC they are all covered by

node/.gitignore

Line 2 in c45a9da
.*

It would be nice if that was included in the commit message for anyone glancing through the commit history.

@Trott
tools: remove unneeded .gitignore entries
b9f1338 
Remove entries from `.gitignore` that are already covered by the generic
`.*` entry on line 2 of the .gitignore file.
@Trott
Copy link
Member Author

Trott commented Mar 2, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2738/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 2, 2019
@Trott
Copy link
Member Author

Trott commented Mar 3, 2019

Landed in b97cd9b

@Trott Trott closed this Mar 3, 2019
Trott added a commit to Trott/io.js that referenced this pull request Mar 3, 2019
@Trott
tools: remove unneeded .gitignore entries
b97cd9b 
Remove entries from `.gitignore` that are already covered by the generic
`.*` entry on line 2 of the .gitignore file.

PR-URL: nodejs#26370
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR pushed a commit that referenced this pull request Mar 4, 2019
@Trott @BridgeAR
tools: remove unneeded .gitignore entries
6e9a7e1 
Remove entries from `.gitignore` that are already covered by the generic
`.*` entry on line 2 of the .gitignore file.

PR-URL: #26370
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Mar 4, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 16, 2019
@Trott @BethGriggs
tools: remove unneeded .gitignore entries
d4a8769 
Remove entries from `.gitignore` that are already covered by the generic
`.*` entry on line 2 of the .gitignore file.

PR-URL: #26370
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
@Trott Trott deleted the eslintcache branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refack refack refack approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @nodejs-github-bot @refack @jasnell @cjihrig @richardlau