Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inspector: return Error objects on error #26255

Merged
merged 2 commits into from
Feb 26, 2019
Merged

inspector: return Error objects on error #26255

merged 2 commits into from
Feb 26, 2019

Commits on Feb 26, 2019

  1. errors: add ERR_INSPECTOR_COMMAND error 

    This error is used to propagate errors returned from the
inspector module's command system.

PR-URL: nodejs#26255
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    @cjihrig
    cjihrig committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    d7a3c3c View commit details
    Browse the repository at this point in the history

  2. inspector: return Error objects on error 

    The inspector communicates errors via POJOs. This commit
wraps the error information in an actual Error object.

PR-URL: nodejs#26255
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    @cjihrig
    cjihrig committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    e3d4a7d View commit details
    Browse the repository at this point in the history