inspector: return Error objects on error #26255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
errors
addaleax
approved these changes
Feb 21, 2019
eugeneo
approved these changes
Feb 21, 2019
addaleax
added
the
author ready
|
EDIT: Green CI: https://ci.nodejs.org/job/node-test-pull-request/21006/ |
BridgeAR
approved these changes
Feb 21, 2019
test/sequential/test-inspector-runtime-evaluate-with-timeout.js
Outdated
Show resolved
Hide resolved
cjihrig
force-pushed
the
inspector-warn
branch
2 times, most recently
from
041fc27
to
e4bdbc1
Compare
This error is used to propagate errors returned from the inspector module's command system. PR-URL: nodejs#26255 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
The inspector communicates errors via POJOs. This commit wraps the error information in an actual Error object. PR-URL: nodejs#26255 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
cjihrig
force-pushed
the
inspector-warn
branch
from
e4bdbc1
to
e3d4a7d
Compare
|
Landed in 907941d...e3d4a7d |
addaleax
pushed a commit
that referenced
this pull request
Mar 1, 2019
This error is used to propagate errors returned from the inspector module's command system. PR-URL: #26255 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax
pushed a commit
that referenced
this pull request
Mar 1, 2019
The inspector communicates errors via POJOs. This commit wraps the error information in an actual Error object. PR-URL: #26255 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inspector communicates errors via POJOs. This PR wraps the error information in an actual Error object.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes