Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix http2-binding strictEqual order #24616

Closed
wants to merge 1 commit into from
Closed

test: fix http2-binding strictEqual order #24616

wants to merge 1 commit into from

Conversation

dominikeinkemmer
Copy link
Contributor

Refs: nodejsjp#1

Switched the order of arguments for strictEqual checks inside of test/paralell/test-http2-binding.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@dominikeinkemmer
test: fix http2-binding strictEqual order
be89026 
Switched the order of arguments for strictEqual checks inside of test/paralell/test-http2-binding.js
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 24, 2018
@addaleax addaleax added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 24, 2018
@gireeshpunathil
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/18922/

@gireeshpunathil
Copy link
Member

fast-track? pls 👍

@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 24, 2018
@Trott
Copy link
Member

Trott commented Nov 24, 2018

Landed in a57343c.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Nov 24, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 24, 2018
@dominikeinkemmer @Trott
test: fix http2-binding strictEqual order
a57343c 
Switched the order of arguments for strictEqual checks inside of
test/paralell/test-http2-binding.js

PR-URL: nodejs#24616
Refs: nodejsjp#1
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this pull request Nov 25, 2018
@dominikeinkemmer @targos
test: fix http2-binding strictEqual order
37746ef 
Switched the order of arguments for strictEqual checks inside of
test/paralell/test-http2-binding.js

PR-URL: #24616
Refs: nodejsjp#1
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@dominikeinkemmer @rvagg
test: fix http2-binding strictEqual order
cd1aa2b 
Switched the order of arguments for strictEqual checks inside of
test/paralell/test-http2-binding.js

PR-URL: #24616
Refs: nodejsjp#1
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@dominikeinkemmer @refack
test: fix http2-binding strictEqual order
58df0fa 
Switched the order of arguments for strictEqual checks inside of
test/paralell/test-http2-binding.js

PR-URL: nodejs#24616
Refs: nodejsjp#1
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 11, 2019
@dominikeinkemmer @BethGriggs
test: fix http2-binding strictEqual order
ec70330 
Switched the order of arguments for strictEqual checks inside of
test/paralell/test-http2-binding.js

PR-URL: #24616
Refs: nodejsjp#1
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@dominikeinkemmer @rvagg
test: fix http2-binding strictEqual order
98c0fac 
Switched the order of arguments for strictEqual checks inside of
test/paralell/test-http2-binding.js

PR-URL: #24616
Refs: nodejsjp#1
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@dominikeinkemmer @gireeshpunathil @Trott @addaleax @targos @cjihrig @joyeecheung @BethGriggs @nodejs-github-bot