Skip to content

Commit

Permalink
test: fix http2-binding strictEqual order
Browse files Browse the repository at this point in the history
Switched the order of arguments for strictEqual checks inside of
test/paralell/test-http2-binding.js

PR-URL: #24616
Refs: nodejsjp#1
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
  • Loading branch information
dominikeinkemmer authored and BethGriggs committed Feb 11, 2019
1 parent 7b09602 commit ec70330
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions test/parallel/test-http2-binding.js
Original file line number Diff line number Diff line change
Expand Up @@ -231,16 +231,16 @@ const defaultSettings = {

for (const name of Object.keys(constants)) {
if (name.startsWith('HTTP_STATUS_')) {
assert.strictEqual(expectedStatusCodes[name], constants[name],
assert.strictEqual(constants[name], expectedStatusCodes[name],
`Expected status code match for ${name}`);
} else if (name.startsWith('HTTP2_HEADER_')) {
assert.strictEqual(expectedHeaderNames[name], constants[name],
assert.strictEqual(constants[name], expectedHeaderNames[name],
`Expected header name match for ${name}`);
} else if (name.startsWith('NGHTTP2_')) {
assert.strictEqual(expectedNGConstants[name], constants[name],
assert.strictEqual(constants[name], expectedNGConstants[name],
`Expected ng constant match for ${name}`);
} else if (name.startsWith('DEFAULT_SETTINGS_')) {
assert.strictEqual(defaultSettings[name], constants[name],
assert.strictEqual(constants[name], defaultSettings[name],
`Expected default setting match for ${name}`);
}
}

0 comments on commit ec70330

Please sign in to comment.