New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade to c-ares v1.15.0 #23854

Closed

bnoordhuis wants to merge 4 commits into nodejs:master from bnoordhuis:update-cares

Member

bnoordhuis commented Oct 24, 2018 •

edited

Loading

~~CI: https://ci.nodejs.org/job/node-test-pull-request/18116/~~
CI: https://ci.nodejs.org/job/node-test-pull-request/18119/

bnoordhuis added 3 commits

October 24, 2018 16:53


          deps: remove old c-ares configure files

Remove leftover files that were added in commit 58e4eda from 2013
to help with standalone builds of the c-ares fork that we maintained
at the time.


          deps: upgrade to c-ares v1.15.0

fca9536

Our out-of-tree patch from 2b6bb9f ("deps: c-ares float, win ipv6 bad
fec0 prefix") should no longer be necessary, c-ares now blacklists such
addresses itself.


          deps: c-ares float, version number patch

aaa3017

Not yet upstream.

Refs: c-ares/c-ares#229

Collaborator

nodejs-github-bot commented Oct 24, 2018

@bnoordhuis build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1358/pipeline

nodejs-github-bot added build cares labels

Contributor

refack commented Oct 24, 2018

Probably should remove:

node/deps/cares/cares.gyp

Line 38 in aaa3017

'common.gypi',


          squash

refack approved these changes

View reviewed changes

Contributor

refack left a comment •

edited

Loading

gyp changes LGTM
RSLGTM on c-ares bump

cjihrig approved these changes

View reviewed changes

Member Author

bnoordhuis commented Oct 26, 2018 •

edited

Loading

CI once more: https://ci.nodejs.org/job/node-test-pull-request/18178/ (edit: green)

Previous one had a couple of (what are probably) flakes.

Member

Trott commented Nov 6, 2018

Any reason this shouldn't land? Seems ready to go. (Should it land as one, two, or three separate commits?)

Member

addaleax commented Nov 6, 2018

Landed in aa82a21...7b1297d

addaleax closed this

addaleax mentioned this pull request

dns: support cares_search for resolution #22226

Closed

4 tasks

addaleax pushed a commit that referenced this pull request


          deps: remove old c-ares configure files

50f951c

Remove leftover files that were added in commit 58e4eda from 2013
to help with standalone builds of the c-ares fork that we maintained
at the time.

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

addaleax pushed a commit that referenced this pull request


          deps: upgrade to c-ares v1.15.0

3a25b17

Our out-of-tree patch from 2b6bb9f ("deps: c-ares float, win ipv6 bad
fec0 prefix") should no longer be necessary, c-ares now blacklists such
addresses itself.

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

addaleax pushed a commit that referenced this pull request


          deps: c-ares float, version number patch

7b1297d

Not yet upstream.

Refs: c-ares/c-ares#229

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

targos pushed a commit that referenced this pull request


          deps: remove old c-ares configure files

eaea90b

Remove leftover files that were added in commit 58e4eda from 2013
to help with standalone builds of the c-ares fork that we maintained
at the time.

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

targos pushed a commit that referenced this pull request


          deps: upgrade to c-ares v1.15.0

Our out-of-tree patch from 2b6bb9f ("deps: c-ares float, win ipv6 bad
fec0 prefix") should no longer be necessary, c-ares now blacklists such
addresses itself.

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

targos pushed a commit that referenced this pull request


          deps: c-ares float, version number patch

6b697d4

Not yet upstream.

Refs: c-ares/c-ares#229

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

BridgeAR mentioned this pull request

Release proposal: v11.2 #24350

Merged

This was referenced Nov 15, 2018

2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#232

Closed

2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-android-nodejs#249

Closed

2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#233

Closed

2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#234

Closed

2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#235

Closed

2018-11-15 Version 11.2.0 (Current) @BridgeAR beevelop/docker-nodejs#236

Closed

codebytere pushed a commit that referenced this pull request


          deps: remove old c-ares configure files

a9e3de9

Remove leftover files that were added in commit 58e4eda from 2013
to help with standalone builds of the c-ares fork that we maintained
at the time.

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

codebytere added the land-on-v10.x label

codebytere pushed a commit that referenced this pull request


          deps: upgrade to c-ares v1.15.0

becafe7

Our out-of-tree patch from 2b6bb9f ("deps: c-ares float, win ipv6 bad
fec0 prefix") should no longer be necessary, c-ares now blacklists such
addresses itself.

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

codebytere pushed a commit that referenced this pull request


          deps: c-ares float, version number patch

0c7f4f1

Not yet upstream.

Refs: c-ares/c-ares#229

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins pushed a commit that referenced this pull request


          deps: remove old c-ares configure files

4eaab7c

Remove leftover files that were added in commit 58e4eda from 2013
to help with standalone builds of the c-ares fork that we maintained
at the time.

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins pushed a commit that referenced this pull request


          deps: upgrade to c-ares v1.15.0

209b1d5

Our out-of-tree patch from 2b6bb9f ("deps: c-ares float, win ipv6 bad
fec0 prefix") should no longer be necessary, c-ares now blacklists such
addresses itself.

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins pushed a commit that referenced this pull request


          deps: c-ares float, version number patch

d89bae8

Not yet upstream.

Refs: c-ares/c-ares#229

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

codebytere mentioned this pull request

v10.14.2 proposal #24727

Merged

MylesBorins pushed a commit that referenced this pull request


          deps: remove old c-ares configure files

2e4ef5b

Remove leftover files that were added in commit 58e4eda from 2013
to help with standalone builds of the c-ares fork that we maintained
at the time.

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins pushed a commit that referenced this pull request


          deps: upgrade to c-ares v1.15.0

52afdae

Our out-of-tree patch from 2b6bb9f ("deps: c-ares float, win ipv6 bad
fec0 prefix") should no longer be necessary, c-ares now blacklists such
addresses itself.

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins pushed a commit that referenced this pull request


          deps: c-ares float, version number patch

c8b018f

Not yet upstream.

Refs: c-ares/c-ares#229

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins pushed a commit that referenced this pull request


          2018-12-11, Version 10.14.2 'Dubnium' (LTS)

Notable changes:

* deps:
  * upgrade to c-ares v1.15.0 (Ben Noordhuis)
    #23854
* Windows:
  * A crashing process will now show the names of stack frames if the node.pdb
    file is available. (Refael Ackermann)
    #23822
* Added new collaborators:
  * Peter Marshall. #24170
  * Masashi Hirano. #24136

PR-URL: #24727

MylesBorins pushed a commit that referenced this pull request


          2018-12-11, Version 10.14.2 'Dubnium' (LTS)

6c6c563

Notable changes:

* deps:
  * upgrade to c-ares v1.15.0 (Ben Noordhuis)
    #23854
* Windows:
  * A crashing process will now show the names of stack frames if the node.pdb
    file is available. (Refael Ackermann)
    #23822
* Added new collaborators:
  * Peter Marshall. #24170
  * Masashi Hirano. #24136

PR-URL: #24727

refack pushed a commit to refack/node that referenced this pull request


          2018-12-11, Version 10.14.2 'Dubnium' (LTS)

a2fa589

Notable changes:

* deps:
  * upgrade to c-ares v1.15.0 (Ben Noordhuis)
    nodejs#23854
* Windows:
  * A crashing process will now show the names of stack frames if the node.pdb
    file is available. (Refael Ackermann)
    nodejs#23822
* Added new collaborators:
  * Peter Marshall. nodejs#24170
  * Masashi Hirano. nodejs#24136

PR-URL: nodejs#24727

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels