Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ares_version.h not updated in 1.15.0 #229

Closed
bnoordhuis opened this issue Oct 24, 2018 · 2 comments
Closed

ares_version.h not updated in 1.15.0 #229

bnoordhuis opened this issue Oct 24, 2018 · 2 comments

Comments

@bnoordhuis
Copy link
Contributor

It looks like this was forgotten? Building from source with cmake, ares_version() returns "1.14.0".

@bagder
Copy link
Member

bagder commented Oct 24, 2018

Right, because maketgz updates it when the release tarball is made so it isn't getting pushed back to git...

The copyright range is wrong too btw.

bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue Oct 24, 2018
bradh352 pushed a commit that referenced this issue Nov 1, 2018
Version change not committed from maketgz.sh

Bug: #229
@bradh352
Copy link
Member

bradh352 commented Nov 1, 2018

fixed in #230

@bradh352 bradh352 closed this as completed Nov 1, 2018
addaleax pushed a commit to nodejs/node that referenced this issue Nov 6, 2018
Not yet upstream.

Refs: c-ares/c-ares#229

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit to nodejs/node that referenced this issue Nov 6, 2018
Not yet upstream.

Refs: c-ares/c-ares#229

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
codebytere pushed a commit to nodejs/node that referenced this issue Nov 29, 2018
Not yet upstream.

Refs: c-ares/c-ares#229

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit to nodejs/node that referenced this issue Nov 29, 2018
Not yet upstream.

Refs: c-ares/c-ares#229

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit to nodejs/node that referenced this issue Dec 3, 2018
Not yet upstream.

Refs: c-ares/c-ares#229

PR-URL: #23854
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
DronRathore pushed a commit to DronRathore/c-ares that referenced this issue Mar 11, 2020
Version change not committed from maketgz.sh

Bug: c-ares#229
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants