test: remove skip of OS X bug #22546
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Three tests are skipped because of Applie bug 17894467. That bug exists in OS X 10.10, but we no longer support 10.10 (and neither does Apple). Remove the test-skipping.
lpinca
approved these changes
Aug 27, 2018
lpinca
added
the
author ready
thefourtheye
approved these changes
Aug 27, 2018
|
Resume Build: https://ci.nodejs.org/job/node-test-pull-request/16776/ |
danbev
approved these changes
Aug 27, 2018
trivikr
approved these changes
Aug 27, 2018
cjihrig
approved these changes
Aug 27, 2018
BridgeAR
approved these changes
Aug 27, 2018
jasnell
approved these changes
Aug 27, 2018
|
Resume Build: https://ci.nodejs.org/job/node-test-pull-request/16790/ |
|
Resume Build: https://ci.nodejs.org/job/node-test-pull-request/16817/ |
|
Landed in 8e18979 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Aug 31, 2018
Three tests are skipped because of Applie bug 17894467. That bug exists in OS X 10.10, but we no longer support 10.10 (and neither does Apple). Remove the test-skipping. PR-URL: nodejs#22546 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three tests are skipped because of Apple bug 17894467. That bug exists
in OS X 10.10, but we no longer support 10.10 (and neither does Apple).
Remove the test-skipping.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes