Skip to content

Commit

Permalink
test: remove skip of OS X bug
Browse files Browse the repository at this point in the history
Three tests are skipped because of Applie bug 17894467. That bug exists
in OS X 10.10, but we no longer support 10.10 (and neither does Apple).
Remove the test-skipping.

PR-URL: nodejs#22546
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
Trott committed Aug 31, 2018
1 parent 366ffdc commit 8e18979
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 7 deletions.
3 changes: 0 additions & 3 deletions test/parallel/test-dgram-send-empty-array.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@

const common = require('../common');

if (common.isOSX)
common.skip('because of 17894467 Apple bug');

const assert = require('assert');
const dgram = require('dgram');

Expand Down
2 changes: 0 additions & 2 deletions test/parallel/test-dgram-send-empty-buffer.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@

'use strict';
const common = require('../common');
if (common.isOSX)
common.skip('because of 17894467 Apple bug');

const assert = require('assert');
const dgram = require('dgram');
Expand Down
2 changes: 0 additions & 2 deletions test/parallel/test-dgram-send-empty-packet.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
'use strict';
const common = require('../common');
if (common.isOSX)
common.skip('because of 17894467 Apple bug');

const assert = require('assert');
const dgram = require('dgram');
Expand Down

0 comments on commit 8e18979

Please sign in to comment.