Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v8.x backport] test: remove --harmony-sharedarraybuffer usage #21717

Closed

Conversation

BethGriggs
Copy link
Member

This flag has been enabled by default since v8
7662e0634c3a057fa5d746912ee5af76e285c274.

PR-URL: #16343
Reviewed-By: Jeremiah Senkpiel fishrock123@rocketmail.com
Reviewed-By: Anna Henningsen anna@addaleax.net
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: Anatoli Papirovski apapirovski@mac.com
Reviewed-By: Michaël Zasso targos@protonmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Joyee Cheung joyeec9h3@gmail.com
Reviewed-By: Timothy Gu timothygu99@gmail.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Backport, as requested, of #16343

This flag has been enabled by default since v8
7662e0634c3a057fa5d746912ee5af76e285c274.

PR-URL: nodejs#16343
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. v8.x labels Jul 9, 2018
@addaleax
Copy link
Member

addaleax commented Jul 9, 2018

@addaleax
Copy link
Member

Landed in 4be5252

@addaleax addaleax closed this Jul 11, 2018
addaleax pushed a commit that referenced this pull request Jul 11, 2018
This flag has been enabled by default since v8
7662e0634c3a057fa5d746912ee5af76e285c274.

Backport-PR-URL: #21717
PR-URL: #16343
Reviewed-By: Anna Henningsen <anna@addaleax.net>
rvagg pushed a commit that referenced this pull request Aug 16, 2018
This flag has been enabled by default since v8
7662e0634c3a057fa5d746912ee5af76e285c274.

Backport-PR-URL: #21717
PR-URL: #16343
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BethGriggs BethGriggs deleted the backport-16343-to-v8.x branch June 11, 2019 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants