Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove --harmony-sharedarraybuffer usage #16343

Closed
wants to merge 1 commit into from
Closed

test: remove --harmony-sharedarraybuffer usage #16343

wants to merge 1 commit into from

Conversation

binji
Copy link
Contributor

@binji binji commented Oct 20, 2017

This flag has been enabled by default since v8 6.2.81.

Refs: v8/v8@7662e06

Checklist
Affected core subsystem(s)

test

@binji
test: Remove --harmony-sharedarraybuffer usage
11cf27c 
This flag has been enabled by default since v8
7662e0634c3a057fa5d746912ee5af76e285c274.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 20, 2017
@binji binji mentioned this pull request Oct 20, 2017
Closed
Fishrock123
Fishrock123 approved these changes Oct 20, 2017
View reviewed changes
Copy link
Contributor

@Fishrock123 Fishrock123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI: https://ci.nodejs.org/job/node-test-pull-request/10874/

@mscdex mscdex added buffer Issues and PRs related to the buffer subsystem. util Issues and PRs related to the built-in util module. v8 engine Issues and PRs related to the V8 dependency. labels Oct 20, 2017
joyeecheung
joyeecheung approved these changes Oct 21, 2017
View reviewed changes
Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failures are unrelated. I think we can skip the 48-hour wait on this

TimothyGu
TimothyGu approved these changes Oct 21, 2017
View reviewed changes
Copy link
Member

@TimothyGu TimothyGu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@addaleax
Copy link
Member

Landed in 438e7fd, thanks!

@addaleax addaleax closed this Oct 22, 2017
addaleax pushed a commit that referenced this pull request Oct 22, 2017
@binji @addaleax
test: remove --harmony-sharedarraybuffer usage
438e7fd 
This flag has been enabled by default since v8
7662e0634c3a057fa5d746912ee5af76e285c274.

PR-URL: #16343
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
@binji binji deleted the remove-sab-flag branch October 22, 2017 16:52
@MylesBorins
Copy link
Contributor

This shouldn't land on 8.x until 6.2 is backported.

@targos we should include this in the backport PR

addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 26, 2017
@binji @addaleax
test: remove --harmony-sharedarraybuffer usage
c89b6b9 
This flag has been enabled by default since v8
7662e0634c3a057fa5d746912ee5af76e285c274.

PR-URL: nodejs/node#16343
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
@jasnell jasnell mentioned this pull request Oct 30, 2017
Merged
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@binji @addaleax
test: remove --harmony-sharedarraybuffer usage
c286c3f 
This flag has been enabled by default since v8
7662e0634c3a057fa5d746912ee5af76e285c274.

PR-URL: nodejs/node#16343
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
BethGriggs pushed a commit to BethGriggs/node that referenced this pull request Jul 9, 2018
@binji @BethGriggs
test: remove --harmony-sharedarraybuffer usage
a949a7b 
This flag has been enabled by default since v8
7662e0634c3a057fa5d746912ee5af76e285c274.

PR-URL: nodejs#16343
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Jul 9, 2018
Closed
2 tasks
addaleax pushed a commit that referenced this pull request Jul 11, 2018
@binji @addaleax
test: remove --harmony-sharedarraybuffer usage
4be5252 
This flag has been enabled by default since v8
7662e0634c3a057fa5d746912ee5af76e285c274.

Backport-PR-URL: #21717
PR-URL: #16343
Reviewed-By: Anna Henningsen <anna@addaleax.net>
rvagg pushed a commit that referenced this pull request Aug 16, 2018
@binji @rvagg
test: remove --harmony-sharedarraybuffer usage
ed0d939 
This flag has been enabled by default since v8
7662e0634c3a057fa5d746912ee5af76e285c274.

Backport-PR-URL: #21717
PR-URL: #16343
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins mentioned this pull request Aug 16, 2018
Merged
This was referenced May 13, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@lpinca lpinca lpinca approved these changes

@Fishrock123 Fishrock123 Fishrock123 approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@apapirovski apapirovski apapirovski approved these changes

Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. test Issues and PRs related to the tests. util Issues and PRs related to the built-in util module. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.