Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v8.x backport] n-api: take n-api out of experimental #21083

Closed
wants to merge 1 commit into from

Conversation

mhdawson
Copy link
Member

@mhdawson mhdawson commented Jun 1, 2018

Take n-api out of experimental as per:
nodejs/TSC#501

PR-URL: #19262
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: Michaël Zasso targos@protonmail.com
Reviewed-By: Gus Caplan me@gus.host
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Franziska Hinkelmann franziska.hinkelmann@gmail.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Take n-api out of experimental as per:
nodejs/TSC#501

PR-URL: nodejs#19262
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. v8.x labels Jun 1, 2018
@devsnek
Copy link
Member

devsnek commented Jun 1, 2018

can you mention somewhere that it's a backport to 8.x? I was really confused seeing this.

@lance lance changed the title n-api: take n-api out of experimental [v8.x backport] n-api: take n-api out of experimental Jun 1, 2018
@nodejs nodejs deleted a comment from refack Jun 1, 2018
@mhdawson mhdawson added the semver-minor PRs that contain new features and should be released in the next minor version. label Jun 6, 2018
@mhdawson
Copy link
Member Author

mhdawson commented Jun 6, 2018

@mhdawson
Copy link
Member Author

mhdawson commented Jun 7, 2018

Looks like freeBSD is likely: #19311
Opened #21188 for unrelated windows issue

Both of which are unrelated but one more CI run to be sure: https://ci.nodejs.org/job/node-test-pull-request/15313/

@mhdawson
Copy link
Member Author

mhdawson commented Jun 7, 2018

Sole failure in second CI run was known issue #18254.

CI looks good going to land.

mhdawson added a commit that referenced this pull request Jun 7, 2018
Take n-api out of experimental as per:
nodejs/TSC#501

Backport-PR-URL: #21083
PR-URL: #19262
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@mhdawson
Copy link
Member Author

mhdawson commented Jun 7, 2018

Landed as 084ef60

@mhdawson mhdawson closed this Jun 7, 2018
MylesBorins pushed a commit that referenced this pull request Jun 14, 2018
Take n-api out of experimental as per:
nodejs/TSC#501

Backport-PR-URL: #21083
PR-URL: #19262
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
rvagg pushed a commit that referenced this pull request Aug 16, 2018
Take n-api out of experimental as per:
nodejs/TSC#501

Backport-PR-URL: #21083
PR-URL: #19262
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@mhdawson mhdawson deleted the napi8xbackport branch September 30, 2019 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants