Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows intermittent ? - parallel/test-timers-throw-reschedule #21188

Closed
mhdawson opened this issue Jun 7, 2018 · 5 comments
Closed

Windows intermittent ? - parallel/test-timers-throw-reschedule #21188

mhdawson opened this issue Jun 7, 2018 · 5 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.

Comments

@mhdawson
Copy link
Member

mhdawson commented Jun 7, 2018

  • Version: v8.x-staging
  • Platform: Windows
  • Subsystem: timer

https://ci.nodejs.org/job/node-test-binary-windows/17851/COMPILED_BY=vs2015-x86,RUNNER=win2012r2,RUN_SUBSET=2/console

not ok 387 parallel/test-timers-throw-reschedule
  ---
  duration_ms: 0.400
  severity: fail
  stack: |-
    assert.js:42
      throw new errors.AssertionError({
      ^
    
    AssertionError [ERR_ASSERTION]: false == true
        at Timeout.common.mustCall (c:\workspace\node-test-binary-windows\test\parallel\test-timers-throw-reschedule.js:20:5)
        at Timeout._onTimeout (c:\workspace\node-test-binary-windows\test\common\index.js:478:15)
        at ontimeout (timers.js:498:11)
        at Timer.unrefdHandle (timers.js:611:5)
  ...
@apapirovski
Copy link
Member

That test probably shouldn't be in parallel tbh. If someone wants to open a PR to move it to sequential on v8.x then that would be great.

@apapirovski apapirovski added timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Jun 7, 2018
@maclover7
Copy link
Contributor

This is failing now on linuxone on v8.x:

06:03:31 not ok 1555 parallel/test-timers-throw-reschedule
06:03:31   ---
06:03:31   duration_ms: 0.366
06:03:31   severity: fail
06:03:31   stack: |-
06:03:31     assert.js:42
06:03:31       throw new errors.AssertionError({
06:03:31       ^
06:03:31     
06:03:31     AssertionError [ERR_ASSERTION]: false == true
06:03:31         at Timeout.common.mustCall (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/parallel/test-timers-throw-reschedule.js:20:5)
06:03:31         at Timeout._onTimeout (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/common/index.js:478:15)
06:03:31         at ontimeout (timers.js:498:11)
06:03:31         at Timer.unrefdHandle (timers.js:611:5)
06:03:31   ...

@MylesBorins
Copy link
Contributor

MylesBorins commented Aug 17, 2018

Attempted to move to sequential and still feeing failures on linuxon

17:04:45 not ok 2153 sequential/test-timers-throw-reschedule
17:04:45   ---
17:04:45   duration_ms: 0.213
17:04:45   severity: fail
17:04:45   exitcode: 1
17:04:45   stack: |-
17:04:45     assert.js:42
17:04:45       throw new errors.AssertionError({
17:04:45       ^
17:04:45     
17:04:45     AssertionError [ERR_ASSERTION]: false == true
17:04:45         at Timeout.common.mustCall (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/sequential/test-timers-throw-reschedule.js:20:5)
17:04:45         at Timeout._onTimeout (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/common/index.js:478:15)
17:04:45         at ontimeout (timers.js:498:11)
17:04:45         at Timer.unrefdHandle (timers.js:611:5)
17:04:45   ...

https://ci.nodejs.org/job/node-test-commit-linuxone/4061/nodes=rhel72-s390x/console

/cc @nodejs/timers can someone please help out with this? Potentially blocking release

Edit: I've got a PR moving the test to sequential and marking it flaky... #22379

we should not close this issue until we figure out how to unflake the test

MylesBorins added a commit to MylesBorins/node that referenced this issue Aug 17, 2018
MylesBorins added a commit that referenced this issue Aug 17, 2018
This also sets the test as flaky

PR-URL: #22379
Refs: #21188
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@MylesBorins
Copy link
Contributor

this is showing up again in #23774

have no clue why it is not showing up as flaky

@BridgeAR
Copy link
Member

BridgeAR commented Jan 2, 2020

Node.js v8.x has reached the end-of-life and won't receive any fixes anymore. I am closing this since this issue seems to only apply to Node.js v8.x.

@BridgeAR BridgeAR closed this as completed Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Development

No branches or pull requests

5 participants