fs: refactor fs module #20764

jasnell · 2018-05-16T03:54:29Z

Fairly sizable structural refactoring of the fs module. It moves several pieces out into separate submodules that are lazy-loaded, switches the use the module.exports = {} pattern in a way that preserves the ability to monkeypatch, and uses const/let more consistently.

The changes are intended to be squashed down into a single commit when landing but are separated out for easier review.

#20735 should likely land first.

~~defensively semver-major.~~ CITGM looks good, graceful-fs still appears to work as expected... so this can be semver-patch. woohoo!

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

jasnell · 2018-05-16T03:55:56Z

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/193/
CI: https://ci.nodejs.org/job/node-test-pull-request/14897/

joyeecheung · 2018-05-16T04:09:24Z

lib/fs.js

+  callback = maybeCallback(callback || options);
+  options = getOptions(options, { flag: 'r' });
+  if (!ReadFileContext)
+    ReadFileContext = require('internal/fs/readfilecontext');


I believe we use underscores in file names, can you rename this to read_file_context?

Given that the object name is ReadFileContext without any separation, I'd prefer not to, but can.

joyeecheung · 2018-05-16T04:11:00Z

lib/fs.js

  }

-  callback(null, buffer);
+  path = getPathFromURL(path);


Can you validate the path before instantiating the req wrap?

Actually, no, not currently. Note the condition immediately before this, moving the validatePath up would be a breaking behavior change without some other refactoring in this method that is best left to a separate more focused PR.

What I will do for sure, tho, is open that separate PR ;-)

joyeecheung · 2018-05-16T04:14:43Z

lib/fs.js

@@ -1424,6 +1204,8 @@ fs.watch = function(filename, options, listener) {
  if (options.persistent === undefined) options.persistent = true;
  if (options.recursive === undefined) options.recursive = false;

+  if (!FSWatcher)
+    ({ FSWatcher } = require('internal/fs/watchers'));


Not really opposed to this way of using destructuring but it does look a bit odd..if the watchers and streams don't share enough code to be in the same file, maybe just split them into different files, like internal/fs/event_watcher for FSWatcher and internal/fs/poll_watcher for StatWatcher? (event/poll is how I differentiate them but using their underscored names is good as well)

I'll change the assignments. I'd like to hold off on splitting StatWatcher and FSWatcher into separate files because I'd like to explore a simplification that could allow them to share code. If it ends up not making sense, I'll split them out in a separate PR.

ChALkeR · 2018-05-16T04:27:46Z

that are lazy-loaded

How does that play with --trace-sync-io?
I suppose that it should work fine, given that modules are embedded, asking just to be sure.

jasnell · 2018-05-16T04:38:32Z

How does that play with --trace-sync-io

Zero impact here. No change in behavior relative to --trace-sync-io

joyeecheung · 2018-05-16T04:50:17Z

There is actually a test test-sync-io-option(only tests readFileSync but since almost all the sync calls go through the same template function in the end so it probably is fine) so we should be good as long as it's green.

jasnell · 2018-05-16T04:57:52Z

CI is green.

targos · 2018-05-16T05:06:36Z

We should try to make sure this can be sever-patch. I'm afraid otherwise about all the backports that will be necessary

jasnell · 2018-05-16T05:13:34Z

@targos ... it should be able to be semver-patch. I'd like to get a CITGM run in on it to verify that, however, before we reduce the tag.

jasnell · 2018-05-16T14:04:15Z

benchmark results:

                                                                                  confidence improvement accuracy (*)    (**)   (***)
 fs/bench-readdir.js n=10000                                                                     -1.18 %       ±8.44% ±11.22% ±14.61%
 fs/bench-readdirSync.js n=10000                                                                 -3.04 %       ±3.11%  ±4.16%  ±5.46%
 fs/bench-realpath.js pathType='relative' n=10000                                                 2.08 %       ±4.50%  ±5.99%  ±7.81%
 fs/bench-realpath.js pathType='resolved' n=10000                                          *     -4.80 %       ±3.63%  ±4.83%  ±6.29%
 fs/bench-realpathSync.js pathType='relative' n=10000                                            -2.03 %       ±5.34%  ±7.11%  ±9.26%
 fs/bench-realpathSync.js pathType='resolved' n=10000                                             0.72 %       ±3.50%  ±4.68%  ±6.14%
 fs/bench-stat.js statType='fstat' n=200000                                                      -1.05 %       ±4.32%  ±5.76%  ±7.51%
 fs/bench-stat.js statType='lstat' n=200000                                                      -0.09 %       ±5.23%  ±6.96%  ±9.06%
 fs/bench-stat.js statType='stat' n=200000                                                        1.32 %       ±5.67%  ±7.55%  ±9.84%
 fs/bench-stat-promise.js statType='fstat' n=200000                                               1.09 %       ±3.58%  ±4.77%  ±6.21%
 fs/bench-stat-promise.js statType='lstat' n=200000                                               0.89 %       ±3.60%  ±4.79%  ±6.24%
 fs/bench-stat-promise.js statType='stat' n=200000                                                1.71 %       ±3.51%  ±4.68%  ±6.09%
 fs/bench-statSync.js statSyncType='fstatSync' n=1000000                                          3.59 %       ±4.09%  ±5.48%  ±7.21%
 fs/bench-statSync.js statSyncType='lstatSync' n=1000000                                         -2.20 %       ±2.57%  ±3.43%  ±4.47%
 fs/bench-statSync.js statSyncType='statSync' n=1000000                                           1.07 %       ±2.45%  ±3.26%  ±4.24%
 fs/readfile.js concurrent=10 len=1024 dur=5                                                      8.55 %       ±9.77% ±13.00% ±16.92%
 fs/readfile.js concurrent=10 len=16777216 dur=5                                         ***     -8.42 %       ±3.93%  ±5.24%  ±6.85%
 fs/readfile.js concurrent=1 len=1024 dur=5                                                      -1.75 %       ±4.44%  ±5.91%  ±7.70%
 fs/readfile.js concurrent=1 len=16777216 dur=5                                                  -0.36 %       ±6.35%  ±8.46% ±11.02%
 fs/readfile-partitioned.js concurrent=10 len=1024 dur=5                                          0.41 %       ±3.37%  ±4.49%  ±5.85%
 fs/readfile-partitioned.js concurrent=10 len=16777216 dur=5                                     -1.90 %       ±3.76%  ±5.01%  ±6.52%
 fs/readfile-partitioned.js concurrent=1 len=1024 dur=5                                           0.76 %       ±6.62%  ±8.81% ±11.48%
 fs/readfile-partitioned.js concurrent=1 len=16777216 dur=5                                      -3.31 %       ±4.42%  ±5.89%  ±7.66%
 fs/readFileSync.js n=600000                                                                      0.99 %       ±7.65% ±10.20% ±13.29%
 fs/read-stream-throughput.js size=1024 filesize=1048576000 encodingType='asc'                   -2.55 %       ±3.17%  ±4.22%  ±5.49%
 fs/read-stream-throughput.js size=1024 filesize=1048576000 encodingType='buf'                    1.52 %       ±3.32%  ±4.42%  ±5.76%
 fs/read-stream-throughput.js size=1024 filesize=1048576000 encodingType='utf'                   -0.50 %       ±3.31%  ±4.41%  ±5.74%
 fs/read-stream-throughput.js size=1048576 filesize=1048576000 encodingType='asc'                -1.88 %       ±3.84%  ±5.12%  ±6.69%
 fs/read-stream-throughput.js size=1048576 filesize=1048576000 encodingType='buf'                 1.55 %       ±7.86% ±10.52% ±13.82%
 fs/read-stream-throughput.js size=1048576 filesize=1048576000 encodingType='utf'                -1.87 %      ±10.66% ±14.18% ±18.46%
 fs/read-stream-throughput.js size=4096 filesize=1048576000 encodingType='asc'                    4.65 %       ±6.62%  ±8.88% ±11.69%
 fs/read-stream-throughput.js size=4096 filesize=1048576000 encodingType='buf'                    0.57 %       ±3.57%  ±4.75%  ±6.20%
 fs/read-stream-throughput.js size=4096 filesize=1048576000 encodingType='utf'                    5.11 %       ±7.88% ±10.51% ±13.71%
 fs/read-stream-throughput.js size=65535 filesize=1048576000 encodingType='asc'                   1.88 %       ±7.63% ±10.15% ±13.21%
 fs/read-stream-throughput.js size=65535 filesize=1048576000 encodingType='buf'            *      6.12 %       ±5.32%  ±7.07%  ±9.21%
 fs/read-stream-throughput.js size=65535 filesize=1048576000 encodingType='utf'                  -0.88 %       ±9.02% ±12.00% ±15.63%
 fs/write-stream-throughput.js size=1024 encodingType='asc' dur=5                                 2.34 %       ±7.61% ±10.12% ±13.18%
 fs/write-stream-throughput.js size=1024 encodingType='buf' dur=5                                 1.55 %      ±11.31% ±15.04% ±19.58%
 fs/write-stream-throughput.js size=1024 encodingType='utf' dur=5                                 4.11 %       ±7.83% ±10.45% ±13.66%
 fs/write-stream-throughput.js size=1048576 encodingType='asc' dur=5                              1.11 %       ±2.27%  ±3.03%  ±3.96%
 fs/write-stream-throughput.js size=1048576 encodingType='buf' dur=5                            -17.01 %      ±28.14% ±37.43% ±48.72%
 fs/write-stream-throughput.js size=1048576 encodingType='utf' dur=5                             -2.79 %       ±3.59%  ±4.78%  ±6.23%
 fs/write-stream-throughput.js size=2 encodingType='asc' dur=5                           ***     29.48 %      ±12.94% ±17.22% ±22.43%
 fs/write-stream-throughput.js size=2 encodingType='buf' dur=5                                    1.98 %       ±3.82%  ±5.08%  ±6.61%
 fs/write-stream-throughput.js size=2 encodingType='utf' dur=5                                    6.97 %      ±12.73% ±16.95% ±22.07%
 fs/write-stream-throughput.js size=65535 encodingType='asc' dur=5                                7.98 %      ±12.30% ±16.37% ±21.31%
 fs/write-stream-throughput.js size=65535 encodingType='buf' dur=5                       ***     24.50 %      ±13.44% ±17.88% ±23.28%
 fs/write-stream-throughput.js size=65535 encodingType='utf' dur=5                               -1.22 %      ±11.31% ±15.04% ±19.58%

Be aware that when doing many comparisions the risk of a false-positive
result increases. In this case there are 48 comparisions, you can thus
expect the following amount of false-positive results:
  2.40 false positives, when considering a   5% risk acceptance (*, **, ***),
  0.48 false positives, when considering a   1% risk acceptance (**, ***),
  0.05 false positives, when considering a 0.1% risk acceptance (***)
Notifying upstream projects of job completion

jasnell · 2018-05-16T14:05:41Z

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1412/

jasnell · 2018-05-16T14:25:39Z

Ugh... looks like graceful-fs is breaking on this...

44 verbose stack RangeError: Maximum call stack size exceeded
44 verbose stack     at Function.[Symbol.hasInstance] (<anonymous>)
44 verbose stack     at WriteStream (/home/james/.nvm/versions/node/v9.11.1/lib/node_modules/npm/node_modules/graceful-fs/graceful-fs.js:200:14)
44 verbose stack     at WriteStream (/home/james/.nvm/versions/node/v9.11.1/lib/node_modules/npm/node_modules/graceful-fs/graceful-fs.js:201:29)
44 verbose stack     at WriteStream (/home/james/.nvm/versions/node/v9.11.1/lib/node_modules/npm/node_modules/graceful-fs/graceful-fs.js:201:29)
44 verbose stack     at WriteStream (/home/james/.nvm/versions/node/v9.11.1/lib/node_modules/npm/node_modules/graceful-fs/graceful-fs.js:201:29)
44 verbose stack     at WriteStream (/home/james/.nvm/versions/node/v9.11.1/lib/node_modules/npm/node_modules/graceful-fs/graceful-fs.js:201:29)
44 verbose stack     at WriteStream (/home/james/.nvm/versions/node/v9.11.1/lib/node_modules/npm/node_modules/graceful-fs/graceful-fs.js:201:29)
44 verbose stack     at WriteStream (/home/james/.nvm/versions/node/v9.11.1/lib/node_modules/npm/node_modules/graceful-fs/graceful-fs.js:201:29)
44 verbose stack     at WriteStream (/home/james/.nvm/versions/node/v9.11.1/lib/node_modules/npm/node_modules/graceful-fs/graceful-fs.js:201:29)
44 verbose stack     at WriteStream (/home/james/.nvm/versions/node/v9.11.1/lib/node_modules/npm/node_modules/graceful-fs/graceful-fs.js:201:29)
44 verbose stack     at WriteStream (/home/james/.nvm/versions/node/v9.11.1/lib/node_modules/npm/node_modules/graceful-fs/graceful-fs.js:201:29)
44 verbose stack     at WriteStream (/home/james/.nvm/versions/node/v9.11.1/lib/node_modules/npm/node_modules/graceful-fs/graceful-fs.js:201:29)
44 verbose stack     at WriteStream (/home/james/.nvm/versions/node/v9.11.1/lib/node_modules/npm/node_modules/graceful-fs/graceful-fs.js:201:29)
44 verbose stack     at WriteStream (/home/james/.nvm/versions/node/v9.11.1/lib/node_modules/npm/node_modules/graceful-fs/graceful-fs.js:201:29)
44 verbose stack     at WriteStream (/home/james/.nvm/versions/node/v9.11.1/lib/node_modules/npm/node_modules/graceful-fs/graceful-fs.js:201:29)
44 verbose stack     at WriteStream (/home/james/.nvm/versions/node/v9.11.1/lib/node_modules/npm/node_modules/graceful-fs/graceful-fs.js:201:29)

benjamingr · 2018-05-16T15:08:45Z

I really appreciate the effort but I think that this would be extremely challenging to properly review :/

Would checking the code out and reviewing an individual file for example help?

jasnell · 2018-05-16T15:13:46Z

Would checking the code out and reviewing an individual file for example help?

Sorry, not following what you're asking here.

jasnell · 2018-05-16T15:18:00Z

graceful-fs failure is caused by the fact that it monkeypatches fs.ReadStream/fs.WriteStream and the legacy aliases fs.FileReadStream/fs.FileWriteStream, but does so in a bit of an ad hoc order. I had attempted to keep the lazy loading simple and just make FileReadStream and FileWriteStream proper aliases, but in order to keep from breaking graceful-fs and support lazy-loading, it needs to be a bit more complicated. Sigh.

jasnell · 2018-05-16T15:22:52Z

New CI: https://ci.nodejs.org/job/node-test-pull-request/14908/
New CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1413/

benjamingr · 2018-05-16T15:39:35Z

Sorry, not following what you're asking here.

If there is a way to help push this without reviewing the whole PR basically.

jasnell · 2018-05-16T15:40:48Z

I would look at each commit separately. They are fairly self contained.

jasnell · 2018-05-16T16:38:15Z

citgm run looks good now. I think we can safely pull the semver-major label back off.

targos · 2018-05-16T16:57:22Z

lib/fs.js

+  lchown: constants.O_SYMLINK !== undefined ? lchown : undefined,
+  lchownSync: constants.O_SYMLINK !== undefined ? lchownSync : undefined,
+  lchmod: constants.O_SYMLINK !== undefined ? lchmod : undefined,
+  lchmodSync: constants.O_SYMLINK !== undefined ? lchmodSync : undefined,


Can we keep the assignment of those properties in a condition? To avoid having them show up in Object.keys(fs) or for..in loops when they are undefined.

We could but I'm actually wanting to open a PR that would make these functions always available but with a change that they would throw on systems where constants.O_SYMLINK is undefined.

targos · 2018-05-16T17:40:24Z

src/node_constants.cc

+# define COPYFILE_EXCL UV_FS_COPYFILE_EXCL
+  NODE_DEFINE_CONSTANT(target, UV_FS_COPYFILE_EXCL);
+  NODE_DEFINE_CONSTANT(target, COPYFILE_EXCL);
+# undef COPYFILE_EXCL


nit: Do we write # define and # undef elsewhere? I'd prefer them without the space.

It's because of the nesting... and there is precedence for it: See https://github.com/nodejs/node/blob/master/src/node.cc#L3072-L3074

jasnell · 2018-05-18T04:15:25Z

New CI after rebase: https://ci.nodejs.org/job/node-test-pull-request/14950/
Re-run on linux-containered due to likely unrelated flaky: https://ci.nodejs.org/job/node-test-commit-linux-containered/4520/
Likewise on freebsd: https://ci.nodejs.org/job/node-test-commit-freebsd/17851/

PR-URL: nodejs#20764 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

PR-URL: #20764 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Backport-PR-URL: #21172

This Pull Request updates dependency [node](https://github.com/nodejs/node) from `v10.4.1` to `v10.5.0` <details> <summary>Release Notes</summary> ### [`v10.5.0`](https://github.com/nodejs/node/releases/v10.5.0) [Compare Source](nodejs/node@v10.4.1...v10.5.0) ##### Notable Changes * **crypto**: * Support for `crypto.scrypt()` has been added. [#20816](`nodejs/node#20816) * **fs**: * BigInt support has been added to `fs.stat` and `fs.watchFile`. [#20220](`nodejs/node#20220) * APIs that take `mode` as arguments no longer throw on values larger than `0o777`. [#20636](`nodejs/node#20636) [#20975](`nodejs/node#20975) (Fixes: [#20498](`nodejs/node#20498)) * Fix crashes in closed event watchers. [#20985](`nodejs/node#20985) (Fixes: [#20297](`nodejs/node#20297)) * **Worker Threads**: * Support for multi-threading has been added behind the `--experimental-worker` flag in the `worker_threads` module. This feature is *experimental* and may receive breaking changes at any time. [#20876](`nodejs/node#20876) ##### Commits * [[`a6986fe8b6`](nodejs/node@a6986fe8b6)] - **async_hooks**: remove deprecated example (Mathias Buus) [#20998](`nodejs/node#20998) * [[`4b9817bf1e`](nodejs/node@4b9817bf1e)] - **benchmark**: disable only the ESLint rule needing it (Rich Trott) [#21133](`nodejs/node#21133) * [[`ecba1c57b1`](nodejs/node@ecba1c57b1)] - **(SEMVER-MINOR)** **benchmark**: port cluster/echo to worker (Timothy Gu) [#20876](`nodejs/node#20876) * [[`02adb2d62c`](nodejs/node@02adb2d62c)] - **(SEMVER-MINOR)** **build**: expose openssl scrypt functions to addons (Ben Noordhuis) [#20816](`nodejs/node#20816) * [[`c3fbac432f`](nodejs/node@c3fbac432f)] - **build**: install markdown linter for travis (Richard Lau) [#21215](`nodejs/node#21215) * [[`896017b134`](nodejs/node@896017b134)] - **build**: build addon tests in parallel (Anna Henningsen) [#21155](`nodejs/node#21155) * [[`76927fc734`](nodejs/node@76927fc734)] - **build**: stop distclean from deleting v8 files (Ujjwal Sharma) [#21164](`nodejs/node#21164) * [[`b044256f2a`](nodejs/node@b044256f2a)] - **build**: use LC\_ALL of C for maximum compatibility (Rich Trott) [#21222](`nodejs/node#21222) * [[`78c7d666fb`](nodejs/node@78c7d666fb)] - **build**: don't change locale on smartos (Refael Ackermann) [#21220](`nodejs/node#21220) * [[`c688a00a6d`](nodejs/node@c688a00a6d)] - **build**: fix 'gas\_version' check on localized environments (Evandro Oliveira) [#20394](`nodejs/node#20394) * [[`79b3423fb5`](nodejs/node@79b3423fb5)] - **build**: initial .travis.yml implementation (Anna Henningsen) [#21059](`nodejs/node#21059) * [[`ea4be72f22`](nodejs/node@ea4be72f22)] - **child_process**: swallow errors in internal communication (Anatoli Papirovski) [#21108](`nodejs/node#21108) * [[`9981220e2a`](nodejs/node@9981220e2a)] - **crypto**: fix behavior of createCipher in wrap mode (Tobias Nießen) [#21287](`nodejs/node#21287) * [[`d0cb9cbb35`](nodejs/node@d0cb9cbb35)] - **(SEMVER-MINOR)** **crypto**: drop Math.pow(), use static exponentation (Ben Noordhuis) [#20816](`nodejs/node#20816) * [[`2d9c3cc89d`](nodejs/node@2d9c3cc89d)] - **(SEMVER-MINOR)** **crypto**: refactor randomBytes() (Ben Noordhuis) [#20816](`nodejs/node#20816) * [[`6262fa44d6`](nodejs/node@6262fa44d6)] - **(SEMVER-MINOR)** **crypto**: refactor pbkdf2() and pbkdf2Sync() methods (Ben Noordhuis) [#20816](`nodejs/node#20816) * [[`c9b4592dbf`](nodejs/node@c9b4592dbf)] - **(SEMVER-MINOR)** **crypto**: add scrypt() and scryptSync() methods (Ben Noordhuis) [#20816](`nodejs/node#20816) * [[`495756264a`](nodejs/node@495756264a)] - **(SEMVER-MINOR)** **crypto**: DRY type checking (Ben Noordhuis) [#20816](`nodejs/node#20816) * [[`e4a7e0d28b`](nodejs/node@e4a7e0d28b)] - **deps**: float ea7abee from openssl / CVE-2018-0732 (Rod Vagg) [#21282](`nodejs/node#21282) * [[`0b90b071c4`](nodejs/node@0b90b071c4)] - **deps**: Upgrade node-inspect to 1.11.5 (Jan Krems) [#21055](`nodejs/node#21055) * [[`ffc29c12da`](nodejs/node@ffc29c12da)] - **deps**: patch V8 to 6.7.288.46 (Myles Borins) [#21260](`nodejs/node#21260) * [[`14bb905d18`](nodejs/node@14bb905d18)] - **deps**: V8: cherry-pick a440efb27f from upstream (Yang Guo) [#21022](`nodejs/node#21022) * [[`65b9c427ac`](nodejs/node@65b9c427ac)] - **dns**: improve setServers() errors and performance (Jamie Davis) [#20445](`nodejs/node#20445) * [[`bc20ec0c0f`](nodejs/node@bc20ec0c0f)] - **doc**: eliminate \_you\_ from N-API doc (Rich Trott) [#21382](`nodejs/node#21382) * [[`318d6831bf`](nodejs/node@318d6831bf)] - **doc**: use imperative in COLLABORATOR\_GUIDE (Rich Trott) [#21340](`nodejs/node#21340) * [[`177a7c06a8`](nodejs/node@177a7c06a8)] - **doc**: remove obsolete wiki references from BUILDING (Rich Trott) [#21369](`nodejs/node#21369) * [[`15023df050`](nodejs/node@15023df050)] - **doc**: add davisjam to collaborators (Jamie Davis) [#21273](`nodejs/node#21273) * [[`17c21b67ac`](nodejs/node@17c21b67ac)] - **doc**: fix indentation in console.md (Vse Mozhet Byt) [#21367](`nodejs/node#21367) * [[`ef74368416`](nodejs/node@ef74368416)] - **doc**: fix heading of optional console method args (Michaël Zasso) [#21311](`nodejs/node#21311) * [[`4f17841c20`](nodejs/node@4f17841c20)] - **doc**: use Class Method label consistently (Rich Trott) [#21357](`nodejs/node#21357) * [[`4566ebacf4`](nodejs/node@4566ebacf4)] - **doc**: wrap style guide at 80 characters (Rich Trott) [#21361](`nodejs/node#21361) * [[`6c41f33571`](nodejs/node@6c41f33571)] - **doc**: wrap pull-requests.md at 80 characters (Rich Trott) [#21361](`nodejs/node#21361) * [[`b8213f17cc`](nodejs/node@b8213f17cc)] - **doc**: remove linking of url text to url (Rich Trott) [#21361](`nodejs/node#21361) * [[`3f78220c2b`](nodejs/node@3f78220c2b)] - **doc**: correct styling of \_GitHub\_ in onboarding doc (Rich Trott) [#21361](`nodejs/node#21361) * [[`9e994cb119`](nodejs/node@9e994cb119)] - **doc**: wrap releases.md at 80 chars (Rich Trott) [#21361](`nodejs/node#21361) * [[`e00e5e6d5d`](nodejs/node@e00e5e6d5d)] - **doc**: switch the order of Writable and Readable (Joseph Gordon) [#21333](`nodejs/node#21333) * [[`e1b571d6b7`](nodejs/node@e1b571d6b7)] - **doc**: make Deprecation cycle explanation more brief (Rich Trott) [#21303](`nodejs/node#21303) * [[`df0f7a3b4d`](nodejs/node@df0f7a3b4d)] - **doc**: clarify async execute callback usage (Michael Dawson) [#21217](`nodejs/node#21217) * [[`c5a65594ef`](nodejs/node@c5a65594ef)] - **doc**: move 5 collaborators to emeritus status (Rich Trott) [#21272](`nodejs/node#21272) * [[`c1d53f86f8`](nodejs/node@c1d53f86f8)] - **doc**: update NODE\_OPTIONS section in cli.md (Vse Mozhet Byt) [#21229](`nodejs/node#21229) * [[`13fd09bfa7`](nodejs/node@13fd09bfa7)] - **doc**: add build wg info to releases.md (Jon Moss) [#21275](`nodejs/node#21275) * [[`0da910f9a5`](nodejs/node@0da910f9a5)] - **doc**: move Italo A. Casas to Release Emeritus (Myles Borins) [#21315](`nodejs/node#21315) * [[`6f7de0b8d9`](nodejs/node@6f7de0b8d9)] - **doc**: trim deprecation level definition text (Rich Trott) [#21241](`nodejs/node#21241) * [[`dd2fc90dcf`](nodejs/node@dd2fc90dcf)] - **doc**: fix reference to workerData in worker\_threads (Jeremiah Senkpiel) [#21180](`nodejs/node#21180) * [[`5e46c16371`](nodejs/node@5e46c16371)] - **doc**: fix type in stream doc (Aliaksei Tuzik) [#21178](`nodejs/node#21178) * [[`85dc9ac418`](nodejs/node@85dc9ac418)] - **doc**: add Michaël Zasso to Release team (Michaël Zasso) [#21114](`nodejs/node#21114) * [[`5fa5ab6c48`](nodejs/node@5fa5ab6c48)] - **doc**: naming function as suggested in addon docs (Tommaso Allevi) [#21067](`nodejs/node#21067) * [[`fe5d35123b`](nodejs/node@fe5d35123b)] - **(SEMVER-MINOR)** **doc**: document BigInt support in fs.Stats (Joyee Cheung) [#20220](`nodejs/node#20220) * [[`2c4f80ffba`](nodejs/node@2c4f80ffba)] - **doc**: remove spaces around slashes (Rich Trott) [#21140](`nodejs/node#21140) * [[`72e7e1da2d`](nodejs/node@72e7e1da2d)] - **doc**: alphabetize tls options (Rich Trott) [#21139](`nodejs/node#21139) * [[`06ac81e786`](nodejs/node@06ac81e786)] - **doc**: streamline errors.md introductory material (Rich Trott) [#21138](`nodejs/node#21138) * [[`73b8975b41`](nodejs/node@73b8975b41)] - **doc**: simplify deprecation language (Rich Trott) [#21136](`nodejs/node#21136) * [[`6caa354377`](nodejs/node@6caa354377)] - **(SEMVER-MINOR)** **doc**: explain Worker semantics in async\_hooks.md (Anna Henningsen) [#20876](`nodejs/node#20876) * [[`9f9355d6d2`](nodejs/node@9f9355d6d2)] - **doc**: fix inconsistent documentation (host vs hostname) (Davis Okoth) [#20933](`nodejs/node#20933) * [[`a5c571424a`](nodejs/node@a5c571424a)] - **doc**: document file mode caveats on Windows (Joyee Cheung) [#20636](`nodejs/node#20636) * [[`a75e44d135`](nodejs/node@a75e44d135)] - **esm**: ensure require.main for CJS top-level loads (Guy Bedford) [#21150](`nodejs/node#21150) * [[`04e8f0749e`](nodejs/node@04e8f0749e)] - **(SEMVER-MINOR)** **fs**: support BigInt in fs.\*stat and fs.watchFile (Joyee Cheung) [#20220](`nodejs/node#20220) * [[`c09bfd81b7`](nodejs/node@c09bfd81b7)] - **fs**: do not crash when using a closed fs event watcher (Joyee Cheung) [#20985](`nodejs/node#20985) * [[`bacb2cb550`](nodejs/node@bacb2cb550)] - **fs**: refactor fs module (James M Snell) [#20764](`nodejs/node#20764) * [[`db0bb5214a`](nodejs/node@db0bb5214a)] - **fs**: improve fchmod{Sync} validation (cjihrig) [#20588](`nodejs/node#20588) * [[`2ffb9d6b5c`](nodejs/node@2ffb9d6b5c)] - **fs**: drop duplicate API in promises mode (Сковорода Никита Андреевич) [#20559](`nodejs/node#20559) * [[`fc0b3610e2`](nodejs/node@fc0b3610e2)] - **fs**: don't limit ftruncate() length to 32 bits (cjihrig) [#20851](`nodejs/node#20851) * [[`469baa062e`](nodejs/node@469baa062e)] - **fs**: add length validation to fs.truncate() (cjihrig) [#20851](`nodejs/node#20851) * [[`6aade4a765`](nodejs/node@6aade4a765)] - **http**: remove a pair of outdated comments (Mark S. Everitt) [#21214](`nodejs/node#21214) * [[`bcaf59c739`](nodejs/node@bcaf59c739)] - **http2**: fix memory leak for uncommon headers (Anna Henningsen) [#21336](`nodejs/node#21336) * [[`dee250fd77`](nodejs/node@dee250fd77)] - **http2**: safer Http2Session destructor (Anatoli Papirovski) [#21194](`nodejs/node#21194) * [[`296fd57324`](nodejs/node@296fd57324)] - **inspector**: stop dragging platform pointer (Eugene Ostroukhov) * [[`fb71337bdf`](nodejs/node@fb71337bdf)] - **(SEMVER-MINOR)** **lib**: rename checkIsArrayBufferView() (Ben Noordhuis) [#20816](`nodejs/node#20816) * [[`f3570f201b`](nodejs/node@f3570f201b)] - **(SEMVER-MINOR)** **lib**: replace checkUint() with validateInt32() (Ben Noordhuis) [#20816](`nodejs/node#20816) * [[`b4b7d368be`](nodejs/node@b4b7d368be)] - **lib**: unmask mode\_t values with 0o777 (Joyee Cheung) [#20975](`nodejs/node#20975) * [[`36e5100a39`](nodejs/node@36e5100a39)] - **lib**: support ranges in validateInt32() (cjihrig) [#20588](`nodejs/node#20588) * [[`2fe88d2218`](nodejs/node@2fe88d2218)] - **lib**: mask mode\_t type of arguments with 0o777 (Joyee Cheung) [#20636](`nodejs/node#20636) * [[`a0cfb0c9d4`](nodejs/node@a0cfb0c9d4)] - **lib**: add validateInteger() validator (cjihrig) [#20851](`nodejs/node#20851) * [[`740d9f1a0e`](nodejs/node@740d9f1a0e)] - **lib,src**: make `StatWatcher` a `HandleWrap` (Anna Henningsen) [#21244](`nodejs/node#21244) * [[`a657984109`](nodejs/node@a657984109)] - **lib,src**: remove openssl feature conditionals (Ben Noordhuis) [#21094](`nodejs/node#21094) * [[`653b20b26d`](nodejs/node@653b20b26d)] - **loader**: remove unused error code in module\_job (Gus Caplan) [#21354](`nodejs/node#21354) * [[`5d3dfedca2`](nodejs/node@5d3dfedca2)] - **meta**: remove CODEOWNERS (Rich Trott) [#21161](`nodejs/node#21161) * [[`169bff3e9e`](nodejs/node@169bff3e9e)] - **n-api**: name CallbackBundle function fields (Anna Henningsen) [#21240](`nodejs/node#21240) * [[`1dc9330b3a`](nodejs/node@1dc9330b3a)] - **n-api**: improve runtime perf of n-api func call (Kenny Yuan) [#21072](`nodejs/node#21072) * [[`9047c8182c`](nodejs/node@9047c8182c)] - **n-api**: remove unused napi\_env member (Gabriel Schulhof) [#21127](`nodejs/node#21127) * [[`18c057ab26`](nodejs/node@18c057ab26)] - **net**: emit 'close' when socket ends before connect (Brett Kiefer) [#21290](`nodejs/node#21290) * [[`a3fd1cd8ea`](nodejs/node@a3fd1cd8ea)] - **perf_hooks**: remove less useful bootstrap marks (James M Snell) [#21247](`nodejs/node#21247) * [[`8fddf591c5`](nodejs/node@8fddf591c5)] - **perf_hooks**: set bootstrap complete in only one place (James M Snell) [#21247](`nodejs/node#21247) * [[`fc2956d37a`](nodejs/node@fc2956d37a)] - **process**: backport process/methods file (Michaël Zasso) [#21172](`nodejs/node#21172) * [[`78ad4e9dde`](nodejs/node@78ad4e9dde)] - **src**: remove unused argc var in node\_stat\_watcher (Daniel Bevenius) [#21337](`nodejs/node#21337) * [[`7fa1344143`](nodejs/node@7fa1344143)] - **src**: use `%zx` in printf for size\_t (Anna Henningsen) [#21323](`nodejs/node#21323) * [[`671346ee8f`](nodejs/node@671346ee8f)] - **src**: do proper error checking in `AsyncWrap::MakeCallback` (Anna Henningsen) [#21189](`nodejs/node#21189) * [[`aa468abc4c`](nodejs/node@aa468abc4c)] - **src**: unify native symbol inspection code (Anna Henningsen) [#21238](`nodejs/node#21238) * [[`e92b89a75d`](nodejs/node@e92b89a75d)] - **src**: fix http2 typos (Anatoli Papirovski) [#21194](`nodejs/node#21194) * [[`4f01168414`](nodejs/node@4f01168414)] - **src**: do not persist fs\_poll handle in stat\_watcher (Anatoli Papirovski) [#21093](`nodejs/node#21093) * [[`685b9b2a6a`](nodejs/node@685b9b2a6a)] - **src**: do not persist timer handle in cares\_wrap (Anatoli Papirovski) [#21093](`nodejs/node#21093) * [[`4757771db3`](nodejs/node@4757771db3)] - **src**: add consistency check to node\_platform.cc (Anna Henningsen) [#21156](`nodejs/node#21156) * [[`8e2e16721b`](nodejs/node@8e2e16721b)] - **src**: add node\_encoding.cc (James M Snell) [#21112](`nodejs/node#21112) * [[`39b38754eb`](nodejs/node@39b38754eb)] - **src**: cleanup beforeExit for consistency (James M Snell) [#21113](`nodejs/node#21113) * [[`314b47d1cf`](nodejs/node@314b47d1cf)] - **(SEMVER-MINOR)** **src**: add Env::profiler\_idle\_notifier\_started() (Timothy Gu) [#20876](`nodejs/node#20876) * [[`5209ff9562`](nodejs/node@5209ff9562)] - **(SEMVER-MINOR)** **src**: remove unused fields msg\_ and env\_ (Daniel Bevenius) [#20876](`nodejs/node#20876) * [[`9a734132f9`](nodejs/node@9a734132f9)] - **(SEMVER-MINOR)** **src**: make handle onclose property a Symbol (Anna Henningsen) [#20876](`nodejs/node#20876) * [[`e6f06807b1`](nodejs/node@e6f06807b1)] - **(SEMVER-MINOR)** **src**: simplify handle closing (Anna Henningsen) [#20876](`nodejs/node#20876) * [[`65924c70e8`](nodejs/node@65924c70e8)] - **(SEMVER-MINOR)** **src**: remove unused fields isolate\_ (Daniel Bevenius) [#20876](`nodejs/node#20876) * [[`de7403f813`](nodejs/node@de7403f813)] - **(SEMVER-MINOR)** **src**: cleanup per-isolate state on platform on isolate unregister (Anna Henningsen) [#20876](`nodejs/node#20876) * [[`ba17c9e46b`](nodejs/node@ba17c9e46b)] - **src**: refactor bootstrap to use bootstrap object (James M Snell) [#20917](`nodejs/node#20917) * [[`cbdc1fdf44`](nodejs/node@cbdc1fdf44)] - **src, tools**: add check for left leaning pointers (Daniel Bevenius) [#21010](`nodejs/node#21010) * [[`935309325b`](nodejs/node@935309325b)] - **test**: fix deprecation warning due to util.print (Tobias Nießen) [#21265](`nodejs/node#21265) * [[`d7ba75f8aa`](nodejs/node@d7ba75f8aa)] - **test**: add test to check colorMode type of Console (Masashi Hirano) [#21248](`nodejs/node#21248) * [[`0b00172df8`](nodejs/node@0b00172df8)] - **test**: removing unnecessary parameter from assert call (djmgit) [#21307](`nodejs/node#21307) * [[`dea3ac7bff`](nodejs/node@dea3ac7bff)] - **test**: improve statwatcher async\_hooks test (Anna Henningsen) [#21244](`nodejs/node#21244) * [[`792335f712`](nodejs/node@792335f712)] - **test**: add workerdata-sharedarraybuffer test (Jeremiah Senkpiel) [#21180](`nodejs/node#21180) * [[`e8d15cb149`](nodejs/node@e8d15cb149)] - **test**: mark test-inspector-port-zero-cluster flaky (Rich Trott) [#21251](`nodejs/node#21251) * [[`688bdfef7f`](nodejs/node@688bdfef7f)] - **test**: add crypto check to test-http2-debug (Daniel Bevenius) [#21205](`nodejs/node#21205) * [[`2270ab2a12`](nodejs/node@2270ab2a12)] - **test**: remove string literals from assert.strictEqual() calls (James Kylstra) [#21211](`nodejs/node#21211) * [[`187951c0fc`](nodejs/node@187951c0fc)] - **test**: move inspector-stress-http to sequential (Rich Trott) [#21227](`nodejs/node#21227) * [[`bda34ea203`](nodejs/node@bda34ea203)] - **test**: check gc does not resurrect the loop (Anatoli Papirovski) [#21093](`nodejs/node#21093) * [[`4d782c4720`](nodejs/node@4d782c4720)] - **test**: improve assert error messages (Hristijan Gjorgjievski) [#21160](`nodejs/node#21160) * [[`2655c7b194`](nodejs/node@2655c7b194)] - **test**: mark fs-readfile-tostring-fail flaky for all (Rich Trott) [#21177](`nodejs/node#21177) * [[`17954c2b01`](nodejs/node@17954c2b01)] - **test**: improve internal/buffer.js test coverage (Masashi Hirano) [#21061](`nodejs/node#21061) * [[`2ff4704447`](nodejs/node@2ff4704447)] - **test**: move test-readuint to test-buffer-readuint (Michaël Zasso) [#21170](`nodejs/node#21170) * [[`9c3a7bf076`](nodejs/node@9c3a7bf076)] - **test**: make url-util-format engine agnostic (Rich Trott) [#21141](`nodejs/node#21141) * [[`3d8ec8f85c`](nodejs/node@3d8ec8f85c)] - **test**: make url-parse-invalid-input engine agnostic (Rich Trott) [#21132](`nodejs/node#21132) * [[`0b0370f884`](nodejs/node@0b0370f884)] - **test**: remove unref in http2 test (Anatoli Papirovski) [#21145](`nodejs/node#21145) * [[`14a017cf8d`](nodejs/node@14a017cf8d)] - **test**: apply promises API to fourth appendFile test (Rich Trott) [#21131](`nodejs/node#21131) * [[`aa9dbf666b`](nodejs/node@aa9dbf666b)] - **test**: apply promises API to fourth appendFile test (Rich Trott) [#21131](`nodejs/node#21131) * [[`185b9e45d3`](nodejs/node@185b9e45d3)] - **test**: apply promises API to third appendFile test (Rich Trott) [#21131](`nodejs/node#21131) * [[`c400448e85`](nodejs/node@c400448e85)] - **test**: improve debug output in trace-events test (Rich Trott) [#21120](`nodejs/node#21120) * [[`a4ad9891e3`](nodejs/node@a4ad9891e3)] - **test**: add test for Linux perf (Matheus Marchini) [#20783](`nodejs/node#20783) * [[`e16036c462`](nodejs/node@e16036c462)] - **test**: create new directory v8-updates (Matheus Marchini) [#20783](`nodejs/node#20783) * [[`93ce63c89f`](nodejs/node@93ce63c89f)] - **(SEMVER-MINOR)** **test**: add test against unsupported worker features (Timothy Gu) [#20876](`nodejs/node#20876) * [[`94dcdfb898`](nodejs/node@94dcdfb898)] - **test**: increase coverage for fs.promises.truncate (Masashi Hirano) [#20638](`nodejs/node#20638) * [[`c9cee63179`](nodejs/node@c9cee63179)] - **test,tools**: refactor custom ESLint for readability (Rich Trott) [#21134](`nodejs/node#21134) * [[`ed05d9a821`](nodejs/node@ed05d9a821)] - **(SEMVER-MINOR)** **test,tools**: enable running tests under workers (Anna Henningsen) [#20876](`nodejs/node#20876) * [[`6285fe94f6`](nodejs/node@6285fe94f6)] - **tools**: do not disable `quotes` rule in .eslintrc.js (Rich Trott) [#21338](`nodejs/node#21338) * [[`98346de08c`](nodejs/node@98346de08c)] - **tools**: lint doc/\*.md files (Rich Trott) [#21361](`nodejs/node#21361) * [[`521f8f1d95`](nodejs/node@521f8f1d95)] - **tools**: add BigInt64Array and BigUint64Array to globals (Joyee Cheung) [#21255](`nodejs/node#21255) * [[`a5c386d1ba`](nodejs/node@a5c386d1ba)] - **tools**: add option to use custom template with js2c.py (Shelley Vohr) [#21187](`nodejs/node#21187) * [[`7f70fe83ef`](nodejs/node@7f70fe83ef)] - **tools**: add BigInt to globals (Nikolai Vavilov) [#21237](`nodejs/node#21237) * [[`4e742e379b`](nodejs/node@4e742e379b)] - **tools**: update tooling to work with new macOS CLI … (Rich Trott) [#21173](`nodejs/node#21173) * [[`ed2b57bcd5`](nodejs/node@ed2b57bcd5)] - **tools**: remove unused global types from type-parser (Rich Trott) [#21135](`nodejs/node#21135) * [[`d46446afc5`](nodejs/node@d46446afc5)] - **v8**: replace Buffer with FastBuffer in deserialize (Ujjwal Sharma) [#21196](`nodejs/node#21196) * [[`917960e0a1`](nodejs/node@917960e0a1)] - **win, build**: add documentation support to vcbuild (Bartosz Sosnowski) [#19663](`nodejs/node#19663) * [[`03fbc9e749`](nodejs/node@03fbc9e749)] - **(SEMVER-MINOR)** **worker**: rename to worker\_threads (Anna Henningsen) [#20876](`nodejs/node#20876) * [[`9ad42b766e`](nodejs/node@9ad42b766e)] - **(SEMVER-MINOR)** **worker**: improve error (de)serialization (Anna Henningsen) [#20876](`nodejs/node#20876) * [[`6b1a887aa2`](nodejs/node@6b1a887aa2)] - **(SEMVER-MINOR)** **worker**: enable stdio (Anna Henningsen) [#20876](`nodejs/node#20876) * [[`c97fb91e55`](nodejs/node@c97fb91e55)] - **(SEMVER-MINOR)** **worker**: restrict supported extensions (Timothy Gu) [#20876](`nodejs/node#20876) * [[`109c92e8fa`](nodejs/node@109c92e8fa)] - **(SEMVER-MINOR)** **worker**: initial implementation (Anna Henningsen) [#20876](`nodejs/node#20876) * [[`d1f372f052`](nodejs/node@d1f372f052)] - **(SEMVER-MINOR)** **worker**: add `SharedArrayBuffer` sharing (Anna Henningsen) [#20876](`nodejs/node#20876) * [[`f447acd87b`](nodejs/node@f447acd87b)] - **(SEMVER-MINOR)** **worker**: support MessagePort passing in messages (Anna Henningsen) [#20876](`nodejs/node#20876) * [[`337be58ee6`](nodejs/node@337be58ee6)] - **(SEMVER-MINOR)** **worker**: implement `MessagePort` and `MessageChannel` (Anna Henningsen) [#20876](`nodejs/node#20876) * [[`4a54ebc3bd`](nodejs/node@4a54ebc3bd)] - **worker,src**: display remaining handles if `uv\_loop\_close` fails (Anna Henningsen) [#21238](`nodejs/node#21238) * [[`529d24e3e8`](nodejs/node@529d24e3e8)] - ***Revert*** "**workers,trace_events**: set thread name for workers" (James M Snell) [#21363](`nodejs/node#21363) * [[`dfb5cf6963`](nodejs/node@dfb5cf6963)] - **workers,trace_events**: set thread name for workers (James M Snell) [#21246](`nodejs/node#21246) --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com).

jasnell added the semver-major PRs that contain breaking changes and should be released in the next major version. label May 16, 2018

nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label May 16, 2018

jasnell requested review from cjihrig and addaleax May 16, 2018 03:54

joyeecheung reviewed May 16, 2018

View reviewed changes

jasnell removed the semver-major PRs that contain breaking changes and should be released in the next major version. label May 16, 2018

targos approved these changes May 16, 2018

View reviewed changes

targos added the fs Issues and PRs related to the fs subsystem / file system. label May 16, 2018

jasnell force-pushed the fs-refactor-lazy branch 2 times, most recently from e2bba2d to 3169c16 Compare May 17, 2018 17:37

jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 17, 2018

jasnell force-pushed the fs-refactor-lazy branch from 3169c16 to cbb2efc Compare May 18, 2018 04:14

joyeecheung mentioned this pull request Jun 6, 2018

fs: do not crash when using a closed fs event watcher #20985

Closed

4 tasks

targos pushed a commit to targos/node that referenced this pull request Jun 6, 2018

fs: refactor fs module

b50c42e

PR-URL: nodejs#20764 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

targos pushed a commit that referenced this pull request Jun 7, 2018

fs: refactor fs module

b92e5a8

PR-URL: #20764 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Backport-PR-URL: #21172

targos added backported-to-v10.x and removed backport-requested-v10.x labels Jun 7, 2018

targos pushed a commit that referenced this pull request Jun 13, 2018

fs: refactor fs module

bacb2cb

PR-URL: #20764 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Backport-PR-URL: #21172

targos mentioned this pull request Jun 19, 2018

v10.5.0 proposal #21400

Merged

This was referenced Jun 20, 2018

2018-06-20 Version 10.5.0 (Current) @targos beevelop/docker-android-nodejs#216

Closed

2018-06-20 Version 10.5.0 (Current) @targos beevelop/docker-nodejs#201

Closed

This was referenced Jun 23, 2018

Node 10.5.x compatibility on CI for tests jestjs/jest#6532

Merged

Mocking of fs module in Jest broken in 10.5.0 #21489

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fs: refactor fs module #20764

fs: refactor fs module #20764

jasnell commented May 16, 2018 •

edited

Loading

jasnell commented May 16, 2018

joyeecheung May 16, 2018

jasnell May 16, 2018

joyeecheung May 16, 2018

jasnell May 16, 2018

jasnell May 16, 2018

joyeecheung May 16, 2018

jasnell May 16, 2018

ChALkeR commented May 16, 2018

jasnell commented May 16, 2018

joyeecheung commented May 16, 2018

jasnell commented May 16, 2018

targos commented May 16, 2018

jasnell commented May 16, 2018

jasnell commented May 16, 2018

jasnell commented May 16, 2018

jasnell commented May 16, 2018

benjamingr commented May 16, 2018 •

edited

Loading

jasnell commented May 16, 2018

jasnell commented May 16, 2018

jasnell commented May 16, 2018 •

edited

Loading

benjamingr commented May 16, 2018

jasnell commented May 16, 2018

jasnell commented May 16, 2018

targos May 16, 2018

jasnell May 17, 2018

targos May 16, 2018

jasnell May 17, 2018

jasnell commented May 18, 2018 •

edited

Loading

fs: refactor fs module #20764

fs: refactor fs module #20764

Conversation

jasnell commented May 16, 2018 • edited Loading

Checklist

jasnell commented May 16, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ChALkeR commented May 16, 2018

jasnell commented May 16, 2018

joyeecheung commented May 16, 2018

jasnell commented May 16, 2018

targos commented May 16, 2018

jasnell commented May 16, 2018

jasnell commented May 16, 2018

jasnell commented May 16, 2018

jasnell commented May 16, 2018

benjamingr commented May 16, 2018 • edited Loading

jasnell commented May 16, 2018

jasnell commented May 16, 2018

jasnell commented May 16, 2018 • edited Loading

benjamingr commented May 16, 2018

jasnell commented May 16, 2018

jasnell commented May 16, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jasnell commented May 18, 2018 • edited Loading

jasnell commented May 16, 2018 •

edited

Loading

benjamingr commented May 16, 2018 •

edited

Loading

jasnell commented May 16, 2018 •

edited

Loading

jasnell commented May 18, 2018 •

edited

Loading