Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 10.5.x compatibility on CI for tests #6532

Merged
merged 1 commit into from
Jun 24, 2018
Merged

Conversation

palmerj3
Copy link
Contributor

Summary

Fixes #6529

jest.mock('fn') does not seem to include fs.ReadStream or fs.WriteStream in the resulting mocked module. This updates the tests to specify them in the mock.

I'm assuming larger work is required in jest-mock to address this directly.

Test plan

All tests pass locally on 10.5.x

@SimenB
Copy link
Member

SimenB commented Jun 23, 2018

Thanks!

While this is better than failing CI, we should probably report it. Maybe it's nodejs/node#20764?

@palmerj3
Copy link
Contributor Author

@SimenB ah yeah good call. That does seem relevant.

@codecov-io
Copy link

Codecov Report

Merging #6532 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6532   +/-   ##
=======================================
  Coverage   63.85%   63.85%           
=======================================
  Files         234      234           
  Lines        8800     8800           
  Branches        3        4    +1     
=======================================
  Hits         5619     5619           
  Misses       3180     3180           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24df075...45ca2f3. Read the comment docs.

@SimenB
Copy link
Member

SimenB commented Jun 23, 2018

Opened up issue with Node: nodejs/node#21489

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can just land this in the meantime though, annoying for PRs that CI fail. Easy enough to revert whenever we land a real fix (regardless of a fix/revert in node, we should handle getters)

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate Node 10.5.0 test failures
4 participants