[v6.x] v8: handle proxy objects in MakeMirror() #14343

bnoordhuis · 2017-07-18T10:54:28Z

Fix for #8224 and #10406, and the continuation of #10409.

First commit is a back-port of #10409 to v6.x, the second one is what I think is a better fix: it turns the proxy into a black box that cannot be inspected (because inspection has side-effects with proxied objects.)

Input welcome.

Node CI: https://ci.nodejs.org/job/node-test-pull-request/9215/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/792/

MylesBorins · 2017-07-18T18:32:57Z

There seem to be quite a few failures in CI... I'm running a job against the staging branch to see if they are related to this PR

MylesBorins · 2017-07-18T19:24:11Z

Re running V8 Ci https://ci.nodejs.org/job/node-test-commit-v8-linux/794/

targos · 2017-07-18T19:25:52Z

@MylesBorins you need #14219 to unbreak V8 CI

MylesBorins · 2017-07-18T19:36:42Z

One more time with V8 fix https://ci.nodejs.org/job/node-test-commit-v8-linux/795/

MylesBorins · 2017-07-18T20:04:08Z

So it looks like it is breaking during compilation... assuming that it is rebasing, then this change appears to be breaking stuff. @bnoordhuis would you be up for rebasing against v6.x-staging just to play it safe

bnoordhuis · 2017-07-19T11:44:10Z

Rebased, although I get the impression it's a CI bug more than anything else. I saw this in the s390x build log:

/bin/sh: line 0: cd: ../deps/v8/tools/gyp: No such file or directory
python: can't open file '../../tools/js2c.py': [Errno 2] No such file or directory

Node CI: https://ci.nodejs.org/job/node-test-pull-request/9249/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/798/

jasnell · 2017-07-19T21:11:17Z

fwiw, I've seen that pop up in CI from time to time. I agree it's likely not an issue with this PR

MylesBorins · 2017-07-21T18:02:55Z

@bnoordhuis do we land both fixes or only need to land one or the other?

/cc @nodejs/v8 for review

For consistency with 4.x and 8.x. This commit also contains a forward port of nodejs#14232 to confirm that 4.x and 6.x behave identically with respect to the port argument. PR-URL: nodejs#14234 Refs: nodejs#14205 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

This is an initial step to eliminate most of parsing errors. Backport-PR-URL: nodejs#14067 PR-URL: nodejs#12563 Refs: nodejs#12557 (comment) Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>

Backport-PR-URL: nodejs#14067 PR-URL: nodejs#12563 Refs: nodejs#12557 (comment) Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>

* Install eslint-plugin-markdown@1.0.0-beta.7 * Add doc/.eslintrc.yaml * Add `plugins: [markdown]` to the main .eslintrc.yaml * .js files in doc folder added to .eslintignore * Update Makefile, vcbuild.bat, and tools/jslint.js Refs: nodejs#12563 Refs: nodejs#12640 Refs: nodejs#14047 PR-URL: nodejs#14067 Reviewed-By: James Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>

The `no-useless-regex-char-class-escape` custom lint rule was introduced as a less aggressive alternative to some enhancements that were introduced into ESLint. Those enhancements were blocking us from updating ESLint. However, they have since been relaxed and the custom rule is no longer needed. Remove it. Backport-PR-URL: nodejs#14360 PR-URL: nodejs#10561 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

In preparation for applying the more strict indentation linting available in ESLint 4.0.0, correct minor indentation issues in tools/eslint-rules/required-modules.js. This is the only file with indentation that does not conform to the stricter checks. Backport-PR-URL: nodejs#14360 PR-URL: nodejs#13758 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

ESLint 4.0.0 provides stricter (and more granular) indentation checking than previous versions. Apply the stricter indentation rules to the tools directory. Backport-PR-URL: nodejs#14360 PR-URL: nodejs#13758 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

Fix previously-unnoticed typo in `required-modules.js`. Backport-PR-URL: nodejs#14360 Refs: nodejs#13758 (comment) PR-URL: nodejs#13758 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

* Remove needless RegExp flag In fixed case, `/g` flag is needless in the boolean context. * Remove needless RegExp capturing Use non-capturing grouping or remove capturing completely when: * capturing is useless per se, e.g. in test() check; * captured groups are not used afterward at all; * some of the later captured groups are not used afterward. * Use test, not match/exec in boolean context match() and exec() return a complicated object, unneeded in a boolean context. * Do not needlessly repeat RegExp creation This commit takes RegExp creation out of cycles and other repetitions. As long as the RegExp does not use /g flag and match indices, we are safe here. In tests, this fix hardly gives a significant performance gain, but it increases clarity and maintainability, reassuring some RegExps to be identical. RegExp in functions are not taken out of their functions: while these functions are called many times and their RegExps are recreated with each call, the performance gain in test cases does not seem to be worth decreasing function self-dependency. Backport-PR-URL: nodejs#14370 PR-URL: nodejs#13770 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

This option has been broken for almost a year when used with any of the vm.runIn.. family of functions, except for syntax errors. Backport-PR-URL: nodejs#14373 PR-URL: nodejs#13074 Reviewed-By: Anna Henningsen <anna@addaleax.net>

This fixes a race condition in the watchdog timer used for vm timeouts. The condition would terminate the main stack's execution instead of the code running under the sandbox. Backport-PR-URL: nodejs#14373 PR-URL: nodejs#13074 Reviewed-By: Anna Henningsen <anna@addaleax.net>

Backport-PR-URL: nodejs#14416 PR-URL: nodejs#13206 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>

This commit allows self signed certificates to work with unix sockets by forwarding the rejectUnauthorized option. Backport-PR-URL: nodejs#14415 Fixes: nodejs#13470 PR-URL: nodejs#13505 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

root_cert_store is defined as extern in node_crypto.h but only used in node_crypto.cc. It is then set using SSL_CTX_set_cert_store. The only usages of SSL_CTX_get_cert_store are in node_crypto.cc which would all be accessing the same X509_STORE through the root_cert_store pointer as far as I can tell. Am I missing something here? This commit suggests removing it from the header and making it static in node_crypto.cc. PR-URL: nodejs#13194 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

bnoordhuis · 2017-07-24T15:06:06Z

Okay, let's land both. Rebased again.

MylesBorins · 2017-08-14T15:38:14Z

landed in d75363b...f3dfbeb

MylesBorins · 2017-08-14T17:29:25Z

Had to back it out... the changes were breaking test-child-process-detached on AIX + vs2015

CI Job

not ok 56 parallel/test-child-process-detached
  ---
  duration_ms: 0.720
  severity: fail
  stack: |-
    
    assert.js:81
      throw new assert.AssertionError({
      ^
    AssertionError: Got unwanted exception..
        at _throws (assert.js:356:5)
        at Function.assert.doesNotThrow (assert.js:374:3)
        at process.<anonymous> (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/parallel/test-child-process-detached.js:22:10)
        at emitOne (events.js:101:20)
        at process.emit (events.js:188:7)
  ...

edit: I don't think this is related, am going to reland

PR-URL: #14343 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins · 2017-08-16T03:58:10Z

problem was unrelated relanded in d35e5c7...5a93c16

PR-URL: #14343 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot added v6.x v8 engine Issues and PRs related to the V8 dependency. labels Jul 18, 2017

bnoordhuis mentioned this pull request Jul 18, 2017

v8: make ObjectMirror handle proxy objects #10409

Closed

refack approved these changes Jul 18, 2017

View reviewed changes

cjihrig approved these changes Jul 18, 2017

View reviewed changes

bnoordhuis force-pushed the fix10409-v6 branch from 686605c to 1611f14 Compare July 19, 2017 11:42

jasnell approved these changes Jul 19, 2017

View reviewed changes

addaleax changed the title ~~v8: handle proxy objects in MakeMirror()~~ [v6.x] v8: handle proxy objects in MakeMirror() Jul 20, 2017

sam-github and others added 9 commits July 21, 2017 14:35

MylesBorins force-pushed the v6.x-staging branch from d29fd52 to 97f5806 Compare July 21, 2017 18:35

laverdet and others added 4 commits July 21, 2017 14:37

vm: fix displayErrors in runIn.. functions

565c556

This option has been broken for almost a year when used with any of the vm.runIn.. family of functions, except for syntax errors. Backport-PR-URL: nodejs#14373 PR-URL: nodejs#13074 Reviewed-By: Anna Henningsen <anna@addaleax.net>

bnoordhuis closed this Jul 24, 2017

bnoordhuis force-pushed the fix10409-v6 branch from 1611f14 to 7b8fcf8 Compare July 24, 2017 15:04

bnoordhuis added 2 commits July 24, 2017 17:05

v8: handle proxy objects in MakeMirror(), v1

243c207

v8: handle proxy objects in MakeMirror(), v2

e1bc3a3

bnoordhuis reopened this Jul 24, 2017

sam-github force-pushed the v6.x-staging branch from d62ccc5 to 7b8fcf8 Compare July 25, 2017 15:34

MylesBorins force-pushed the v6.x-staging branch from 7b8fcf8 to f4691bb Compare August 1, 2017 07:09

MylesBorins force-pushed the v6.x-staging branch 2 times, most recently from 0ae4c46 to d75363b Compare August 14, 2017 15:32

MylesBorins closed this Aug 14, 2017

MylesBorins reopened this Aug 14, 2017

MylesBorins force-pushed the v6.x-staging branch 2 times, most recently from cebce8b to 5a93c16 Compare August 16, 2017 03:57

MylesBorins pushed a commit that referenced this pull request Aug 16, 2017

v8: handle proxy objects in MakeMirror(), v1

194836f

PR-URL: #14343 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request Aug 16, 2017

v8: handle proxy objects in MakeMirror(), v2

5a93c16

PR-URL: #14343 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins closed this Aug 16, 2017

MylesBorins mentioned this pull request Aug 16, 2017

v6.11.3-proposal #14852

Merged

MylesBorins pushed a commit that referenced this pull request Sep 5, 2017

v8: handle proxy objects in MakeMirror(), v1

bccd2f5

PR-URL: #14343 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins pushed a commit that referenced this pull request Sep 5, 2017

v8: handle proxy objects in MakeMirror(), v2

9e2d85e

PR-URL: #14343 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

targos mentioned this pull request Nov 24, 2017

REPL debugging Proxy bug #8224

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[v6.x] v8: handle proxy objects in MakeMirror() #14343

[v6.x] v8: handle proxy objects in MakeMirror() #14343

bnoordhuis commented Jul 18, 2017 •

edited

Loading

MylesBorins commented Jul 18, 2017

MylesBorins commented Jul 18, 2017

targos commented Jul 18, 2017

MylesBorins commented Jul 18, 2017

MylesBorins commented Jul 18, 2017

bnoordhuis commented Jul 19, 2017

jasnell commented Jul 19, 2017

MylesBorins commented Jul 21, 2017

bnoordhuis commented Jul 24, 2017

MylesBorins commented Aug 14, 2017

MylesBorins commented Aug 14, 2017 •

edited

Loading

MylesBorins commented Aug 16, 2017

[v6.x] v8: handle proxy objects in MakeMirror() #14343

[v6.x] v8: handle proxy objects in MakeMirror() #14343

Conversation

bnoordhuis commented Jul 18, 2017 • edited Loading

MylesBorins commented Jul 18, 2017

MylesBorins commented Jul 18, 2017

targos commented Jul 18, 2017

MylesBorins commented Jul 18, 2017

MylesBorins commented Jul 18, 2017

bnoordhuis commented Jul 19, 2017

jasnell commented Jul 19, 2017

MylesBorins commented Jul 21, 2017

bnoordhuis commented Jul 24, 2017

MylesBorins commented Aug 14, 2017

MylesBorins commented Aug 14, 2017 • edited Loading

MylesBorins commented Aug 16, 2017

bnoordhuis commented Jul 18, 2017 •

edited

Loading

MylesBorins commented Aug 14, 2017 •

edited

Loading