Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REPL debugging Proxy bug #8224

Closed
Gi60s opened this issue Aug 22, 2016 · 8 comments
Closed

REPL debugging Proxy bug #8224

Gi60s opened this issue Aug 22, 2016 · 8 comments
Labels
repl Issues and PRs related to the REPL subsystem. v8 engine Issues and PRs related to the V8 dependency.

Comments

@Gi60s
Copy link

Gi60s commented Aug 22, 2016

Example Code:

var p = new Proxy([], {});
p[0] = 'abc';
console.log('done');

Problem:

Running in debug mode via node debug index.js, REPL cannot get the value of p, instead outputting illegal access. Getting p[0] or p.length within REPL works.

Additional Notes:

  • Remote debuggers are unable to debug as soon as a new Proxy instance is created. (This might be related to REPL I'm guessing.)
  • I have tried multiple handle configurations for the Proxy. All have produced this same result.
@mscdex mscdex added repl Issues and PRs related to the REPL subsystem. v8 engine Issues and PRs related to the V8 dependency. labels Aug 22, 2016
@mscdex
Copy link
Contributor

mscdex commented Aug 22, 2016

The example works for me with node v6.3.1 on Linux.

@targos
Copy link
Member

targos commented Aug 22, 2016

I can reproduce with v6.4.0

@targos
Copy link
Member

targos commented Aug 22, 2016

I can also reproduce it with V8 5.1 (#8054).
I tried with V8 5.4 and I get a crash in runtime-debug.cc. Investigating...

@targos
Copy link
Member

targos commented Aug 22, 2016

Basic repro:

$ node --expose-debug-as=debug
> var p = new Proxy([],{})
undefined
> debug.MakeMirror(p)
illegal access

Related V8 issue: https://bugs.chromium.org/p/v8/issues/detail?id=3270

@Trott
Copy link
Member

Trott commented Jul 10, 2017

@targos Would I be right to conclude that this bug is relevant in 6.x but not in 8.x because we don't use the legacy debugger API anymore?

@TimothyGu
Copy link
Member

A fix for this issue is in #10409, though that is stalled.

@targos
Copy link
Member

targos commented Jul 10, 2017

@Trott that would be right.

@targos
Copy link
Member

targos commented Nov 24, 2017

Fixed in #14343

@targos targos closed this as completed Nov 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repl Issues and PRs related to the REPL subsystem. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

No branches or pull requests

5 participants