build: --without-profiler option, add Windows build options #10140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 6, 2016 09:37
Hides ugly warnings in Windows build
nodejs-github-bot
added
build
This was referenced Dec 6, 2016
|
When and why exactly would you want to disable the profiler? "Build warnings" doesn't seem like a good reason. |
|
Status updates on this one? |
|
There hasn't been any activity here. I'm closing this. Feel free to reopen (or ping a collaborator) if I closed this in error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX [macOS]; Linux i386 & amd64) andvcbuild test nosign(.\vcbuild.bat nosignthen.\vcbuild.bat test nosign nobuildas Administrator on Windows) PASS OKAdditional item
Affected core subsystem(s)
build
Description of change
--without-profileroption to build with code related tov8-profiler.hdisabledvcbuild.bataddwithout-inspector&without-profileroptionsThese options can be used to silence some ugly build warnings ref: PR #10139