Remove deprecated compatibility code. #1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlau
reviewed
Feb 14, 2019
test/docker.sh
Outdated
| @@ -3,7 +3,6 @@ | |||
| #set -e | |||
|
|
|||
| test_node_versions="0.8.28 0.10.40 0.12.7 4.3.0 5.6.0" | |||
There was a problem hiding this comment.
Should we be updating these (perhaps in a different PR) to in support versions of Node.js?
There was a problem hiding this comment.
Yep, good idea. I could do that as a separate commit or a separate PR.
There was a problem hiding this comment.
Yep, good idea. I could do that as a separate commit or a separate PR.
Your choice 😄
|
Updated after some delay... CI: https://ci.nodejs.org/view/All/job/nodegyp-test-pull-request/116/ (edit: green!) |
richardlau
approved these changes
Mar 19, 2019
* Remove support for the IOJS_ORG_MIRROR, NVM_IOJS_ORG_MIRROR and NVM_NODEJS_ORG_MIRROR enviroment variables. * Remove obsolete support for io.js. It's been out of support for over three years now. PR-URL: #1670 Reviewed-By: Richard Lau <riclau@uk.ibm.com>
PR-URL: #1670 Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Closed
This was referenced Oct 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove support for the IOJS_ORG_MIRROR, NVM_IOJS_ORG_MIRROR
and NVM_NODEJS_ORG_MIRROR enviroment variables.
Remove obsolete support for io.js. It's been out of support
for over three years now.