node-gyp 5.0 breaks support for Electron versions < 4 #1778
Comments
This was referenced Jun 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
{{ message }}
This PR --> #1670 removes support for obsolete io.js versions, this is perfectly valid however because of the way that logic was originally implemented, over on the Electron team for our 1.x/2.x/3.x releases, we had to publish our headers with the
iojsprefix instead of thenodeprefix.As of
node-gyp@5.0these versions no longer work and currently we still support Electron 3 so ideally this would be fixed. I've raised a simple "revent the PR that broke it" PR, if that's acceptable it would be great to merge and release that, otherwise I can craft a PR to specifically introduce support back for these headers.Revert PR: #1777
Refs: electron/electron#18787
The text was updated successfully, but these errors were encountered: