Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code cleanup -warnings #164

Closed
mhdawson opened this issue Oct 25, 2017 · 4 comments
Closed

Code cleanup -warnings #164

mhdawson opened this issue Oct 25, 2017 · 4 comments
Labels
help wanted

Comments

@mhdawson
Copy link
Member

There are a bunch of warnings when I run the tests on linux with npm test

Would be great to clean these up:

In file included from /home/mhdawson/newpull/land/node-addon-api/napi.h:1442:0,
                 from ../objectwrap.cc:1:
/home/mhdawson/newpull/land/node-addon-api/napi-inl.h: In instantiation of âstatic Napi::ClassPropertyDescriptor<T> Napi::ObjectWrap<T>::InstanceMethod(const char*, Napi::ObjectWrap<T>::InstanceMethodCallback, napi_property_attributes, void*) [with T = TestIter; Napi::ObjectWrap<T>::InstanceMethodCallback = Napi::Value (TestIter::*)(const Napi::CallbackInfo&)]â:
../objectwrap.cc:15:45:   required from here
/home/mhdawson/newpull/land/node-addon-api/napi-inl.h:2509:36: warning: missing initializer for member ânapi_property_descriptor::utf8nameâ [-Wmissing-field-initializers]
   napi_property_descriptor desc = {};
                                    ^
/home/mhdawson/newpull/land/node-addon-api/napi-inl.h:2509:36: warning: missing initializer for member ânapi_property_descriptor::nam â [-Wmissing-field-initializers]
/home/mhdawson/newpull/land/node-addon-api/napi-inl.h:2509:36: warning: missing initializer for member ânapi_property_descriptor::methodâ [-Wmissing-field-initializers]
/home/mhdawson/newpull/land/node-addon-api/napi-inl.h:2509:36: warning: missing initializer for member ânapi_property_descriptor::getterâ [-Wmissing-field-initializers]
/home/mhdawson/newpull/land/node-addon-api/napi-inl.h:2509:36: warning: missing initializer for member ânapi_property_descriptor::setterâ [-Wmissing-field-initializers]
/home/mhdawson/newpull/land/node-addon-api/napi-inl.h:2509:36: warning: missing initializer for member ânapi_property_descriptor::valueâ [-Wmissing-field-initializers]
/home/mhdawson/newpull/land/node-addon-api/napi-inl.h:2509:36: warning: missing initializer for member ânapi_property_descriptor::attributesâ [-Wmissing-field-initializers]
/home/mhdawson/newpull/land/node-addon-api/napi-inl.h:2509:36: warning: missing initializer for member ânapi_property_descriptor::dat â [-Wmissing-field-initializers]
/home/mhdawson/newpull/land/node-addon-api/napi-inl.h: In instantiation of âstatic Napi::ClassPropertyDescriptor<T> Napi::ObjectWrap<T>::InstanceMethod(const char*, Napi::ObjectWrap<T>::InstanceVoidMethodCallback, napi_property_attributes, void*) [with T = Test; Napi::ObjectWrap<T>::InstanceVoidMethodCallback = void (Test::*)(const Napi::CallbackInfo&)]â:
../objectwrap.cc:54:57:   required from here
/home/mhdawson/newpull/land/node-addon-api/napi-inl.h:2492:36: warning: missing initializer for member ânapi_property_descriptor::utf8nameâ [-Wmissing-field-initializers]
   napi_property_descriptor desc = {};
                                    ^
/home/mhdawson/newpull/land/node-addon-api/napi-inl.h:2492:36: warning: missing initializer for member ânapi_property_descriptor::nam â [-Wmissing-field-initializers]
/home/mhdawson/newpull/land/node-addon-api/napi-inl.h:2492:36: warning: missing initializer for member ânapi_property_descriptor::methodâ [-Wmissing-field-initializers]
/home/mhdawson/newpull/land/node-addon-api/napi-inl.h:2492:36: warning: missing initializer for member ânapi_property_descriptor::getterâ [-Wmissing-field-initializers]
/home/mhdawson/newpull/land/node-addon-api/napi-inl.h:2492:36: warning: missing initializer for member ânapi_property_descriptor::setterâ [-Wmissing-field-initializers]
/home/mhdawson/newpull/land/node-addon-api/napi-inl.h:2492:36: warning: missing initializer for member ânapi_property_descriptor::valueâ [-Wmissing-field-initializers]
/home/mhdawson/newpull/land/node-addon-api/napi-inl.h:2492:36: warning: missing initializer for member ânapi_property_descriptor::attributesâ [-Wmissing-field-initializers]
/home/mhdawson/newpull/land/node-addon-api/napi-inl.h:2492:36: warning: missing initializer for member ânapi_property_descriptor::dat â [-Wmissing-field-initializers]
/home/mhdawson/newpull/land/node-addon-api/napi-inl.h: In instantiation of âstatic Napi::ClassPropertyDescriptor<T> Napi::ObjectWrap<T>::InstanceMethod(const char*, Napi::ObjectWrap<T>::InstanceMethodCallback, napi_property_attributes, void*) [with T = Test; Napi::ObjectWrap<T>::InstanceMethodCallback = Napi::Value (Test::*)(const Napi::CallbackInfo&)]â:
../objectwrap.cc:55:57:   required from here
/home/mhdawson/newpull/land/node-addon-api/napi-inl.h:2509:36: warning: missing initializer for member ânapi_property_descriptor::utf8nameâ [-Wmissing-field-initializers]
   napi_property_descriptor desc = {};
                                    ^
/home/mhdawson/newpull/land/node-addon-api/napi-inl.h:2509:36: warning: missing initializer for member ânapi_property_descriptor::nam â [-Wmissing-field-initializers]
/home/mhdawson/newpull/land/node-addon-api/napi-inl.h:2509:36: warning: missing initializer for member ânapi_property_descriptor::methodâ [-Wmissing-field-initializers]
/home/mhdawson/newpull/land/node-addon-api/napi-inl.h:2509:36: warning: missing initializer for member ânapi_property_descriptor::getterâ [-Wmissing-field-initializers]
/home/mhdawson/newpull/land/node-addon-api/napi-inl.h:2509:36: warning: missing initializer for member ânapi_property_descriptor::setterâ [-Wmissing-field-initializers]
/home/mhdawson/newpull/land/node-addon-api/napi-inl.h:2509:36: warning: missing initializer for member ânapi_property_descriptor::valueâ [-Wmissing-field-initializers]
/home/mhdawson/newpull/land/node-addon-api/napi-inl.h:2509:36: warning: missing initializer for member ânapi_property_descriptor::attributesâ [-Wmissing-field-initializers]
/home/mhdawson/newpull/land/node-addon-api/napi-inl.h:2509:36: warning: missing initializer for member ânapi_property_descriptor::dat â [-Wmissing-field-initializers]
/home/mhdawson/newpull/land/node-addon-api/napi-inl.h: In instantiation of âstatic Napi::ClassPropertyDescriptor<T> Napi::ObjectWrap<T>::InstanceMethod(Napi::Symbol, Napi::ObjectWrap<T>::InstanceMethodCallback, napi_property_attributes, void*) [with T = Test; Napi::ObjectWrap<T>::InstanceMethodCallback = Napi::Value (Test::*)(const Napi::CallbackInfo&)]â:
../objectwrap.cc:56:75:   required from here
/home/mhdawson/newpull/land/node-addon-api/napi-inl.h:2544:36: warning: missing initializer for member ânapi_property_descriptor::utf8nameâ [-Wmissing-field-initializers]
   napi_property_descriptor desc = {};
                                    ^
/home/mhdawson/newpull/land/node-addon-api/napi-inl.h:2544:36: warning: missing initializer for member ânapi_property_descriptor::nam â [-Wmissing-field-initializers]
/home/mhdawson/newpull/land/node-addon-api/napi-inl.h:2544:36: warning: missing initializer for member ânapi_property_descriptor::methodâ [-Wmissing-field-initializers]
/home/mhdawson/newpull/land/node-addon-api/napi-inl.h:2544:36: warning: missing initializer for member ânapi_property_descriptor::getterâ [-Wmissing-field-initializers]
/home/mhdawson/newpull/land/node-addon-api/napi-inl.h:2544:36: warning: missing initializer for member ânapi_property_descriptor::setterâ [-Wmissing-field-initializers]
/home/mhdawson/newpull/land/node-addon-api/napi-inl.h:2544:36: warning: missing initializer for member ânapi_property_descriptor::valueâ [-Wmissing-field-initializers]
/home/mhdawson/newpull/land/node-addon-api/napi-inl.h:2544:36: warning: missing initializer for member ânapi_property_descriptor::attributesâ [-Wmissing-field-initializers]
/home/mhdawson/newpull/land/node-addon-api/napi-inl.h:2544:36: warning: missing initializer for member ânapi_property_descriptor::dat â [-Wmissing-field-initializers]
/home/mhdawson/newpull/land/node-addon-api/napi-inl.h: In instantiation of âstatic Napi::ClassPropertyDescriptor<T> Napi::ObjectWrap<T>::InstanceAccessor(const char*, Napi::ObjectWrap<T>::InstanceGetterCallback, Napi::ObjectWrap<T>::InstanceSetterCallback, napi_property_attributes, void*) [with T = Test; Napi::ObjectWrap<T>::InstanceGetterCallback = Napi::Value (Test::*)(const Napi::CallbackInfo&); Napi::ObjectWrap<T>::InstanceSetterCallback = void (Test::*)(const Napi::CallbackInfo&, const Napi::Value&)]â:
../objectwrap.cc:57:7:   required from here
/home/mhdawson/newpull/land/node-addon-api/napi-inl.h:2563:36: warning: missing initializer for member ânapi_property_descriptor::utf8nameâ [-Wmissing-field-initializers]
   napi_property_descriptor desc = {};
                                    ^
/home/mhdawson/newpull/land/node-addon-api/napi-inl.h:2563:36: warning: missing initializer for member ânapi_property_descriptor::nam â [-Wmissing-field-initializers]
/home/mhdawson/newpull/land/node-addon-api/napi-inl.h:2563:36: warning: missing initializer for member ânapi_property_descriptor::methodâ [-Wmissing-field-initializers]
/home/mhdawson/newpull/land/node-addon-api/napi-inl.h:2563:36: warning: missing initializer for member ânapi_property_descriptor::getterâ [-Wmissing-field-initializers]
/home/mhdawson/newpull/land/node-addon-api/napi-inl.h:2563:36: warning: missing initializer for member ânapi_property_descriptor::setterâ [-Wmissing-field-initializers]
/home/mhdawson/newpull/land/node-addon-api/napi-inl.h:2563:36: warning: missing initializer for member ânapi_property_descriptor::valueâ [-Wmissing-field-initializers]
/home/mhdawson/newpull/land/node-addon-api/napi-inl.h:2563:36: warning: missing initializer for member ânapi_property_descriptor::attributesâ [-Wmissing-field-initializers]
/home/mhdawson/newpull/land/node-addon-api/napi-inl.h:2563:36: warning: missing in
@romandev
Copy link
Contributor

@mhdawson Can I take this issue?

romandev added a commit to romandev/node-addon-api that referenced this issue Oct 27, 2017
@romandev
Fix warnings when running npm test
53f8695 
The warnings occur due to a bug in gcc(<5.1.1)[1]. To fix this issue,
we can use constructor initializer instead of empty braces initializer.

This change is fixing nodejs#164 issue.

[1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61489
@romandev romandev mentioned this issue Oct 27, 2017
Closed
@mhdawson
Copy link
Member Author

@romandev sure, would be great :)

@mhdawson
Copy link
Member Author

@romandev if you are looking for other things to pick up as well check out #163.

@romandev
Copy link
Contributor

@mhdawson Thank you for reply. I'll check it and write remaining tests.

kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this issue Aug 24, 2022
@kevindavies8
src: Fix warnings when running npm test
7aba1a0 
The warnings occur due to a bug in gcc(<5.1.1)[1]. To fix this issue,
we can use constructor initializer instead of empty braces initializer.

[1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61489

Fixes: nodejs/node-addon-api#164
PR-URL: nodejs/node-addon-api#166
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this issue Aug 26, 2022
@Marlyfleitas
src: Fix warnings when running npm test
8f71db7 
The warnings occur due to a bug in gcc(<5.1.1)[1]. To fix this issue,
we can use constructor initializer instead of empty braces initializer.

[1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61489

Fixes: nodejs/node-addon-api#164
PR-URL: nodejs/node-addon-api#166
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this issue Sep 19, 2022
@wroy7860
src: Fix warnings when running npm test
8189ab5 
The warnings occur due to a bug in gcc(<5.1.1)[1]. To fix this issue,
we can use constructor initializer instead of empty braces initializer.

[1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61489

Fixes: nodejs/node-addon-api#164
PR-URL: nodejs/node-addon-api#166
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this issue Aug 11, 2023
src: Fix warnings when running npm test
f1369ed 
The warnings occur due to a bug in gcc(<5.1.1)[1]. To fix this issue,
we can use constructor initializer instead of empty braces initializer.

[1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61489

Fixes: nodejs/node-addon-api#164
PR-URL: nodejs/node-addon-api#166
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@romandev @mhdawson